Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback CNAO to v0.67.0 and update NMO digests #1805

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Rollback CNAO to v0.67.0 and update NMO digests #1805

merged 1 commit into from
Mar 3, 2022

Conversation

tiraboschi
Copy link
Member

CNAO v0.68.0 ships multus v3.8 that introduces some
race condition with CDI pods on removal
making or CI lanes on k8s really unstable
(OCP is not affected using a different multus image).
Refreshing NMO digests to unlock CI.

Signed-off-by: Simone Tiraboschi stirabos@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Release note:

Rollback CNAO to v0.67.0 and update NMO digests

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Mar 3, 2022
@kubevirt-bot kubevirt-bot requested a review from sradco March 3, 2022 14:58
@tiraboschi
Rollback CNAO to v0.67.0 and update NMO digests
036b065 
CNAO v0.68.0 ships multus v3.8 that introduces some
race condition with CDI pods on removal
making or CI lanes on k8s really unstable
(OCP is not affected using a different multus image).
Refreshing NMO digests to unlock CI.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 1928894464

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.216%
Totals Coverage Status
Change from base Build 1917260812: 0.0%
Covered Lines: 3689
Relevant Lines: 4329
💛 - Coveralls

@hco-bot
Copy link
Collaborator

hco-bot commented Mar 3, 2022

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

hco-e2e-upgrade-index-*, hco-e2e-upgrade-index-sno-*, okd-hco-e2e-upgrade-index-* are expected to fail because
the old NMO v0.11.3 with digest d359204722c477654c6fe39d846bd9331c8ec363f5bcc3d4a1845f2aa99ebefc got replaced by a new image with digest c7d4b4217a5dfcad13df9eef808bd9656966f8772210f97bc63fa9f46d42c998 and the old one is lost forever

/override ci/prow/hco-e2e-upgrade-index-aws
/override ci/prow/hco-e2e-upgrade-index-azure
/override ci/prow/hco-e2e-upgrade-index-sno-aws
/override ci/prow/hco-e2e-upgrade-index-sno-azure
/override ci/prow/okd-hco-e2e-upgrade-index-aws
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

@kubevirt-bot
Copy link
Contributor

@tiraboschi: Overrode contexts on behalf of tiraboschi: ci/prow/hco-e2e-upgrade-index-aws, ci/prow/hco-e2e-upgrade-index-azure, ci/prow/hco-e2e-upgrade-index-sno-aws, ci/prow/hco-e2e-upgrade-index-sno-azure, ci/prow/okd-hco-e2e-upgrade-index-aws, ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

hco-e2e-upgrade-index-*, hco-e2e-upgrade-index-sno-*, okd-hco-e2e-upgrade-index-* are expected to fail because
the old NMO v0.11.3 with digest d359204722c477654c6fe39d846bd9331c8ec363f5bcc3d4a1845f2aa99ebefc got replaced by a new image with digest c7d4b4217a5dfcad13df9eef808bd9656966f8772210f97bc63fa9f46d42c998 and the old one is lost forever

/override ci/prow/hco-e2e-upgrade-index-aws
/override ci/prow/hco-e2e-upgrade-index-azure
/override ci/prow/hco-e2e-upgrade-index-sno-aws
/override ci/prow/hco-e2e-upgrade-index-sno-azure
/override ci/prow/okd-hco-e2e-upgrade-index-aws
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Mar 3, 2022 •
edited

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-upgrade-index-aws 036b065 link true /test hco-e2e-upgrade-index-aws
ci/prow/hco-e2e-upgrade-index-azure 036b065 link true /test hco-e2e-upgrade-index-azure
ci/prow/hco-e2e-upgrade-index-sno-azure 036b065 link false /test hco-e2e-upgrade-index-sno-azure
ci/prow/hco-e2e-upgrade-index-sno-aws 036b065 link false /test hco-e2e-upgrade-index-sno-aws
ci/prow/hco-e2e-upgrade-prev-index-azure 036b065 link true /test hco-e2e-upgrade-prev-index-azure
ci/prow/okd-hco-e2e-upgrade-index-gcp 036b065 link true /test okd-hco-e2e-upgrade-index-gcp
ci/prow/okd-hco-e2e-upgrade-index-aws 036b065 link true /test okd-hco-e2e-upgrade-index-aws
ci/prow/okd-hco-e2e-image-index-aws 036b065 link true /test okd-hco-e2e-image-index-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hco-bot
Copy link
Collaborator

hco-bot commented Mar 3, 2022

okd-hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-image-index-aws

In response to this:

okd-hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

orenc1
orenc1 approved these changes Mar 3, 2022
View reviewed changes
Copy link
Collaborator

@orenc1 orenc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: orenc1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2022
@kubevirt-bot kubevirt-bot merged commit aedc268 into kubevirt:main Mar 3, 2022
@orenc1 orenc1 mentioned this pull request Mar 3, 2022
Closed
@tiraboschi tiraboschi deleted the rollback_cnao branch April 1, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orenc1 orenc1 orenc1 approved these changes

@nunnatsa nunnatsa Awaiting requested review from nunnatsa

@sradco sradco Awaiting requested review from sradco

Assignees

@orenc1 orenc1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tiraboschi @coveralls @hco-bot @kubevirt-bot @orenc1