Kubevirt Console Plugin Integration with HCO #1809

orenc1 · 2022-03-03T21:08:03Z

Add Operand Handlers to create and reconcile new resources for the Kubvirt console plugin in OpenShift:

Deployment for the kubevirt plugin, serving the UI contents using nginx
Service that exposes the kubevirt plugin pod
Custom Resource for the plugin - ConsolePlugin (console.openshift.io/v1alpha1)

Note:
kubevirt console plugin resources will be deployed only if KV_CONSOLE_PLUGIN_IMAGE environment variable is provided to hco-operator, with the value of the plugin image pullspec. Currently it is not activated, until an official plugin release will be available at https://github.com/kubevirt-ui/kubevirt-plugin/releases.

Signed-off-by: orenc1 ocohen@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Release note:

kubevirt console plugin integration with HCO

kubevirt-bot · 2022-03-03T21:08:04Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2022-03-03T21:08:04Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

coveralls · 2022-03-04T22:29:11Z

Pull Request Test Coverage Report for Build 2077342887

323 of 384 (84.11%) changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.05%) to 84.738%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
controllers/hyperconverged/hyperconverged_controller.go	1	2	50.0%
pkg/util/cluster.go	3	6	50.0%
controllers/operands/deploymentHandler.go	45	55	81.82%
controllers/operands/serviceHandler.go	37	47	78.72%
controllers/operands/kubevirtConsolePlugin.go	224	261	85.82%

Totals
Change from base Build 2072597507:	-0.05%
Covered Lines:	4192
Relevant Lines:	4947

💛 - Coveralls

yaacov · 2022-03-06T06:09:26Z

hack/config

@@ -13,6 +13,7 @@ LIVENESS_PROBE_VERSION="v2.3.0"
 CSI_SNAPSHOT_VERSION="v4.2.1"
 CSI_SIG_STORAGE_PROVISIONER_VERSION="v2.2.1"
 KUBE_RBAC_PROXY_VERSION="4.10"
+KUBEVIRT_PLUGIN_VERSION="latest"


maybe we should add a "UI" or "CONSOLE" to the name, as it is it can get confused with the main kubevirt operators,
for example ''KUBEVIRT_CONSOLE_PLUGIN_VERSION", does that make sense to you ?

controllers/operands/kubevirtConsolePlugin.go

kubevirt-bot · 2022-03-31T20:44:35Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Add Operand Handlers to create and reconcile new resources for the Kubvirt console plugin in OpenShift: 1. Deployment for the kubevirt plugin, serving the UI contents using nginx 2. Service that exposes the kubevirt plugin pod 3. Custom Resource for the plugin - ConsolePlugin Signed-off-by: orenc1 <ocohen@redhat.com>

…nshift.io Signed-off-by: orenc1 <ocohen@redhat.com>

Signed-off-by: orenc1 <ocohen@redhat.com>

…onfigured Signed-off-by: orenc1 <ocohen@redhat.com>

Signed-off-by: orenc1 <ocohen@redhat.com>

…re until a release is available Signed-off-by: orenc1 <ocohen@redhat.com>

sonarcloud · 2022-04-01T12:46:21Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.1% Duplication

hco-bot · 2022-04-01T14:44:07Z

hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-aws
okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp
hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

kubevirt-bot · 2022-04-01T14:44:11Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-upgrade-index-sno-azure, ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-aws
okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp
hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2022-04-01T15:57:41Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2022-04-01T15:57:43Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

orenc1 · 2022-04-01T17:16:37Z

/retest

openshift-ci · 2022-04-01T18:32:41Z

@orenc1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-kv-smoke-gcp	`10de754`	link	true	`/test hco-e2e-kv-smoke-gcp`
ci/prow/hco-e2e-upgrade-index-sno-azure	`10de754`	link	false	`/test hco-e2e-upgrade-index-sno-azure`
ci/prow/hco-e2e-image-index-aws	`10de754`	link	true	`/test hco-e2e-image-index-aws`
ci/prow/okd-hco-e2e-upgrade-index-gcp	`10de754`	link	true	`/test okd-hco-e2e-upgrade-index-gcp`
ci/prow/hco-e2e-image-index-sno-aws	`10de754`	link	false	`/test hco-e2e-image-index-sno-aws`
ci/prow/hco-e2e-upgrade-prev-index-sno-aws	`10de754`	link	false	`/test hco-e2e-upgrade-prev-index-sno-aws`
ci/prow/hco-e2e-upgrade-prev-index-aws	`10de754`	link	true	`/test hco-e2e-upgrade-prev-index-aws`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hco-bot · 2022-04-01T18:39:29Z

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

kubevirt-bot · 2022-04-01T18:39:33Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-aws

In response to this:

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2022-04-01T18:52:40Z

hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

kubevirt-bot · 2022-04-01T18:52:44Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-sno-aws

In response to this:

hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2022-04-01T19:10:37Z

hco-e2e-upgrade-prev-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-aws

kubevirt-bot · 2022-04-01T19:10:40Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-aws

In response to this:

hco-e2e-upgrade-prev-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2022-04-03T08:32:10Z

/override coverage/coveralls

kubevirt-bot · 2022-04-03T08:32:13Z

@nunnatsa: Overrode contexts on behalf of nunnatsa: coverage/coveralls

In response to this:

/override coverage/coveralls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2022-04-03T08:32:17Z

/lgtm

kubevirt-bot requested review from sradco and tiraboschi March 3, 2022 21:08

orenc1 changed the title ~~WIP: Kubevirt Plugin Integration with HCO~~ WIP: Kubevirt Console Plugin Integration with HCO Mar 3, 2022

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2022

orenc1 force-pushed the ui_plugin_integration branch from a4e9331 to 7229d8d Compare March 4, 2022 19:16

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2022

orenc1 force-pushed the ui_plugin_integration branch from 7229d8d to 0c932c5 Compare March 4, 2022 22:21

kubevirt-bot added size/XXL and removed size/XL labels Mar 4, 2022

yaacov reviewed Mar 6, 2022

View reviewed changes

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2022

orenc1 force-pushed the ui_plugin_integration branch from 0c932c5 to e17c785 Compare March 22, 2022 13:07

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 22, 2022

orenc1 marked this pull request as ready for review March 22, 2022 13:07

kubevirt-bot requested a review from machadovilaca March 22, 2022 13:08

orenc1 force-pushed the ui_plugin_integration branch from e17c785 to 04ff804 Compare March 22, 2022 13:31

orenc1 changed the title ~~WIP: Kubevirt Console Plugin Integration with HCO~~ Kubevirt Console Plugin Integration with HCO Mar 22, 2022

kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 22, 2022

orenc1 force-pushed the ui_plugin_integration branch from 04ff804 to 8d72805 Compare March 22, 2022 16:41

orenc1 closed this Mar 22, 2022

orenc1 reopened this Mar 22, 2022

orenc1 force-pushed the ui_plugin_integration branch from 8d72805 to bb1a260 Compare March 22, 2022 17:10

orenc1 commented Mar 22, 2022

View reviewed changes

controllers/operands/kubevirtConsolePlugin.go Outdated Show resolved Hide resolved

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2022

orenc1 added 7 commits April 1, 2022 15:40

Adding unit tests and enable kubevirt-plugin in consoles.operator.ope…

40ace0c

…nshift.io Signed-off-by: orenc1 <ocohen@redhat.com>

add new hook method from kubevirt#1832 to the new handlers

91d91d6

Signed-off-by: orenc1 <ocohen@redhat.com>

fixes according to review comments

a1c5416

Signed-off-by: orenc1 <ocohen@redhat.com>

not creating console plugin operands if console plugin image is not c…

1010323

…onfigured Signed-off-by: orenc1 <ocohen@redhat.com>

configure the plugin deployment and service with SSL

c5060d7

Signed-off-by: orenc1 <ocohen@redhat.com>

pin kubevirt-plugin image to a specific version and disable the featu…

10de754

…re until a release is available Signed-off-by: orenc1 <ocohen@redhat.com>

orenc1 force-pushed the ui_plugin_integration branch from a0f2a07 to 10de754 Compare April 1, 2022 12:44

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2022

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2022

kubevirt-bot merged commit de08767 into kubevirt:main Apr 3, 2022

orenc1 deleted the ui_plugin_integration branch April 3, 2022 09:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kubevirt Console Plugin Integration with HCO #1809

Kubevirt Console Plugin Integration with HCO #1809

orenc1 commented Mar 3, 2022 •

edited

Loading

kubevirt-bot commented Mar 3, 2022

openshift-ci bot commented Mar 3, 2022

coveralls commented Mar 4, 2022 •

edited

Loading

yaacov Mar 6, 2022

kubevirt-bot commented Mar 31, 2022

sonarcloud bot commented Apr 1, 2022

hco-bot commented Apr 1, 2022

kubevirt-bot commented Apr 1, 2022

hco-bot commented Apr 1, 2022

kubevirt-bot commented Apr 1, 2022

orenc1 commented Apr 1, 2022

openshift-ci bot commented Apr 1, 2022 •

edited

Loading

hco-bot commented Apr 1, 2022

kubevirt-bot commented Apr 1, 2022

hco-bot commented Apr 1, 2022

kubevirt-bot commented Apr 1, 2022

hco-bot commented Apr 1, 2022

kubevirt-bot commented Apr 1, 2022

nunnatsa commented Apr 3, 2022

kubevirt-bot commented Apr 3, 2022

nunnatsa commented Apr 3, 2022

Kubevirt Console Plugin Integration with HCO #1809

Kubevirt Console Plugin Integration with HCO #1809

Conversation

orenc1 commented Mar 3, 2022 • edited Loading

kubevirt-bot commented Mar 3, 2022

openshift-ci bot commented Mar 3, 2022

coveralls commented Mar 4, 2022 • edited Loading

Pull Request Test Coverage Report for Build 2077342887

💛 - Coveralls

yaacov Mar 6, 2022

Choose a reason for hiding this comment

kubevirt-bot commented Mar 31, 2022

sonarcloud bot commented Apr 1, 2022

hco-bot commented Apr 1, 2022

kubevirt-bot commented Apr 1, 2022

hco-bot commented Apr 1, 2022

kubevirt-bot commented Apr 1, 2022

orenc1 commented Apr 1, 2022

openshift-ci bot commented Apr 1, 2022 • edited Loading

hco-bot commented Apr 1, 2022

kubevirt-bot commented Apr 1, 2022

hco-bot commented Apr 1, 2022

kubevirt-bot commented Apr 1, 2022

hco-bot commented Apr 1, 2022

kubevirt-bot commented Apr 1, 2022

nunnatsa commented Apr 3, 2022

kubevirt-bot commented Apr 3, 2022

nunnatsa commented Apr 3, 2022

orenc1 commented Mar 3, 2022 •

edited

Loading

coveralls commented Mar 4, 2022 •

edited

Loading

openshift-ci bot commented Apr 1, 2022 •

edited

Loading