Introduce Crypto Policy #1827

tiraboschi · 2022-03-22T17:27:45Z

Introduce cluster-wide Crypto Policy

Implement cluster-wide Crypto Policy API
as described in
https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/docs/enhancements/crypto-api.md

Propagate it to CNAO which is its first
consumer. Other Kubevirt Hyperconverged components
are going to follow in future PRs.

Signed-off-by: Simone Tiraboschi stirabos@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Release note:

Introduce cluster-wide Crypto Policy

coveralls · 2022-03-22T23:50:16Z

Pull Request Test Coverage Report for Build 2089975217

69 of 111 (62.16%) changed or added relevant lines in 3 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.5%) to 84.363%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/util/cluster.go	27	33	81.82%
controllers/hyperconverged/hyperconverged_controller.go	40	76	52.63%

Files with Coverage Reduction	New Missed Lines	%
controllers/hyperconverged/hyperconverged_controller.go	1	81.78%
controllers/operands/operandHandler.go	1	88.44%

Totals
Change from base Build 2089505448:	-0.5%
Covered Lines:	4246
Relevant Lines:	5033

💛 - Coveralls

hco-bot · 2022-03-23T02:35:55Z

hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-aws
hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-azure
hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws
okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws
okd-hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-aws

kubevirt-bot · 2022-03-23T02:36:01Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-image-index-azure, ci/prow/hco-e2e-image-index-sno-aws, ci/prow/okd-hco-e2e-image-index-aws, ci/prow/okd-hco-e2e-upgrade-index-aws

In response to this:

hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-aws
hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-azure
hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws
okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws
okd-hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2022-03-23T09:44:21Z

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws

kubevirt-bot · 2022-03-23T09:44:23Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-aws

In response to this:

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2022-03-23T12:22:08Z

okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws

kubevirt-bot · 2022-03-23T12:22:11Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-index-aws

In response to this:

okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2022-03-31T12:56:56Z

/retest

nunnatsa · 2022-04-04T08:11:04Z

controllers/hyperconverged/hyperconverged_controller.go

+
+		apiServerCRTriggered, err := isTriggeredByApiServerCR(request)
+		if err != nil {
+			return reconcile.Result{}, err
+		}
+		if apiServerCRTriggered {
+			logger.Info("Triggered by ApiServer CR, refreshing it")
+			err = hcoutil.GetClusterInfo().RefreshAPIServerCR(hcoRequest.Ctx, r.client)
+			if err != nil {
+				return reconcile.Result{}, err
+			}
+		}
+


SonarCloud warns about a code smell here (too complex function). Please consider to refactor.

hco-bot · 2022-04-04T09:17:17Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
okd-hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-aws

kubevirt-bot · 2022-04-04T09:17:28Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure, ci/prow/hco-e2e-image-index-gcp, ci/prow/okd-hco-e2e-image-index-aws

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
okd-hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Implement cluster-wide Crypto Policy API as described in https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/docs/enhancements/crypto-api.md Propagate it to CNAO which is its first consumer. Other Kubevirt Hyperconverged components are going to follow in future PRs. Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

sonarcloud · 2022-04-04T12:56:31Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

tiraboschi · 2022-04-04T15:08:42Z

/retest

tiraboschi · 2022-04-04T16:05:31Z

/retest

hco-bot · 2022-04-04T17:40:33Z

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws
hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure

kubevirt-bot · 2022-04-04T17:40:49Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-azure, ci/prow/hco-e2e-upgrade-index-sno-aws

In response to this:

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws
hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2022-04-04T17:54:06Z

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws
hco-e2e-image-index-azure, hco-e2e-image-index-gcp lanes succeeded.
/override ci/prow/hco-e2e-image-index-aws

kubevirt-bot · 2022-04-04T17:54:12Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-upgrade-index-aws

In response to this:

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws
hco-e2e-image-index-azure, hco-e2e-image-index-gcp lanes succeeded.
/override ci/prow/hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2022-04-05T06:18:57Z

/retest

openshift-ci · 2022-04-05T07:46:33Z

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-upgrade-index-aws	`57f5207`	link	true	`/test hco-e2e-upgrade-index-aws`
ci/prow/hco-e2e-image-index-sno-azure	`57f5207`	link	false	`/test hco-e2e-image-index-sno-azure`
ci/prow/hco-e2e-upgrade-index-sno-aws	`57f5207`	link	false	`/test hco-e2e-upgrade-index-sno-aws`
ci/prow/hco-e2e-image-index-aws	`57f5207`	link	true	`/test hco-e2e-image-index-aws`
ci/prow/hco-e2e-upgrade-prev-index-azure	`57f5207`	link	true	`/test hco-e2e-upgrade-prev-index-azure`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hco-bot · 2022-04-05T07:48:43Z

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

kubevirt-bot · 2022-04-05T07:48:47Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2022-04-05T08:51:05Z

ignoring slightly decreased coverage
/override coverage/coveralls

kubevirt-bot · 2022-04-05T08:51:07Z

@tiraboschi: Overrode contexts on behalf of tiraboschi: coverage/coveralls

In response to this:

ignoring slightly decreased coverage
/override coverage/coveralls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2022-04-05T09:04:21Z

/approve
/lgtm

kubevirt-bot · 2022-04-05T09:04:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [nunnatsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tiraboschi added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 22, 2022

kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 22, 2022

kubevirt-bot requested review from machadovilaca and nunnatsa March 22, 2022 17:46

kubevirt-bot added the size/XL label Mar 22, 2022

tiraboschi force-pushed the crypto_api branch 2 times, most recently from cffa886 to acd3f24 Compare March 22, 2022 18:43

kubevirt-bot added size/XXL and removed size/XL labels Mar 22, 2022

tiraboschi force-pushed the crypto_api branch 4 times, most recently from 3bac16c to 7c1b7fb Compare March 22, 2022 23:44

tiraboschi force-pushed the crypto_api branch from 7c1b7fb to b85bd37 Compare March 22, 2022 23:52

tiraboschi force-pushed the crypto_api branch 2 times, most recently from 5a20034 to 91d25d5 Compare March 23, 2022 08:17

tiraboschi force-pushed the crypto_api branch 2 times, most recently from f5a3484 to 75df0df Compare March 23, 2022 15:26

tiraboschi changed the title ~~WIP: Introduce Crypto Policy~~ Introduce Crypto Policy Mar 23, 2022

tiraboschi removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 23, 2022

kubevirt-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 23, 2022

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2022

tiraboschi force-pushed the crypto_api branch from 1b5abf2 to ac8d4a9 Compare April 4, 2022 06:35

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 4, 2022

tiraboschi force-pushed the crypto_api branch from ac8d4a9 to 23a8e13 Compare April 4, 2022 06:55

nunnatsa reviewed Apr 4, 2022

View reviewed changes

tiraboschi force-pushed the crypto_api branch from 23a8e13 to 00f4ca3 Compare April 4, 2022 12:46

tiraboschi force-pushed the crypto_api branch from 00f4ca3 to 57f5207 Compare April 4, 2022 12:55

kubevirt-bot assigned nunnatsa Apr 5, 2022

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2022

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2022

kubevirt-bot merged commit 5906b44 into kubevirt:main Apr 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce Crypto Policy #1827

Introduce Crypto Policy #1827

tiraboschi commented Mar 22, 2022 •

edited

Loading

coveralls commented Mar 22, 2022 •

edited

Loading

hco-bot commented Mar 23, 2022

kubevirt-bot commented Mar 23, 2022

hco-bot commented Mar 23, 2022

kubevirt-bot commented Mar 23, 2022

hco-bot commented Mar 23, 2022

kubevirt-bot commented Mar 23, 2022

tiraboschi commented Mar 31, 2022

nunnatsa Apr 4, 2022

tiraboschi Apr 4, 2022

hco-bot commented Apr 4, 2022

kubevirt-bot commented Apr 4, 2022

sonarcloud bot commented Apr 4, 2022

tiraboschi commented Apr 4, 2022

tiraboschi commented Apr 4, 2022

hco-bot commented Apr 4, 2022

kubevirt-bot commented Apr 4, 2022

hco-bot commented Apr 4, 2022

kubevirt-bot commented Apr 4, 2022

tiraboschi commented Apr 5, 2022

openshift-ci bot commented Apr 5, 2022

hco-bot commented Apr 5, 2022

kubevirt-bot commented Apr 5, 2022

tiraboschi commented Apr 5, 2022

kubevirt-bot commented Apr 5, 2022

nunnatsa commented Apr 5, 2022

kubevirt-bot commented Apr 5, 2022

Introduce Crypto Policy #1827

Introduce Crypto Policy #1827

Conversation

tiraboschi commented Mar 22, 2022 • edited Loading

coveralls commented Mar 22, 2022 • edited Loading

Pull Request Test Coverage Report for Build 2089975217

💛 - Coveralls

hco-bot commented Mar 23, 2022

kubevirt-bot commented Mar 23, 2022

hco-bot commented Mar 23, 2022

kubevirt-bot commented Mar 23, 2022

hco-bot commented Mar 23, 2022

kubevirt-bot commented Mar 23, 2022

tiraboschi commented Mar 31, 2022

nunnatsa Apr 4, 2022

Choose a reason for hiding this comment

tiraboschi Apr 4, 2022

Choose a reason for hiding this comment

hco-bot commented Apr 4, 2022

kubevirt-bot commented Apr 4, 2022

sonarcloud bot commented Apr 4, 2022

tiraboschi commented Apr 4, 2022

tiraboschi commented Apr 4, 2022

hco-bot commented Apr 4, 2022

kubevirt-bot commented Apr 4, 2022

hco-bot commented Apr 4, 2022

kubevirt-bot commented Apr 4, 2022

tiraboschi commented Apr 5, 2022

openshift-ci bot commented Apr 5, 2022

hco-bot commented Apr 5, 2022

kubevirt-bot commented Apr 5, 2022

tiraboschi commented Apr 5, 2022

kubevirt-bot commented Apr 5, 2022

nunnatsa commented Apr 5, 2022

kubevirt-bot commented Apr 5, 2022

tiraboschi commented Mar 22, 2022 •

edited

Loading

coveralls commented Mar 22, 2022 •

edited

Loading