Remove nmstate from deployed components in networkaddonsconfig

[rhrazdil]

Signed-off-by: Radim Hrazdil rhrazdil@redhat.com
This PR removed NMState from the list of components to be deployed by CNAO.
CNAO doesn't support knmstate deployment anymore, users should use Kubernetes-nmstate operator instead.

PR on CNAO that proposes raising Degraded condition when nmstate is present in networkAddonsConfig:

• Set degraded if nmstate is requested in networkAddonsConfig cluster-network-addons-operator#1292

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

• PR Message
• Commit Messages
• How to test
• Unit Tests
• Functional Tests
• User Documentation
• Developer Documentation
• Upgrade Scenario
• Uninstallation Scenario
• Backward Compatibility
• Troubleshooting Friendly

Release note:

Nmstate is removed from networkAddonsConfig as CNAO doesn't support it's deployment

[rhrazdil]

/cc @qinqon

[qinqon]

/lgtm

@tiraboschi we need so we don't trigger the alert of of non NMState CNAO on upgrade.

[coveralls]

Pull Request Test Coverage Report for Build 2077412702

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.003%) to 84.782%

---

Totals
Change from base Build 2072597507:	-0.003%
Covered Lines:	3872
Relevant Lines:	4567

---

💛 - Coveralls

[hco-bot]

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws

[kubevirt-bot]

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-aws

In response to this:

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiraboschi]

Can you please add at least one unit test?

[rhrazdil]

@tiraboschi added a test that we're not specifying nmstate

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[tiraboschi]

/approve

[tiraboschi]

tolerating slightly decreased coverage
/override coverage/coveralls

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tiraboschi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubevirt-bot]

@tiraboschi: Overrode contexts on behalf of tiraboschi: coverage/coveralls

In response to this:

tolerating slightly decreased coverage
/override coverage/coveralls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hco-bot]

hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws
hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws

[kubevirt-bot]

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-aws, ci/prow/hco-e2e-upgrade-prev-index-sno-aws

In response to this:

hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws
hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@rhrazdil: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-upgrade-prev-index-sno-aws	e698818	link	false	/test hco-e2e-upgrade-prev-index-sno-aws
ci/prow/hco-e2e-upgrade-index-sno-aws	e698818	link	false	/test hco-e2e-upgrade-index-sno-aws
ci/prow/hco-e2e-image-index-aws	e698818	link	true	/test hco-e2e-image-index-aws
ci/prow/hco-e2e-image-index-azure	e698818	link	true	/test hco-e2e-image-index-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[hco-bot]

hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-azure
hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

[kubevirt-bot]

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-image-index-azure

In response to this:

hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-azure
hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiraboschi]

/retest