Allow controlling filesystem overhead #1851

maya-r · 2022-04-03T11:13:14Z

We can't test every storage provider, let's give people an escape
hatch if it turns out they need more padding for their Filesystem
PVCs.

Release note:

Allow tuning CDI's filesystem overhead through HCO CR

coveralls · 2022-04-03T11:49:24Z

Pull Request Test Coverage Report for Build 2095902402

3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.009%) to 84.373%

Totals
Change from base Build 2095565176:	0.009%
Covered Lines:	4249
Relevant Lines:	5036

💛 - Coveralls

hco-bot · 2022-04-03T13:18:26Z

hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-aws
hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure
okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp
hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws

kubevirt-bot · 2022-04-03T13:18:31Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-index-aws, ci/prow/hco-e2e-upgrade-prev-index-azure, ci/prow/okd-hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-aws
hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure
okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp
hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2022-04-03T13:53:51Z

Thanks for your PR, @maya-r. Please also add a user guide + example to docs/cluster-configuration.md

hco-bot · 2022-04-03T14:37:54Z

hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

kubevirt-bot · 2022-04-03T14:37:57Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-sno-aws

In response to this:

hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2022-04-04T13:00:12Z

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp
hco-e2e-image-index-gcp, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-azure

kubevirt-bot · 2022-04-04T13:00:23Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure, ci/prow/okd-hco-e2e-image-index-gcp

In response to this:

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp
hco-e2e-image-index-gcp, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2022-04-04T13:00:53Z

Thanks @maya-r
/lgtm
/retest

hco-bot · 2022-04-04T17:23:50Z

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

kubevirt-bot · 2022-04-04T17:23:54Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

maya-r · 2022-04-05T11:19:32Z

Resolved merge conflict

We can't test every storage provider, let's give people an escape hatch if it turns out they need more padding for their Filesystem PVCs. Signed-off-by: Maya Rashish <mrashish@redhat.com>

Signed-off-by: Maya Rashish <mrashish@redhat.com>

maya-r · 2022-04-05T11:44:21Z

Looks like there's a tiny difference in the generated code depending on your Go version.

sonarcloud · 2022-04-05T11:44:45Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

hco-bot · 2022-04-05T12:58:57Z

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws

kubevirt-bot · 2022-04-05T12:59:00Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-aws

In response to this:

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2022-04-05T13:29:25Z

hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-aws
hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

kubevirt-bot · 2022-04-05T13:29:28Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-image-index-azure

In response to this:

hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-aws
hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2022-04-05T15:06:41Z

/retest

openshift-ci · 2022-04-05T16:58:11Z

@maya-r: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-upgrade-index-sno-aws	`72c8c53`	link	false	`/test hco-e2e-upgrade-index-sno-aws`
ci/prow/hco-e2e-image-index-azure	`72c8c53`	link	true	`/test hco-e2e-image-index-azure`
ci/prow/hco-e2e-image-index-aws	`72c8c53`	link	true	`/test hco-e2e-image-index-aws`
ci/prow/hco-e2e-upgrade-prev-index-azure	`72c8c53`	link	true	`/test hco-e2e-upgrade-prev-index-azure`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hco-bot · 2022-04-05T17:16:28Z

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

kubevirt-bot · 2022-04-05T17:16:32Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2022-04-06T05:49:08Z

/approve

kubevirt-bot · 2022-04-06T05:49:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tiraboschi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 3, 2022

kubevirt-bot requested review from orenc1 and sradco April 3, 2022 11:13

kubevirt-bot added the size/L label Apr 3, 2022

maya-r force-pushed the fs-overhead branch from 44c0e74 to 645958e Compare April 3, 2022 11:42

kubevirt-bot assigned nunnatsa Apr 4, 2022

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2022

maya-r force-pushed the fs-overhead branch from 0aecbcb to 468769c Compare April 5, 2022 11:19

kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2022

maya-r added 2 commits April 5, 2022 14:43

Allow controlling CDI's filesystem overhead

2f11645

We can't test every storage provider, let's give people an escape hatch if it turns out they need more padding for their Filesystem PVCs. Signed-off-by: Maya Rashish <mrashish@redhat.com>

Add documentation for file system overhead tunable

72c8c53

Signed-off-by: Maya Rashish <mrashish@redhat.com>

maya-r force-pushed the fs-overhead branch from 468769c to 72c8c53 Compare April 5, 2022 11:43

tiraboschi approved these changes Apr 6, 2022

View reviewed changes

kubevirt-bot assigned tiraboschi Apr 6, 2022

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2022

tiraboschi approved these changes Apr 6, 2022

View reviewed changes

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2022

kubevirt-bot merged commit 80240b6 into kubevirt:main Apr 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow controlling filesystem overhead #1851

Allow controlling filesystem overhead #1851

maya-r commented Apr 3, 2022 •

edited

Loading

coveralls commented Apr 3, 2022 •

edited

Loading

hco-bot commented Apr 3, 2022

kubevirt-bot commented Apr 3, 2022

nunnatsa commented Apr 3, 2022

hco-bot commented Apr 3, 2022

kubevirt-bot commented Apr 3, 2022

hco-bot commented Apr 4, 2022

kubevirt-bot commented Apr 4, 2022

nunnatsa commented Apr 4, 2022

hco-bot commented Apr 4, 2022

kubevirt-bot commented Apr 4, 2022

maya-r commented Apr 5, 2022

maya-r commented Apr 5, 2022

sonarcloud bot commented Apr 5, 2022

hco-bot commented Apr 5, 2022

kubevirt-bot commented Apr 5, 2022

hco-bot commented Apr 5, 2022

kubevirt-bot commented Apr 5, 2022

nunnatsa commented Apr 5, 2022

openshift-ci bot commented Apr 5, 2022

hco-bot commented Apr 5, 2022

kubevirt-bot commented Apr 5, 2022

tiraboschi commented Apr 6, 2022

kubevirt-bot commented Apr 6, 2022

Allow controlling filesystem overhead #1851

Allow controlling filesystem overhead #1851

Conversation

maya-r commented Apr 3, 2022 • edited Loading

coveralls commented Apr 3, 2022 • edited Loading

Pull Request Test Coverage Report for Build 2095902402

💛 - Coveralls

hco-bot commented Apr 3, 2022

kubevirt-bot commented Apr 3, 2022

nunnatsa commented Apr 3, 2022

hco-bot commented Apr 3, 2022

kubevirt-bot commented Apr 3, 2022

hco-bot commented Apr 4, 2022

kubevirt-bot commented Apr 4, 2022

nunnatsa commented Apr 4, 2022

hco-bot commented Apr 4, 2022

kubevirt-bot commented Apr 4, 2022

maya-r commented Apr 5, 2022

maya-r commented Apr 5, 2022

sonarcloud bot commented Apr 5, 2022

hco-bot commented Apr 5, 2022

kubevirt-bot commented Apr 5, 2022

hco-bot commented Apr 5, 2022

kubevirt-bot commented Apr 5, 2022

nunnatsa commented Apr 5, 2022

openshift-ci bot commented Apr 5, 2022

hco-bot commented Apr 5, 2022

kubevirt-bot commented Apr 5, 2022

tiraboschi commented Apr 6, 2022

kubevirt-bot commented Apr 6, 2022

maya-r commented Apr 3, 2022 •

edited

Loading

coveralls commented Apr 3, 2022 •

edited

Loading