Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting all the fields of a common DICT spec #1859

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Allow setting all the fields of a common DICT spec #1859

merged 1 commit into from
Apr 5, 2022

Conversation

nunnatsa
Copy link
Collaborator

@nunnatsa nunnatsa commented Apr 4, 2022

This PR allows modifying all the field a common DataImportCronTemplate
spec. Before this PR, HCO only modified the storage field. and ignored
the rest.

Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Release note:

Allow setting all the fields of a common DICT spec

@nunnatsa
Allow setting all the fields of a common DICT spec
d10ffa7 
This PR allows modifying all the field a common DataImportCronTemplate
spec. Before this PR, HCO only modified the storage field. and ignored
the rest.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Apr 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2089975300

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 84.833%
Files with Coverage Reduction New Missed Lines %
controllers/operands/operandHandler.go 1 88.44%
Totals Coverage Status
Change from base Build 2089505448: -0.02%
Covered Lines: 4195
Relevant Lines: 4945
💛 - Coveralls

@nunnatsa nunnatsa requested review from orenc1 and tiraboschi and removed request for sradco April 4, 2022 13:03
@hco-bot
Copy link
Collaborator

hco-bot commented Apr 4, 2022

hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-azure

In response to this:

hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Apr 4, 2022

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-aws

In response to this:

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Apr 4, 2022

hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator Author

nunnatsa commented Apr 5, 2022

/retest

@hco-bot
Copy link
Collaborator

hco-bot commented Apr 5, 2022

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Apr 5, 2022

@nunnatsa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-image-index-gcp d10ffa7 link true /test hco-e2e-image-index-gcp
ci/prow/hco-e2e-upgrade-index-sno-azure d10ffa7 link false /test hco-e2e-upgrade-index-sno-azure
ci/prow/hco-e2e-image-index-sno-aws d10ffa7 link false /test hco-e2e-image-index-sno-aws
ci/prow/hco-e2e-upgrade-prev-index-azure d10ffa7 link true /test hco-e2e-upgrade-prev-index-azure
ci/prow/hco-e2e-upgrade-prev-index-sno-aws d10ffa7 link false /test hco-e2e-upgrade-prev-index-sno-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hco-bot
Copy link
Collaborator

hco-bot commented Apr 5, 2022

hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-sno-aws

In response to this:

hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator Author

nunnatsa commented Apr 5, 2022

/override coverage/coveralls

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: coverage/coveralls

In response to this:

/override coverage/coveralls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2022
@nunnatsa
Copy link
Collaborator Author

nunnatsa commented Apr 5, 2022

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.21

@openshift-ci
Copy link

openshift-ci bot commented Apr 5, 2022

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test ci-index
  • /test ci-index-hco-upgrade-bundle
  • /test ci-index-hco-upgrade-prev-bundle
  • /test hco-e2e-image-index-aws
  • /test hco-e2e-image-index-azure
  • /test hco-e2e-image-index-gcp
  • /test hco-e2e-kv-smoke-azure
  • /test hco-e2e-kv-smoke-gcp
  • /test hco-e2e-upgrade-index-aws
  • /test hco-e2e-upgrade-index-azure
  • /test hco-e2e-upgrade-prev-index-aws
  • /test hco-e2e-upgrade-prev-index-azure
  • /test images
  • /test okd-ci-index
  • /test okd-ci-index-hco-upgrade-bundle
  • /test okd-ci-index-hco-upgrade-prev-bundle
  • /test okd-hco-e2e-image-index-aws
  • /test okd-hco-e2e-image-index-gcp
  • /test okd-hco-e2e-upgrade-index-aws
  • /test okd-hco-e2e-upgrade-index-gcp
  • /test okd-images

The following commands are available to trigger optional jobs:

  • /test hco-e2e-image-index-sno-aws
  • /test hco-e2e-image-index-sno-azure
  • /test hco-e2e-upgrade-index-sno-aws
  • /test hco-e2e-upgrade-index-sno-azure
  • /test hco-e2e-upgrade-prev-index-sno-aws
  • /test hco-e2e-upgrade-prev-index-sno-azure

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-image-index-aws
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-image-index-azure
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-image-index-gcp
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-image-index-sno-aws
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-image-index-sno-azure
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-kv-smoke-azure
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-kv-smoke-gcp
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-index-aws
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-index-azure
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-index-sno-aws
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-index-sno-azure
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-prev-index-aws
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-prev-index-azure
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-prev-index-sno-aws
  • pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-upgrade-prev-index-sno-azure

In response to this:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit c9e1355 into kubevirt:main Apr 5, 2022
@nunnatsa nunnatsa deleted the full-dic-modification branch April 5, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi tiraboschi approved these changes

@machadovilaca machadovilaca Awaiting requested review from machadovilaca

@orenc1 orenc1 Awaiting requested review from orenc1

Assignees

@tiraboschi tiraboschi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nunnatsa @coveralls @hco-bot @kubevirt-bot @tiraboschi