bump kubevirt.io/controller-lifecycle-operator-sdk #1879

tiraboschi · 2022-04-08T07:03:40Z

Bump kubevirt.io/controller-lifecycle-operator-sdk
v0.2.3 => v0.2.4 and fix the code for that:
pkg/sdk/api => api

We should still keep a reference to v0.2.3
to ensure the compatibility with SSP.
It will be remove when SSP will also consume
v0.2.4.

Signed-off-by: Simone Tiraboschi stirabos@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Release note:

bump kubevirt.io/controller-lifecycle-operator-sdk

hco-bot · 2022-04-08T09:16:20Z

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

kubevirt-bot · 2022-04-08T09:16:22Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-aws

In response to this:

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2022-04-08T09:32:20Z

hco-e2e-image-index-gcp, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-azure

kubevirt-bot · 2022-04-08T09:32:23Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure

In response to this:

hco-e2e-image-index-gcp, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2022-04-08T10:47:23Z

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

kubevirt-bot · 2022-04-08T10:47:26Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2022-04-08T11:12:19Z

okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws

kubevirt-bot · 2022-04-08T11:12:25Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-index-aws

In response to this:

okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2022-04-08T17:51:02Z

/retest

Bump kubevirt.io/controller-lifecycle-operator-sdk v0.2.3 => v0.2.4 and fix the code for that: pkg/sdk/api => api We should still keep a reference to v0.2.3 to ensure the compatibility with CDI and SSP. It will be remove when CDI and SSP will also consume v0.2.4. Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

sonarcloud · 2022-04-09T18:28:59Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
0.0% Duplication

coveralls · 2022-04-09T18:33:06Z

Pull Request Test Coverage Report for Build 2141511427

4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.398%

Totals
Change from base Build 2139963440:	0.0%
Covered Lines:	4176
Relevant Lines:	4948

💛 - Coveralls

hco-bot · 2022-04-09T19:54:27Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2022-04-09T19:54:30Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2022-04-09T20:13:21Z

hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
okd-hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-aws

kubevirt-bot · 2022-04-09T20:13:24Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-azure, ci/prow/okd-hco-e2e-image-index-aws

In response to this:

hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
okd-hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-04-09T21:53:38Z

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-image-index-gcp	`763083a`	link	true	`/test hco-e2e-image-index-gcp`
ci/prow/okd-hco-e2e-image-index-aws	`763083a`	link	true	`/test okd-hco-e2e-image-index-aws`
ci/prow/hco-e2e-upgrade-index-azure	`763083a`	link	true	`/test hco-e2e-upgrade-index-azure`
ci/prow/hco-e2e-upgrade-prev-index-azure	`763083a`	link	true	`/test hco-e2e-upgrade-prev-index-azure`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hco-bot · 2022-04-09T21:56:35Z

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

kubevirt-bot · 2022-04-09T21:56:37Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa

/approve

kubevirt-bot · 2022-04-10T04:30:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [nunnatsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Apr 8, 2022

kubevirt-bot requested review from machadovilaca and orenc1 April 8, 2022 07:03

tiraboschi force-pushed the controller_lifecycle_operator_sdk_v0.2.4 branch 2 times, most recently from 9f6b027 to d0d13c6 Compare April 8, 2022 07:47

tiraboschi mentioned this pull request Apr 8, 2022

[main] Bump CDI to v1.47.0 #1878

Closed

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2022

tiraboschi force-pushed the controller_lifecycle_operator_sdk_v0.2.4 branch from d0d13c6 to 763083a Compare April 9, 2022 18:28

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2022

nunnatsa approved these changes Apr 10, 2022

View reviewed changes

kubevirt-bot assigned nunnatsa Apr 10, 2022

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2022

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2022

kubevirt-bot merged commit 47acac2 into kubevirt:main Apr 10, 2022

tiraboschi deleted the controller_lifecycle_operator_sdk_v0.2.4 branch April 10, 2022 07:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump kubevirt.io/controller-lifecycle-operator-sdk #1879

bump kubevirt.io/controller-lifecycle-operator-sdk #1879

tiraboschi commented Apr 8, 2022

hco-bot commented Apr 8, 2022

kubevirt-bot commented Apr 8, 2022

hco-bot commented Apr 8, 2022

kubevirt-bot commented Apr 8, 2022

hco-bot commented Apr 8, 2022

kubevirt-bot commented Apr 8, 2022

hco-bot commented Apr 8, 2022

kubevirt-bot commented Apr 8, 2022

tiraboschi commented Apr 8, 2022

sonarcloud bot commented Apr 9, 2022

coveralls commented Apr 9, 2022

hco-bot commented Apr 9, 2022

kubevirt-bot commented Apr 9, 2022

hco-bot commented Apr 9, 2022

kubevirt-bot commented Apr 9, 2022

openshift-ci bot commented Apr 9, 2022

hco-bot commented Apr 9, 2022

kubevirt-bot commented Apr 9, 2022

nunnatsa left a comment

kubevirt-bot commented Apr 10, 2022

bump kubevirt.io/controller-lifecycle-operator-sdk #1879

bump kubevirt.io/controller-lifecycle-operator-sdk #1879

Conversation

tiraboschi commented Apr 8, 2022

hco-bot commented Apr 8, 2022

kubevirt-bot commented Apr 8, 2022

hco-bot commented Apr 8, 2022

kubevirt-bot commented Apr 8, 2022

hco-bot commented Apr 8, 2022

kubevirt-bot commented Apr 8, 2022

hco-bot commented Apr 8, 2022

kubevirt-bot commented Apr 8, 2022

tiraboschi commented Apr 8, 2022

sonarcloud bot commented Apr 9, 2022

coveralls commented Apr 9, 2022

Pull Request Test Coverage Report for Build 2141511427

💛 - Coveralls

hco-bot commented Apr 9, 2022

kubevirt-bot commented Apr 9, 2022

hco-bot commented Apr 9, 2022

kubevirt-bot commented Apr 9, 2022

openshift-ci bot commented Apr 9, 2022

hco-bot commented Apr 9, 2022

kubevirt-bot commented Apr 9, 2022

nunnatsa left a comment

Choose a reason for hiding this comment

kubevirt-bot commented Apr 10, 2022