Avoid special handling for liveMigration FG on SNO #1908

tiraboschi · 2022-04-26T16:32:05Z

Introducing special handling for liveMigration FG
and related (SRIOV livemigration WorkloadUpdateStrategy
LiveMigrated) proved to cause more issues than benefits.
Let's revert it.
HCO will not inject special configuration based on SNO
topology and virt-controller will do the rest.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2073880

Signed-off-by: Simone Tiraboschi stirabos@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Release note:

Avoid special handling for liveMigration FG on SNO

coveralls · 2022-04-26T16:39:07Z

Pull Request Test Coverage Report for Build 2234409203

3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 84.134%

Totals
Change from base Build 2232504922:	-0.02%
Covered Lines:	4115
Relevant Lines:	4891

💛 - Coveralls

Introducing special handling for liveMigration FG and related (SRIOV livemigration WorkloadUpdateStrategy LiveMigrated) proved to cause more issues than benefits. Let's revert it. HCO will not inject special configuration based on SNO topology and virt-controller will do the rest. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2073880 This is a manual cherry-pick of kubevirt#1908 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

tiraboschi · 2022-04-26T16:42:48Z

/override coverage/coveralls
tolerating slightly decreased coverage

kubevirt-bot · 2022-04-26T16:42:49Z

@tiraboschi: Overrode contexts on behalf of tiraboschi: coverage/coveralls

In response to this:

/override coverage/coveralls
tolerating slightly decreased coverage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2022-04-26T17:48:11Z

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws

kubevirt-bot · 2022-04-26T17:48:13Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-aws

In response to this:

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2022-04-26T18:20:09Z

okd-hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-aws
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

kubevirt-bot · 2022-04-26T18:20:18Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-image-index-gcp, ci/prow/okd-hco-e2e-image-index-aws

In response to this:

okd-hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-aws
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

orenc1

/approve

hco-bot · 2022-04-27T14:30:55Z

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws
okd-hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-aws

kubevirt-bot · 2022-04-27T14:30:59Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-aws, ci/prow/okd-hco-e2e-image-index-aws

In response to this:

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws
okd-hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2022-04-27T14:44:24Z

hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

kubevirt-bot · 2022-04-27T14:44:27Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-prev-index-sno-aws

In response to this:

hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2022-04-27T16:22:30Z

/retest

Introducing special handling for liveMigration FG and related (SRIOV livemigration WorkloadUpdateStrategy LiveMigrated) proved to cause more issues than benefits. Let's revert it. HCO will not inject special configuration based on SNO topology and virt-controller will do the rest. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2073880 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

sonarcloud · 2022-04-27T16:30:32Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

hco-bot · 2022-04-27T18:40:57Z

hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure
hco-e2e-image-index-aws, hco-e2e-image-index-gcp lanes succeeded.
/override ci/prow/hco-e2e-image-index-azure
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

kubevirt-bot · 2022-04-27T18:41:02Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure, ci/prow/hco-e2e-image-index-sno-azure, ci/prow/hco-e2e-upgrade-index-azure, ci/prow/hco-e2e-upgrade-prev-index-sno-aws

In response to this:

hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure
hco-e2e-image-index-aws, hco-e2e-image-index-gcp lanes succeeded.
/override ci/prow/hco-e2e-image-index-azure
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2022-04-27T19:29:15Z

/retest

tiraboschi · 2022-04-27T20:52:19Z

/retest

openshift-ci · 2022-04-27T23:54:03Z

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-image-index-azure	`8e1c119`	link	true	`/test hco-e2e-image-index-azure`
ci/prow/hco-e2e-upgrade-prev-index-sno-aws	`8e1c119`	link	false	`/test hco-e2e-upgrade-prev-index-sno-aws`
ci/prow/hco-e2e-upgrade-index-azure	`8e1c119`	link	true	`/test hco-e2e-upgrade-index-azure`
ci/prow/hco-e2e-image-index-sno-azure	`8e1c119`	link	false	`/test hco-e2e-image-index-sno-azure`
ci/prow/hco-e2e-upgrade-prev-index-aws	`8e1c119`	link	true	`/test hco-e2e-upgrade-prev-index-aws`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hco-bot · 2022-04-27T23:58:02Z

hco-e2e-upgrade-prev-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-aws

kubevirt-bot · 2022-04-27T23:58:06Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-aws

In response to this:

hco-e2e-upgrade-prev-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa

/approve

kubevirt-bot · 2022-04-28T07:19:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa, orenc1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [nunnatsa,orenc1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Introducing special handling for liveMigration FG and related (SRIOV livemigration WorkloadUpdateStrategy LiveMigrated) proved to cause more issues than benefits. Let's revert it. HCO will not inject special configuration based on SNO topology and virt-controller will do the rest. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2073880 This is a manual cherry-pick of #1908 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

tiraboschi · 2022-04-28T07:34:36Z

ignoring Sanity Checks / Sanity Checks that is definitively failing just due to infra issues

tiraboschi requested review from orenc1 and nunnatsa April 26, 2022 16:32

kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 26, 2022

kubevirt-bot requested a review from sradco April 26, 2022 16:32

kubevirt-bot added the size/L label Apr 26, 2022

tiraboschi mentioned this pull request Apr 26, 2022

[release-1.6] Avoid special handling for liveMigration FG on SNO #1909

Merged

11 tasks

orenc1 approved these changes Apr 27, 2022

View reviewed changes

kubevirt-bot assigned orenc1 Apr 27, 2022

kubevirt-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 27, 2022

tiraboschi force-pushed the sno_lv branch from f00f2e2 to 5ec5b18 Compare April 27, 2022 12:52

kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2022

tiraboschi force-pushed the sno_lv branch from 5ec5b18 to 8e1c119 Compare April 27, 2022 16:29

nunnatsa approved these changes Apr 28, 2022

View reviewed changes

kubevirt-bot assigned nunnatsa Apr 28, 2022

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2022

tiraboschi merged commit af0e76c into kubevirt:main Apr 28, 2022

tiraboschi deleted the sno_lv branch April 28, 2022 07:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid special handling for liveMigration FG on SNO #1908

Avoid special handling for liveMigration FG on SNO #1908

tiraboschi commented Apr 26, 2022

coveralls commented Apr 26, 2022 •

edited

Loading

tiraboschi commented Apr 26, 2022

kubevirt-bot commented Apr 26, 2022

hco-bot commented Apr 26, 2022

kubevirt-bot commented Apr 26, 2022

hco-bot commented Apr 26, 2022

kubevirt-bot commented Apr 26, 2022

orenc1 left a comment

hco-bot commented Apr 27, 2022

kubevirt-bot commented Apr 27, 2022

hco-bot commented Apr 27, 2022

kubevirt-bot commented Apr 27, 2022

tiraboschi commented Apr 27, 2022

sonarcloud bot commented Apr 27, 2022

hco-bot commented Apr 27, 2022

kubevirt-bot commented Apr 27, 2022

tiraboschi commented Apr 27, 2022

tiraboschi commented Apr 27, 2022

openshift-ci bot commented Apr 27, 2022

hco-bot commented Apr 27, 2022

kubevirt-bot commented Apr 27, 2022

nunnatsa left a comment

kubevirt-bot commented Apr 28, 2022

tiraboschi commented Apr 28, 2022

Avoid special handling for liveMigration FG on SNO #1908

Avoid special handling for liveMigration FG on SNO #1908

Conversation

tiraboschi commented Apr 26, 2022

coveralls commented Apr 26, 2022 • edited Loading

Pull Request Test Coverage Report for Build 2234409203

💛 - Coveralls

tiraboschi commented Apr 26, 2022

kubevirt-bot commented Apr 26, 2022

hco-bot commented Apr 26, 2022

kubevirt-bot commented Apr 26, 2022

hco-bot commented Apr 26, 2022

kubevirt-bot commented Apr 26, 2022

orenc1 left a comment

Choose a reason for hiding this comment

hco-bot commented Apr 27, 2022

kubevirt-bot commented Apr 27, 2022

hco-bot commented Apr 27, 2022

kubevirt-bot commented Apr 27, 2022

tiraboschi commented Apr 27, 2022

sonarcloud bot commented Apr 27, 2022

hco-bot commented Apr 27, 2022

kubevirt-bot commented Apr 27, 2022

tiraboschi commented Apr 27, 2022

tiraboschi commented Apr 27, 2022

openshift-ci bot commented Apr 27, 2022

hco-bot commented Apr 27, 2022

kubevirt-bot commented Apr 27, 2022

nunnatsa left a comment

Choose a reason for hiding this comment

kubevirt-bot commented Apr 28, 2022

tiraboschi commented Apr 28, 2022

coveralls commented Apr 26, 2022 •

edited

Loading