Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go Dependencies to 1.18.1 #1911

Merged
merged 1 commit into from
May 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-push-images.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v2
with:
go-version: '1.17'
go-version: '1.18'
- name: Get latest version
run: |
PACKAGE_DIR="./deploy/olm-catalog/community-kubevirt-hyperconverged"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/digester_bot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- uses: actions/setup-go@v2
if: ${{ env.NEW_PR }}
with:
go-version: '1.17' # The Go version to download (if necessary) and use.
go-version: '1.18' # The Go version to download (if necessary) and use.

- name: Get dependencies
if: ${{ env.NEW_PR }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-sanity.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:

- uses: actions/setup-go@v2
with:
go-version: '1.17' # The Go version to download (if necessary) and use.
go-version: '1.18' # The Go version to download (if necessary) and use.

- name: Do sanity checks
run: make sanity
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-community-operators.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v2
with:
go-version: '1.17'
go-version: '1.18'
- name: Checkout the latest code of ${{ env.TARGET_BRANCH }} branch
uses: actions/checkout@v2
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/rebase-bot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v2
with:
go-version: '1.17'
go-version: '1.18'

- name: Rebase and rebuild manifests
id: rebase_rebuild
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-bumper.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:

- uses: actions/setup-go@v2
with:
go-version: '1.17' # The Go version to download (if necessary) and use.
go-version: '1.18' # The Go version to download (if necessary) and use.

- name: Check for new releases and update
env:
Expand Down
2 changes: 1 addition & 1 deletion automation/nightly/test-nightly-build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ source "hack/cri-bin.sh"

# Get golang
$CRI_BIN login --username "$(cat "${QUAY_USER}")" --password-stdin quay.io < "${QUAY_PASSWORD}"
wget -q https://dl.google.com/go/go1.17.3.linux-amd64.tar.gz
wget -q https://dl.google.com/go/go1.18.1.linux-amd64.tar.gz
tar -C /usr/local -xf go*.tar.gz
export PATH=/usr/local/go/bin:$PATH

Expand Down
2 changes: 1 addition & 1 deletion build/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.17.0 AS builder
FROM golang:1.18.1 AS builder

WORKDIR /go/src/github.com/kubevirt/hyperconverged-cluster-operator/
COPY . .
Expand Down
2 changes: 1 addition & 1 deletion build/Dockerfile.functest
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.17.0 AS builder
FROM golang:1.18.1 AS builder

WORKDIR /go/src/github.com/kubevirt/hyperconverged-cluster-operator/
COPY . .
Expand Down
3 changes: 1 addition & 2 deletions build/Dockerfile.functest.ci
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# TODO: replace with golang 1.17 and OCP 4.10 once ready
# registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.17-openshift-4.10
FROM registry.ci.openshift.org/open-cluster-management/builder:go1.17-linux AS builder
FROM registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.18-openshift-4.11 AS builder

WORKDIR /go/src/github.com/kubevirt/hyperconverged-cluster-operator/
COPY . .
Expand Down
2 changes: 1 addition & 1 deletion build/Dockerfile.webhook
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.17.0 AS builder
FROM golang:1.18.1 AS builder

WORKDIR /go/src/github.com/kubevirt/hyperconverged-cluster-operator/
COPY . .
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/kubevirt/hyperconverged-cluster-operator

go 1.17
go 1.18

require (
github.com/blang/semver/v4 v4.0.0
Expand Down
689 changes: 0 additions & 689 deletions go.sum

Large diffs are not rendered by default.

5 changes: 2 additions & 3 deletions hack/build-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,8 @@ if [ "${JOB_TYPE}" == "travis" ]; then
ginkgo -cover -output-dir=./coverprofiles -coverprofile=cover.coverprofile -r ${PKG_PACKAGE_PATH} -r ${CONTROLLERS_PACKAGE_PATH}
else
test_path="tests/func-tests"
(cd $test_path; go install github.com/onsi/ginkgo/v2/ginkgo@latest)
(cd $test_path; GOFLAGS= go get github.com/onsi/gomega)
(cd $test_path; go mod tidy; go mod vendor)
(cd $test_path; GOFLAGS='' go install github.com/onsi/ginkgo/v2/ginkgo@latest)
(cd $test_path; go mod tidy; go mod vendor)
test_out_path=${test_path}/_out
mkdir -p ${test_out_path}
(cd $test_path; ginkgo build .)
Expand Down
2 changes: 1 addition & 1 deletion hack/in-docker.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ HCO_DIR="$(readlink -f $(dirname $0)/../)"
WORK_DIR="/go/src/github.com/kubevirt/hyperconverged-cluster-operator"
REGISTRY=${REGISTRY:-quay.io/kubevirtci}
REPOSITORY=${REPOSITORY:-hco-test-build}
TAG=${TAG:-v20211109-01bbb11}
TAG=${TAG:-v20220510-9ff67b2}
BUILD_TAG="${REGISTRY}/${REPOSITORY}:${TAG}"

# Execute the build
Expand Down
14 changes: 6 additions & 8 deletions tests/build/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ RUN echo "diskspacecheck=0" >> /etc/dnf/dnf.conf && dnf update -y && dnf install

RUN pip3 install j2cli && pip3 install operator-courier

ENV GO_VERSION=1.17.3 \
ENV GO_VERSION=1.18.1 \
KUBEBUILDER_VERSION="3.2.0" \
ARCH="amd64" \
GOPATH="/go" \
Expand All @@ -21,16 +21,14 @@ RUN \
rm -rf go${GO_VERSION}.linux-amd64.tar.gz && \
export PATH=${GOPATH}/bin:$PATH && \
eval $(go env) && \
go install github.com/onsi/ginkgo/ginkgo@latest && \
go get github.com/onsi/gomega && \
go install github.com/onsi/ginkgo/v2/ginkgo@latest && \
go install golang.org/x/tools/cmd/goimports@latest && \
go get -u -d golang.org/x/lint/golint && \
go install golang.org/x/lint/golint@latest && \
go install github.com/rmohr/go-swagger-utils/swagger-doc@latest && \
go install github.com/mattn/goveralls@latest && \
go get -u -d mvdan.cc/sh/v3/cmd/shfmt && \
go get -u -d k8s.io/code-generator/cmd/deepcopy-gen && \
go get -u -d k8s.io/kube-openapi/cmd/openapi-gen && \
go get -u -d github.com/Masterminds/glide && \
go install mvdan.cc/sh/v3/cmd/shfmt@latest && \
go install k8s.io/code-generator/cmd/deepcopy-gen@latest && \
go install k8s.io/kube-openapi/cmd/openapi-gen@latest && \
(curl -L -O "https://github.com/kubernetes-sigs/kubebuilder/releases/download/v${KUBEBUILDER_VERSION}/kubebuilder_${KUBEBUILDER_VERSION}_linux_${ARCH}" && \
mv kubebuilder_${KUBEBUILDER_VERSION}_linux_${ARCH} /usr/local/kubebuilder )

Expand Down
2 changes: 1 addition & 1 deletion tests/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/kubevirt/hyperconverged-cluster-operator/tests

go 1.17
go 1.18

require (
github.com/kubevirt/cluster-network-addons-operator v0.73.0
Expand Down
2 changes: 1 addition & 1 deletion tools/digester/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/kubevirt/hyperconverged-cluster-operator/tools/digester

go 1.17
go 1.18

require github.com/containers/image/v5 v5.19.2

Expand Down
2 changes: 1 addition & 1 deletion tools/release-notes/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/kubevirt/hyperconverged-cluster-operator/automation/releasenotes

go 1.17
go 1.18

require (
github.com/Masterminds/semver v1.5.0
Expand Down