Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new metric and a new alert for not completed installation #1914

Merged
merged 5 commits into from
May 10, 2022
Merged

Add a new metric and a new alert for not completed installation #1914

merged 5 commits into from
May 10, 2022

Conversation

nunnatsa
Copy link
Collaborator

@nunnatsa nunnatsa commented May 1, 2022

This PR adds a new Prometheus metric kubevirt_hco_hyperconverged_cr_exists. HCO set this metric to 1 if the HyperConverged CR is exist, or 0 if not.

The PR also adds a new alert KubevirtHyperconvergedClusterOperatorInstallationNotCompletedAlert. This alert is triggered when the new kubevirt_hco_hyperconverged_cr_exists metric is not 1 (if the HyperConverged CR does not exist).

The meaning of the new alert is that the installation is not completed, and the user should create the HyperConverged CR to complete the installation.

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Release note:

New metric: kubevirt_hco_hyperconverged_cr_exists - 1 if the HyperConverged CR exists, 0 if not

New alert KubevirtHyperconvergedClusterOperatorInstallationNotCompletedAlert if the kubevirt_hco_hyperconverged_cr_exists metric is not 1.

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 1, 2022
@nunnatsa nunnatsa requested a review from tiraboschi May 1, 2022 12:50
@nunnatsa nunnatsa requested a review from sradco May 1, 2022 12:50
@nunnatsa nunnatsa force-pushed the add-new-metric branch 3 times, most recently from b881144 to 6fc3cec Compare May 1, 2022 13:44
@hco-bot
Copy link
Collaborator

hco-bot commented May 1, 2022

hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-sno-azure

In response to this:

hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented May 2, 2022

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa nunnatsa force-pushed the add-new-metric branch 3 times, most recently from 6fc09bd to 56777a9 Compare May 4, 2022 07:43
sradco
sradco reviewed May 4, 2022
View reviewed changes
controllers/operands/monitoring.go Outdated
Alert: installationNotCompletedAlert,
Expr: intstr.FromString("(1 - kubevirt_hco_hyperconverged_cr_exists) > 0"),
Annotations: map[string]string{
"description": "the installation was not completed; the HyperConverged custom resource is missing.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nunnatsa perhaps,
In order to complete the installation of the Hyperconverged Cluster Operator you should create the HyperConverged custom resource.

On d/s runbooks we can rename to OpenShift Virtualization.

sradco
sradco reviewed May 4, 2022
View reviewed changes
controllers/operands/monitoring.go Outdated
Expr: intstr.FromString("(1 - kubevirt_hco_hyperconverged_cr_exists) > 0"),
Annotations: map[string]string{
"description": "the installation was not completed; the HyperConverged custom resource is missing.",
"summary": "the installation was not completed; the HyperConverged custom resource is missing.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nunnatsa perhaps
The HyperConverged custom resource is missing.

@hco-bot
Copy link
Collaborator

hco-bot commented May 4, 2022

hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-sno-aws

In response to this:

hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa nunnatsa force-pushed the add-new-metric branch 4 times, most recently from 9df87e6 to 1011bd8 Compare May 8, 2022 10:57
orenc1
orenc1 reviewed May 8, 2022
View reviewed changes
pkg/metrics/metrics.go Outdated
HCOMetricHyperConvergedExists = "HyperConvergedCRExists"

HyperConvergedExists = float64(1)
HyperConvergedNotExist = float64(0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:
HyperConvergedNotExist --> HyperConvergedNotExists

@coveralls
Copy link
Collaborator

coveralls commented May 8, 2022 •
edited

Pull Request Test Coverage Report for Build 2292718055

  • 17 of 21 (80.95%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 84.245%
Changes Missing Coverage Covered Lines Changed/Added Lines %
controllers/hyperconverged/hyperconverged_controller.go 2 6 33.33%
Totals Coverage Status
Change from base Build 2292594481: -0.03%
Covered Lines: 4160
Relevant Lines: 4938
💛 - Coveralls

@hco-bot
Copy link
Collaborator

hco-bot commented May 8, 2022

hco-e2e-image-index-gcp, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-azure
hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws
hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure

@nunnatsa
fix code review comments
65d5209 
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hco-bot
Copy link
Collaborator

hco-bot commented May 9, 2022

hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-azure

In response to this:

hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator Author

nunnatsa commented May 9, 2022

/retest

@hco-bot
Copy link
Collaborator

hco-bot commented May 9, 2022

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator Author

nunnatsa commented May 9, 2022

/retest

1 similar comment
@nunnatsa
Copy link
Collaborator Author

nunnatsa commented May 9, 2022

/retest

@nunnatsa
Copy link
Collaborator Author

nunnatsa commented May 9, 2022

/test hco-e2e-kv-smoke-gcp

@kubevirt-bot
Copy link
Contributor

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build-hco-test-utils-image
  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.23

Use /test all to run the following jobs that were automatically triggered:

  • pull-hyperconverged-cluster-operator-e2e-k8s-1.23

In response to this:

/test hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented May 9, 2022 •
edited

@nunnatsa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-image-index-sno-azure 65d5209 link false /test hco-e2e-image-index-sno-azure
ci/prow/hco-e2e-upgrade-prev-index-azure 65d5209 link true /test hco-e2e-upgrade-prev-index-azure
ci/prow/hco-e2e-upgrade-prev-index-sno-aws 65d5209 link false /test hco-e2e-upgrade-prev-index-sno-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nunnatsa
Copy link
Collaborator Author

nunnatsa commented May 9, 2022

/override-bot

2 similar comments
@nunnatsa
Copy link
Collaborator Author

nunnatsa commented May 9, 2022

/override-bot

@nunnatsa
Copy link
Collaborator Author

/override-bot

@nunnatsa nunnatsa requested review from sradco and orenc1 May 10, 2022 05:58
@nunnatsa
Copy link
Collaborator Author

hco-e2e-upgrade-prev-index-sno-azure lane passed

/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-upgrade-prev-index-sno-aws

In response to this:

hco-e2e-upgrade-prev-index-sno-azure lane passed

/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator Author

/override coverage/coveralls

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: coverage/coveralls

In response to this:

/override coverage/coveralls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2022
@tiraboschi
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2022
@kubevirt-bot kubevirt-bot merged commit 4de3d5a into kubevirt:main May 10, 2022
@nunnatsa nunnatsa deleted the add-new-metric branch May 10, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi tiraboschi approved these changes

@machadovilaca machadovilaca Awaiting requested review from machadovilaca

@sradco sradco Awaiting requested review from sradco

@orenc1 orenc1 Awaiting requested review from orenc1

Assignees

@tiraboschi tiraboschi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nunnatsa @hco-bot @kubevirt-bot @coveralls @tiraboschi @sradco @orenc1