Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csv-merger: handle skips and olm.skipRange as parameters #1923

Merged
merged 1 commit into from
May 5, 2022
Merged

csv-merger: handle skips and olm.skipRange as parameters #1923

merged 1 commit into from
May 5, 2022

Conversation

tiraboschi
Copy link
Member

Signed-off-by: Simone Tiraboschi stirabos@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Release note:

csv-merger: handle skips and olm.skipRange as parameters

@tiraboschi
csv-merger: handle skips and olm.skipRange as parameters
912ca8d 
Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@tiraboschi tiraboschi requested a review from orenc1 May 4, 2022 14:50
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2270520731

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 84.275%
Files with Coverage Reduction New Missed Lines %
controllers/operands/operandHandler.go 1 88.17%
Totals Coverage Status
Change from base Build 2266367906: -0.02%
Covered Lines: 4148
Relevant Lines: 4922
💛 - Coveralls

@tiraboschi
Copy link
Member Author

Ignoring false positive on coverage
/override coverage/coveralls

@kubevirt-bot
Copy link
Contributor

@tiraboschi: Overrode contexts on behalf of tiraboschi: coverage/coveralls

In response to this:

Ignoring false positive on coverage
/override coverage/coveralls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@machadovilaca
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2022
@machadovilaca
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machadovilaca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2022
@kubevirt-bot kubevirt-bot merged commit a93645d into kubevirt:main May 5, 2022
@tiraboschi tiraboschi deleted the skips_param branch June 8, 2022 15:55
@tiraboschi
Copy link
Member Author

/cherry-pick release-1.6
/cherry-pick release-1.5

@kubevirt-bot kubevirt-bot mentioned this pull request Jun 8, 2022
Merged
@kubevirt-bot
Copy link
Contributor

@tiraboschi: new pull request created: #1997

In response to this:

/cherry-pick release-1.6
/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/cherry-pick release-1.5

@kubevirt-bot kubevirt-bot mentioned this pull request Jun 8, 2022
Merged
@kubevirt-bot
Copy link
Contributor

@tiraboschi: new pull request created: #1998

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orenc1 orenc1 Awaiting requested review from orenc1

@machadovilaca machadovilaca Awaiting requested review from machadovilaca

@nunnatsa nunnatsa Awaiting requested review from nunnatsa

Assignees

@machadovilaca machadovilaca

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tiraboschi @coveralls @kubevirt-bot @machadovilaca