-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert NMO handling in main #1942
Revert NMO handling in main #1942
Conversation
a0cb3d1
to
defefad
Compare
Upgradeable
Condition
Pull Request Test Coverage Report for Build 2344465795
💛 - Coveralls |
defefad
to
f508ad1
Compare
hco-e2e-upgrade-prev-index-sno-azure lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-sno-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fmt.Sprintf("Node Maintenance Operator custom resources %s have been found. Please remove them to allow upgrade. "+ | ||
"You can use NMO standalone operator if keeping the node(s) under maintenance is still required.", nmoCrdName)) | ||
req.Upgradeable = false | ||
err = r.setOperatorUpgradeableStatus(req) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure it should be called from here. The Reconcile
method should handle this call.
This PR should be done only on release-1.6, to block upgrade to 1.7.0 if NMO CR exists. |
f508ad1
to
c143290
Compare
Upgradeable
Conditionc143290
to
3b571d9
Compare
3b571d9
to
453b164
Compare
/retest |
hco-e2e-upgrade-prev-index-aws lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure, ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-index-azure, ci/prow/hco-e2e-upgrade-prev-index-azure, ci/prow/okd-hco-e2e-image-index-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hco-e2e-image-index-sno-aws lane passed. |
@orenc1: Overrode contexts on behalf of orenc1: ci/prow/hco-e2e-image-index-sno-azure, ci/prow/okd-hco-e2e-upgrade-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiraboschi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Upgrade is being blocked from previous version if NMO CRs exist on the cluster. In main, we just remove the NMO CRD as a leftover using update patch mechanism. Signed-off-by: orenc1 <ocohen@redhat.com>
453b164
to
d472bc0
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
hco-e2e-image-index-gcp lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-image-index-azure, ci/prow/hco-e2e-image-index-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@orenc1: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
hco-e2e-upgrade-index-sno-azure lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Upgrade is being blocked from previous version if NMO CRs exist on the cluster.
In main, we just remove the NMO CRD as a leftover using update patch mechanism.
Signed-off-by: orenc1 ocohen@redhat.com
Reviewer Checklist
Release note: