Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reconcile ConsoleCLIDownload and ConsoleQuickStart #1944

Merged
merged 1 commit into from
May 17, 2022
Merged

reconcile ConsoleCLIDownload and ConsoleQuickStart #1944

merged 1 commit into from
May 17, 2022

Conversation

tiraboschi
Copy link
Member

correctly add consolev1.ConsoleCLIDownload and
consolev1.ConsoleQuickStart to the client cache
and the reconciliation loop.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2086114

Signed-off-by: Simone Tiraboschi stirabos@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Release note:

reconcile ConsoleCLIDownload and ConsoleQuickStart

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 16, 2022
@tiraboschi tiraboschi requested a review from nunnatsa May 16, 2022 07:11
@coveralls
Copy link
Collaborator

coveralls commented May 16, 2022 •
edited

Pull Request Test Coverage Report for Build 2330347396

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 84.181%
Changes Missing Coverage Covered Lines Changed/Added Lines %
controllers/hyperconverged/hyperconverged_controller.go 0 1 0.0%
Totals Coverage Status
Change from base Build 2326747993: -0.02%
Covered Lines: 4188
Relevant Lines: 4975
💛 - Coveralls

@tiraboschi
reconcile ConsoleCLIDownload and ConsoleQuickStart
b78cc2e 
correctly add consolev1.ConsoleCLIDownload and
consolev1.ConsoleQuickStart to the client cache
and the reconciliation loop.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2086114

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented May 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hco-bot
Copy link
Collaborator

hco-bot commented May 16, 2022

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented May 16, 2022

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure
hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-azure, ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure
hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented May 16, 2022

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/retest

@tiraboschi
Copy link
Member Author

ignoring slightly decreased coverage
/override coverage/coveralls

@kubevirt-bot
Copy link
Contributor

@tiraboschi: Overrode contexts on behalf of tiraboschi: coverage/coveralls

In response to this:

ignoring slightly decreased coverage
/override coverage/coveralls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented May 16, 2022

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-aws

In response to this:

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented May 16, 2022 •
edited

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-image-index-gcp b78cc2e link true /test hco-e2e-image-index-gcp
ci/prow/hco-e2e-image-index-sno-azure b78cc2e link false /test hco-e2e-image-index-sno-azure
ci/prow/hco-e2e-upgrade-prev-index-azure b78cc2e link true /test hco-e2e-upgrade-prev-index-azure
ci/prow/hco-e2e-image-index-azure b78cc2e link true /test hco-e2e-image-index-azure
ci/prow/hco-e2e-upgrade-index-aws b78cc2e link true /test hco-e2e-upgrade-index-aws
ci/prow/hco-e2e-upgrade-index-sno-aws b78cc2e link false /test hco-e2e-upgrade-index-sno-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hco-bot
Copy link
Collaborator

hco-bot commented May 16, 2022

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-aws

In response to this:

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/override-bot

1 similar comment
@tiraboschi
Copy link
Member Author

/override-bot

@tiraboschi
Copy link
Member Author

/retest

@nunnatsa
Copy link
Collaborator

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2022
@tiraboschi
Copy link
Member Author

/retest

@kubevirt-bot kubevirt-bot merged commit eeb65b3 into kubevirt:main May 17, 2022
@tiraboschi tiraboschi deleted the rec_quickstart branch May 17, 2022 10:51
@tiraboschi
Copy link
Member Author

/cherry-pick release-1.6

@kubevirt-bot
Copy link
Contributor

@tiraboschi: #1944 failed to apply on top of branch "release-1.6":

Applying: reconcile ConsoleCLIDownload and ConsoleQuickStart
Using index info to reconstruct a base tree...
M	cmd/hyperconverged-cluster-operator/main.go
A	controllers/hyperconverged/hyperconverged_controller.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/controller/hyperconverged/hyperconverged_controller.go
Auto-merging cmd/hyperconverged-cluster-operator/main.go
CONFLICT (content): Merge conflict in cmd/hyperconverged-cluster-operator/main.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 reconcile ConsoleCLIDownload and ConsoleQuickStart
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi added a commit to tiraboschi/hyperconverged-cluster-operator that referenced this pull request May 17, 2022
@tiraboschi
[release-1.6] reconcile ConsoleCLIDownload and ConsoleQuickStart (kub…
8716614 
…evirt#1944)

correctly add consolev1.ConsoleCLIDownload and
consolev1.ConsoleQuickStart to the client cache
and the reconciliation loop.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2086114

This is a manual cherry-pick of kubevirt#1944

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@tiraboschi tiraboschi mentioned this pull request May 17, 2022
Merged
11 tasks
kubevirt-bot pushed a commit that referenced this pull request May 18, 2022
@tiraboschi
[release-1.6] reconcile ConsoleCLIDownload and ConsoleQuickStart (#1944…
4a59729 
…) (#1954)

correctly add consolev1.ConsoleCLIDownload and
consolev1.ConsoleQuickStart to the client cache
and the reconciliation loop.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2086114

This is a manual cherry-pick of #1944

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machadovilaca machadovilaca Awaiting requested review from machadovilaca

@sradco sradco Awaiting requested review from sradco

@nunnatsa nunnatsa Awaiting requested review from nunnatsa

Assignees

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tiraboschi @coveralls @hco-bot @kubevirt-bot @nunnatsa