-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug where HCO does not reconcile PrometheusRule #1984
Conversation
Fix BZ 2092158 (https://bugzilla.redhat.com/show_bug.cgi?id=2092158) The bug is actually only about labels. This PR add label reconciliation of the PrometheusRule. Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
Kudos, SonarCloud Quality Gate passed! |
Pull Request Test Coverage Report for Build 2438414225
💛 - Coveralls |
hco-e2e-image-index-sno-aws lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@nunnatsa: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
hco-e2e-upgrade-prev-index-aws lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiraboschi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick main |
@tiraboschi: new pull request created: #1986 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix BZ 2092158 (https://bugzilla.redhat.com/show_bug.cgi?id=2092158)
The bug is actually only about labels. This PR add label reconciliation
of the PrometheusRule.
Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com
Reviewer Checklist
Release note: