[release-1.7] Fix BZ 2091309 and 2088849: don't force the user to copy DIC to disable it #1990
Conversation
Make the DataImportCronTemplate's spec to be optional. Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
Fix BZ 2088849: Add check in the create and update validation webhooks to make sure that
the "dataimportcrontemplate.kubevirt.io/enable" annotation is correct
("true" or "false").
Also check that if a DICT is enabled, then its spec is not empty.
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
kubevirt-bot
added
the
release-note
kubevirt-bot
added
the
dco-signoff: yes
|
Kudos, SonarCloud Quality Gate passed!
|
Pull Request Test Coverage Report for Build 2449697984
💛 - Coveralls |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
@kubevirt-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
hco-e2e-image-index-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #1987
/assign nunnatsa