Update Operator SDK dependency #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djzager
commented
Aug 7, 2019
| os.Exit(1) | ||
| for _, f := range []func(*apiruntime.Scheme) error{ | ||
| apis.AddToScheme, | ||
| cdiv1alpha1.AddToScheme, |
There was a problem hiding this comment.
It's weird that we aren't adding kubevirt to the Scheme.
There was a problem hiding this comment.
I think it's because kubevirt adds itself when you import the pkg. In other words, there's an init somewhere in kubevirt that does it.
Merged
rthallisey
approved these changes
Aug 8, 2019
ffromani
added a commit
to ffromani/hyperconverged-cluster-operator
that referenced
this pull request
Aug 8, 2019
It seems Gopkg.toml and Gopkg.lock gone offsync. Gopkg.lock already updated in kubevirt#203 with the right ssp-operator version. Signed-off-by: Francesco Romani <fromani@redhat.com>
djzager
pushed a commit
that referenced
this pull request
Aug 8, 2019
* Gopkg.toml: dep: bump the ssp-operator dependency to v1.0.8 It seems Gopkg.toml and Gopkg.lock gone offsync. Gopkg.lock already updated in #203 with the right ssp-operator version. Signed-off-by: Francesco Romani <fromani@redhat.com> * ssp: deploy MetricsAggregation CR Starting version 1.0.6, the SSP operator gained the ability to deploy the prometheus aggregation rules that kubevirt on openshift wants to expose (e.g. for telemetry). In this patch, we bump the vendored version to 1.0.7 (last released at this point in time), and we make sure to create the new CR. This patch only wants to add code, not to change any of the existing behaviour. Signed-off-by: Francesco Romani <fromani@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.