Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove live migration feature gate since it's deprecated #2043

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Remove live migration feature gate since it's deprecated #2043

merged 1 commit into from
Aug 23, 2022

Conversation

iholder101
Copy link
Contributor

@iholder101 iholder101 commented Jul 27, 2022 •
edited by nunnatsa

Removing live migration feature gate as it's deprecated in this PR: kubevirt/kubevirt#8047

Fixes #2039

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Release note:

Remove deprecated live migration feature gate

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 27, 2022
@iholder101
Copy link
Contributor Author

/cc @nunnatsa

@iholder101 iholder101 mentioned this pull request Jul 27, 2022
Merged
@iholder101 iholder101 force-pushed the deprecate/LiveMigrationFeatureGate branch from 32d946f to 577476a Compare July 27, 2022 11:10
@coveralls
Copy link
Collaborator

coveralls commented Jul 27, 2022 •
edited

Pull Request Test Coverage Report for Build 2898447255

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 84.969%
Files with Coverage Reduction New Missed Lines %
controllers/operands/operandHandler.go 1 84.85%
Totals Coverage Status
Change from base Build 2898436135: -0.02%
Covered Lines: 4460
Relevant Lines: 5249
💛 - Coveralls

@nunnatsa
Copy link
Collaborator

/hold

This PR is depended in the next KV release, where the LiveMigration FG is deprecated.

@iholder-redhat - please add a line to the PR description the it fixes #2039

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2022
@iholder101
Copy link
Contributor Author

/hold

This PR is depended in the next KV release, where the LiveMigration FG is deprecated.

@iholder-redhat - please add a line to the PR description the it fixes #2039

Done 👍

@iholder101 @nunnatsa
Remove live migration feature gate since it's deprecated
35a2059 
Signed-off-by: Itamar Holder <iholder@redhat.com>
@nunnatsa nunnatsa force-pushed the deprecate/LiveMigrationFeatureGate branch from 577476a to 35a2059 Compare August 21, 2022 12:23
@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nunnatsa
Copy link
Collaborator

#2056 was merged, so we can merge this one

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2022
@hco-bot
Copy link
Collaborator

hco-bot commented Aug 21, 2022

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator

/retest

1 similar comment
@nunnatsa
Copy link
Collaborator

/retest

@nunnatsa
Copy link
Collaborator

/test hco-e2e-upgrade-index-aws
/test hco-e2e-upgrade-index-azure

@kubevirt-bot
Copy link
Contributor

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build-hco-test-utils-image
  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.23

Use /test all to run the following jobs that were automatically triggered:

  • pull-hyperconverged-cluster-operator-e2e-k8s-1.23

In response to this:

/test hco-e2e-upgrade-index-aws
/test hco-e2e-upgrade-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator

/override coverage/coveralls

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: coverage/coveralls

In response to this:

/override coverage/coveralls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator

/retest

2 similar comments
@nunnatsa
Copy link
Collaborator

/retest

@nunnatsa
Copy link
Collaborator

/retest

@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2022 •
edited

@iholder-redhat: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-kv-smoke-azure 35a2059 link true /test hco-e2e-kv-smoke-azure
ci/prow/hco-e2e-upgrade-index-sno-aws 35a2059 link false /test hco-e2e-upgrade-index-sno-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hco-bot
Copy link
Collaborator

hco-bot commented Aug 23, 2022

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-aws

In response to this:

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2022
@kubevirt-bot kubevirt-bot merged commit e4846eb into kubevirt:main Aug 23, 2022
@nunnatsa nunnatsa mentioned this pull request Aug 23, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa Awaiting requested review from nunnatsa

@machadovilaca machadovilaca Awaiting requested review from machadovilaca

@orenc1 orenc1 Awaiting requested review from orenc1

Assignees

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not set the LiveMigration feature gate in KV
5 participants
@iholder101 @coveralls @nunnatsa @hco-bot @kubevirt-bot