Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubevirt, Remove deprecated SR-IOV-Live Migration feature gate #2067

Merged
merged 1 commit into from
Sep 6, 2022
Merged

kubevirt, Remove deprecated SR-IOV-Live Migration feature gate #2067

merged 1 commit into from
Sep 6, 2022

Conversation

ormergi
Copy link
Contributor

@ormergi ormergi commented Aug 28, 2022

Following kubevirt/kubevirt#7990, this PR remove SR-IOV live migration feature gate since it's deprecated.

Signed-off-by: Or Mergi ormergi@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Release note:

Remove deprecated SR-IOV live migration feature gate

@ormergi
kubevirt, Remove deprecated SR-IOV-Live Migration feature gate
366ec9e 
Signed-off-by: Or Mergi <ormergi@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 28, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2942063945

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 84.96%
Totals Coverage Status
Change from base Build 2925935809: -0.009%
Covered Lines: 4457
Relevant Lines: 5246
💛 - Coveralls

@hco-bot
Copy link
Collaborator

hco-bot commented Aug 28, 2022

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Aug 28, 2022

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/okd-hco-e2e-image-index-gcp

In response to this:

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa
nunnatsa reviewed Aug 29, 2022
View reviewed changes
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good in general. But we need to wait for a new release of KubeVirt, and a successful bump of its version here.

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2022
@nunnatsa
Copy link
Collaborator

nunnatsa commented Sep 6, 2022

@ormergi - #2073 is merged, bumping KubeVirt to v0.57.0-rc.0

If the deprecation of the sr-iov-live migration FG is part of this KubeVirt version, please go ahead and unhold.

@nunnatsa
Copy link
Collaborator

nunnatsa commented Sep 6, 2022

/retest

@ormergi
Copy link
Contributor Author

ormergi commented Sep 6, 2022

looks good in general. But we need to wait for a new release of KubeVirt, and a successful bump of its version here.

@nunnatsa Yes, kubevirt/kubevirt#7990 included in Kubevirt 0.57.0-rc.0.

@ormergi
Copy link
Contributor Author

ormergi commented Sep 6, 2022

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2022
@nunnatsa
Copy link
Collaborator

nunnatsa commented Sep 6, 2022

ignore tiny coverage change
/override coverage/coveralls

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: coverage/coveralls

In response to this:

ignore tiny coverage change
/override coverage/coveralls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa
nunnatsa approved these changes Sep 6, 2022
View reviewed changes
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2022
@nunnatsa
Copy link
Collaborator

nunnatsa commented Sep 6, 2022

/retest

@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2022

@ormergi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-hco-e2e-upgrade-index-gcp 366ec9e link true /test okd-hco-e2e-upgrade-index-gcp
ci/prow/hco-e2e-image-index-gcp 366ec9e link true /test hco-e2e-image-index-gcp
ci/prow/okd-hco-e2e-image-index-gcp 366ec9e link true /test okd-hco-e2e-image-index-gcp
ci/prow/hco-e2e-kv-smoke-azure 366ec9e link true /test hco-e2e-kv-smoke-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hco-bot
Copy link
Collaborator

hco-bot commented Sep 6, 2022

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit 38e839f into kubevirt:main Sep 6, 2022
@tiraboschi tiraboschi mentioned this pull request Oct 2, 2023
Merged
11 tasks
tiraboschi added a commit to tiraboschi/hyperconverged-cluster-operator that referenced this pull request Oct 3, 2023
@tiraboschi
Support ApplyOptions on upgradePatches
8023873 
Add support for optional ApplyOptions
(AllowMissingPathOnRemove/EnsurePathExistsOnAdd/...)
on upgradePatches from github.com/evanphx/json-patch/v5.
Bump it to v5 everywhere.

Add unit tests for allowMissingPathOnRemove and ensurePathExistsOnAdd.

Avoid trying to update featureGates/sriovLiveMigration
since it got removed with kubevirt#2067.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
kubevirt-bot pushed a commit that referenced this pull request Oct 3, 2023
@tiraboschi
Support ApplyOptions on upgradePatches (#2535)
f4a10b2 
Add support for optional ApplyOptions
(AllowMissingPathOnRemove/EnsurePathExistsOnAdd/...)
on upgradePatches from github.com/evanphx/json-patch/v5.
Bump it to v5 everywhere.

Add unit tests for allowMissingPathOnRemove and ensurePathExistsOnAdd.

Avoid trying to update featureGates/sriovLiveMigration
since it got removed with #2067.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa nunnatsa approved these changes

@sradco sradco Awaiting requested review from sradco

Assignees

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ormergi @coveralls @hco-bot @kubevirt-bot @nunnatsa