Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golang dependencies #2094

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Bump golang dependencies #2094

merged 1 commit into from
Sep 28, 2022

Conversation

tiraboschi
Copy link
Member

@tiraboschi tiraboschi commented Sep 27, 2022 •
edited

  • github.com/onsi/ginkgo/v2 v2.1.4 -> v2.2.0
  • github.com/onsi/gomega v1.20.0 -> v1.20.2
  • github.com/openshift/library-go v0.0.0-20220727134723-6802b30e83ba -> v0.0.0-20220922140741-7772048e4447
  • github.com/operator-framework/api v0.15.0 -> v0.17.1
  • github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring v0.58.0 -> v0.59.2
  • github.com/prometheus/client_golang v1.12.2 -> v1.13.0
  • golang.org/x/tools v0.1.11 -> v0.1.12
  • k8s.io/kube-openapi v0.0.0-20220627174259-011e075b9cb8 -> v0.0.0-20220803162953-67bda5d908f1
  • k8s.io/utils v0.0.0-20220713171938-56c0de1e6f5e -> v0.0.0-20220823124924-e9cbc92d1a73
  • sigs.k8s.io/controller-runtime v0.12.3 -> v0.13.0
  • sigs.k8s.io/controller-tools v0.9.2 -> v0.10.0
  • k8s.io/* v0.24.3 -> v0.25.2

Signed-off-by: Simone Tiraboschi stirabos@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Release note:

Bump golang dependencies

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 27, 2022
@kubevirt-bot kubevirt-bot added size/XXL release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 27, 2022
@tiraboschi
Bump golang dependencies
9897c02 
- github.com/onsi/ginkgo/v2 v2.1.4 -> v2.2.0
- github.com/onsi/gomega v1.20.0 -> v1.20.2
- github.com/openshift/library-go v0.0.0-20220727134723-6802b30e83ba -> v0.0.0-20220922140741-7772048e4447
- github.com/operator-framework/api v0.15.0 -> v0.17.1
- github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring v0.58.0 -> v0.59.2
- github.com/prometheus/client_golang v1.12.2 -> v1.13.0
- golang.org/x/tools v0.1.11 -> v0.1.12
- k8s.io/kube-openapi v0.0.0-20220627174259-011e075b9cb8 -> v0.0.0-20220803162953-67bda5d908f1
- k8s.io/utils v0.0.0-20220713171938-56c0de1e6f5e -> v0.0.0-20220823124924-e9cbc92d1a73
- sigs.k8s.io/controller-runtime v0.12.3 -> v0.13.0
- sigs.k8s.io/controller-tools v0.9.2 -> v0.10.0
- k8s.io/* v0.24.3 -> v0.25.2

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3137025368

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 85.284%
Totals Coverage Status
Change from base Build 3107183155: 0.02%
Covered Lines: 4584
Relevant Lines: 5375
💛 - Coveralls

@hco-bot
Copy link
Collaborator

hco-bot commented Sep 27, 2022

hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws

In response to this:

hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Sep 27, 2022

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws
okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-aws, ci/prow/okd-hco-e2e-image-index-gcp

In response to this:

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws
okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Sep 27, 2022 •
edited

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-hco-e2e-upgrade-index-gcp 9897c02 link true /test okd-hco-e2e-upgrade-index-gcp
ci/prow/hco-e2e-image-index-aws 9897c02 link true /test hco-e2e-image-index-aws
ci/prow/hco-e2e-upgrade-prev-index-sno-azure 9897c02 link false /test hco-e2e-upgrade-prev-index-sno-azure
ci/prow/okd-hco-e2e-image-index-gcp 9897c02 link true /test okd-hco-e2e-image-index-gcp
ci/prow/hco-e2e-upgrade-index-azure 9897c02 link true /test hco-e2e-upgrade-index-azure
ci/prow/hco-e2e-upgrade-index-sno-aws 9897c02 link false /test hco-e2e-upgrade-index-sno-aws
ci/prow/hco-e2e-image-index-azure 9897c02 link true /test hco-e2e-image-index-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hco-bot
Copy link
Collaborator

hco-bot commented Sep 27, 2022

hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-azure
okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp
hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure, ci/prow/hco-e2e-upgrade-index-azure, ci/prow/hco-e2e-upgrade-prev-index-sno-azure, ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-azure
okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp
hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/retest

nunnatsa
nunnatsa approved these changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Moving to K8s 1.25, shouldn't we also update the kvci lane as well? we're running it on 1.23

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2022
@kubevirt-bot kubevirt-bot merged commit 5f46eda into kubevirt:main Sep 28, 2022
@tiraboschi tiraboschi deleted the bump_dep_1.8 branch September 28, 2022 08:56
@tiraboschi
Copy link
Member Author

Moving to K8s 1.25, shouldn't we also update the kvci lane as well? we're running it on 1.23

k8s 1.25 CI provider is still WIP: kubevirt/kubevirtci#872 ,
but we can start adding a 1.24 lane: kubevirt/project-infra#2356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa nunnatsa approved these changes

@orenc1 orenc1 Awaiting requested review from orenc1

@sradco sradco Awaiting requested review from sradco

Assignees

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tiraboschi @coveralls @hco-bot @kubevirt-bot @nunnatsa