Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.8] Safely consume TLSSecurityProfile from APIServer CR #2158

Merged

Commits on Nov 24, 2022

  1. Safely consume TLSSecurityProfile from APIServer CR

    APIServer CR is validating TLSSecurityProfile
    less strictly than CNAO.
    HCO in general delegates the validation
    to the operators that is managing,
    but this is not true for values directly
    read from the APIServer CR
    that are not passing into our validating
    webhook.
    So if the cluster admin requires
    a custom configuration for TLSSecurityProfile
    on the APIServer CR all the components
    but CNAO will accept it while CNAO
    will refuse it continuously.
    Let's prevent this sanitizing the input.
    this is not validated
    
    Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2137896
    
    Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
    tiraboschi authored and kubevirt-bot committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    b5a5656 View commit details
    Browse the repository at this point in the history
  2. [release-1.8] New workaround for GC on CDI

    workaround for DataVolume GC on CDI v1.55.0:
    kubevirt/kubevirt#8584 didn't landed in Kubevirt v0.58.0.
    
    The previous workaround stopped working because the
    pinned test binary got garbage collected.
    
    TODO: remove this once kubevirt/kubevirt#8584 will land in Kubevirt v0.58.1
    
    Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
    tiraboschi committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    6e8044d View commit details
    Browse the repository at this point in the history