Avoid omitempty on WorkloadUpdateMethods #2180
Conversation
In our API for WorkloadUpdateMethods we read: ... An empty list defaults to no automated workload updating. and a default of: ["LiveMigrate"] but in the past the json representation of WorkloadUpdateMethods was defined with omitempty but, as for: https://go.dev/src/encoding/json/encode.go // The "omitempty" option specifies that the field should be omitted // from the encoding if the field has an empty value, defined as // false, 0, a nil pointer, a nil interface value, and any empty array, // slice, map, or string. the golang json encoder is omitting also empty array and slice and so an empty list on WorkloadUpdateMethods gets omitted at json level and so the APIServer will then replace it with the default value (["LiveMigrate"]). Avoid declaring omitempty on WorkloadUpdateMethods to make an empty list an acceptable value. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2151693 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
kubevirt-bot
added
release-note
|
Kudos, SonarCloud Quality Gate passed!
|
|
hco-e2e-upgrade-index-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-image-index-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-azure, ci/prow/hco-e2e-upgrade-index-azure, ci/prow/hco-e2e-upgrade-prev-index-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test hco-e2e-upgrade-prev-index-sno-aws |
kubevirt-bot
added
the
approved
|
@nunnatsa: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-image-index-gcp, hco-e2e-image-index-aws lanes succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@tiraboschi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override-bot |
|
hco-e2e-upgrade-prev-index-sno-aws passed |
|
@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-upgrade-prev-index-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.7 |
|
@nunnatsa: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@nunnatsa: #2180 failed to apply on top of branch "release-1.8": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@nunnatsa: #2180 failed to apply on top of branch "release-1.7": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In our API for WorkloadUpdateMethods we read: ... An empty list defaults to no automated workload updating. and a default of: ["LiveMigrate"] but in the past the json representation of WorkloadUpdateMethods was defined with omitempty but, as for: https://go.dev/src/encoding/json/encode.go // The "omitempty" option specifies that the field should be omitted // from the encoding if the field has an empty value, defined as // false, 0, a nil pointer, a nil interface value, and any empty array, // slice, map, or string. the golang json encoder is omitting also empty array and slice and so an empty list on WorkloadUpdateMethods gets omitted at json level and so the APIServer will then replace it with the default value (["LiveMigrate"]). Avoid declaring omitempty on WorkloadUpdateMethods to make an empty list an acceptable value. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2151693 This is a manual cherry-pick of kubevirt#2180 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
In our API for WorkloadUpdateMethods we read: ... An empty list defaults to no automated workload updating. and a default of: ["LiveMigrate"] but in the past the json representation of WorkloadUpdateMethods was defined with omitempty but, as for: https://go.dev/src/encoding/json/encode.go // The "omitempty" option specifies that the field should be omitted // from the encoding if the field has an empty value, defined as // false, 0, a nil pointer, a nil interface value, and any empty array, // slice, map, or string. the golang json encoder is omitting also empty array and slice and so an empty list on WorkloadUpdateMethods gets omitted at json level and so the APIServer will then replace it with the default value (["LiveMigrate"]). Avoid declaring omitempty on WorkloadUpdateMethods to make an empty list an acceptable value. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2151693 This is a manual cherry-pick of kubevirt#2180 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
In our API for WorkloadUpdateMethods we read: ... An empty list defaults to no automated workload updating. and a default of: ["LiveMigrate"] but in the past the json representation of WorkloadUpdateMethods was defined with omitempty but, as for: https://go.dev/src/encoding/json/encode.go // The "omitempty" option specifies that the field should be omitted // from the encoding if the field has an empty value, defined as // false, 0, a nil pointer, a nil interface value, and any empty array, // slice, map, or string. the golang json encoder is omitting also empty array and slice and so an empty list on WorkloadUpdateMethods gets omitted at json level and so the APIServer will then replace it with the default value (["LiveMigrate"]). Avoid declaring omitempty on WorkloadUpdateMethods to make an empty list an acceptable value. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2151693 This is a manual cherry-pick of #2180 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com> Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
In our API for WorkloadUpdateMethods we read: ... An empty list defaults to no automated workload updating. and a default of: ["LiveMigrate"] but in the past the json representation of WorkloadUpdateMethods was defined with omitempty but, as for: https://go.dev/src/encoding/json/encode.go // The "omitempty" option specifies that the field should be omitted // from the encoding if the field has an empty value, defined as // false, 0, a nil pointer, a nil interface value, and any empty array, // slice, map, or string. the golang json encoder is omitting also empty array and slice and so an empty list on WorkloadUpdateMethods gets omitted at json level and so the APIServer will then replace it with the default value (["LiveMigrate"]). Avoid declaring omitempty on WorkloadUpdateMethods to make an empty list an acceptable value. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2151693 This is a manual cherry-pick of #2180 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com> Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
In our API for WorkloadUpdateMethods we read:
...
An empty list defaults to no automated workload updating.
and a default of: ["LiveMigrate"]
but in the past the json representation of
WorkloadUpdateMethods was defined with omitempty
but, as for:
https://go.dev/src/encoding/json/encode.go
// The "omitempty" option specifies that the field should be omitted // from the encoding if the field has an empty value, defined as // false, 0, a nil pointer, a nil interface value, and any empty array, // slice, map, or string.
the golang json encoder is omitting also empty array and slice and so an empty list on WorkloadUpdateMethods gets omitted at json level and so the APIServer will then replace it with the default value (["LiveMigrate"]).
Avoid declaring omitempty on WorkloadUpdateMethods to make an empty list an acceptable value.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2151693
Signed-off-by: Simone Tiraboschi stirabos@redhat.com
Reviewer Checklist
Release note: