Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubevirt: Enforce limits & requests by a configurable ratio #2206

Merged
merged 7 commits into from
Jan 23, 2023
Merged

Kubevirt: Enforce limits & requests by a configurable ratio #2206

merged 7 commits into from
Jan 23, 2023

Commits on Jan 22, 2023

  1. Refactor: rename mutator to namespace mutator 

    Signed-off-by: Itamar Holder <iholder@redhat.com>
    @iholder101
    iholder101 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    0c30bc5 View commit details
    Browse the repository at this point in the history

  2. Introduce basic virt-launcher mutator 

    This commits takes the necessary steps in order
to set up a fully functional no-op virt-launcher
mutating webhook + a unit test.

This will serve as the skeleton for implementation
in further commits.

Signed-off-by: Itamar Holder <iholder@redhat.com>
    @iholder101
    iholder101 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    5d94c5c View commit details
    Browse the repository at this point in the history

  3. Add new webhook as deployable to KubevirtCI cluster 

    This commit edits deploy/webhooks.yaml file which is
manual (not auto-generated) in order to deploy the
new webhook into KubevirtCI cluster through
"make cluster-up"

Signed-off-by: Itamar Holder <iholder@redhat.com>
    @iholder101
    iholder101 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    e413291 View commit details
    Browse the repository at this point in the history

  4. Implement handleVirtLauncherCreation() 

    This commit implements handleVirtLauncherCreation()
which enforces CPU/memory limits according to the
defined ratio.

Signed-off-by: Itamar Holder <iholder@redhat.com>
    @iholder101
    iholder101 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    6ddff9c View commit details
    Browse the repository at this point in the history

  5. Enforce limits only if a relevant ResourceQuota exists 

    Enforce limits only if a ResourceQuota object on the
Pod's namespace and the quota enforces memory / cpu
limits.

Signed-off-by: Itamar Holder <iholder@redhat.com>
    @iholder101
    iholder101 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    595430f View commit details
    Browse the repository at this point in the history

  6. Unit test: test virt-launcher mutator 

    Signed-off-by: Itamar Holder <iholder@redhat.com>
    @iholder101
    iholder101 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    92edde8 View commit details
    Browse the repository at this point in the history

  7. Add documentation 

    Signed-off-by: Itamar Holder <iholder@redhat.com>
    @iholder101
    iholder101 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    56f2190 View commit details
    Browse the repository at this point in the history