Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KubeVirt: always set the feature gate that disables the custom SELinux policy #2211

Merged
merged 1 commit into from
Jan 27, 2023
Merged

KubeVirt: always set the feature gate that disables the custom SELinux policy #2211

merged 1 commit into from
Jan 27, 2023

Conversation

jean-edouard
Copy link
Contributor

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Release note:

All VMIs now run under the same SELinux domain as regular pods.

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 18, 2023
@jean-edouard
Copy link
Contributor Author

/hold
Needs kubevirt.io vendor directories to be bumped to an alpha/RC release that contains kubevirt/kubevirt PR 9048.

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2023
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2023
@tiraboschi
Copy link
Member

/approve

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2023
@coveralls
Copy link
Collaborator

coveralls commented Jan 19, 2023 •
edited

Pull Request Test Coverage Report for Build 4016249822

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.975%
Totals Coverage Status
Change from base Build 4015913823: -0.003%
Covered Lines: 4858
Relevant Lines: 5717
💛 - Coveralls

@tiraboschi
Copy link
Member

/retest

@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2023
@jean-edouard
Copy link
Contributor Author

Just force-pushed rebase on top of main to include the kubevirt bump.

@jean-edouard
KubeVirt: always set the feature gate that disables the custom SELinu…
4895c16 
…x policy

Signed-off-by: Jed Lejosne <jed@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tiraboschi
Copy link
Member

/retest

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2023
@tiraboschi
Copy link
Member

/approve

@tiraboschi
Copy link
Member

/unhold

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2023
@tiraboschi
Copy link
Member

ignoring slightly decreased coverage
/override coverage/coveralls

@kubevirt-bot
Copy link
Contributor

@tiraboschi: Overrode contexts on behalf of tiraboschi: coverage/coveralls

In response to this:

ignoring slightly decreased coverage
/override coverage/coveralls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Jan 26, 2023

hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
hco-e2e-image-index-gcp, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure, ci/prow/hco-e2e-upgrade-index-azure, ci/prow/hco-e2e-upgrade-index-sno-azure

In response to this:

hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
hco-e2e-image-index-gcp, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jan 26, 2023 •
edited

@jean-edouard: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-image-index-sno-aws 4895c16 link false /test hco-e2e-image-index-sno-aws
ci/prow/hco-e2e-upgrade-index-sno-azure 4895c16 link false /test hco-e2e-upgrade-index-sno-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hco-bot
Copy link
Collaborator

hco-bot commented Jan 26, 2023

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-aws

In response to this:

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member

hco-e2e-upgrade-index-sno-aws succeeded.
/override hco-e2e-upgrade-index-sno-azure

@kubevirt-bot
Copy link
Contributor

@tiraboschi: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • hco-e2e-upgrade-index-sno-azure

Only the following failed contexts/checkruns were expected:

  • ci/prow/ci-index-hco-bundle
  • ci/prow/hco-e2e-image-index-aws
  • ci/prow/hco-e2e-image-index-azure
  • ci/prow/hco-e2e-image-index-gcp
  • ci/prow/hco-e2e-image-index-sno-aws
  • ci/prow/hco-e2e-image-index-sno-azure
  • ci/prow/hco-e2e-kv-smoke-azure
  • ci/prow/hco-e2e-kv-smoke-gcp
  • ci/prow/hco-e2e-upgrade-index-aws
  • ci/prow/hco-e2e-upgrade-index-azure
  • ci/prow/hco-e2e-upgrade-index-sno-aws
  • ci/prow/hco-e2e-upgrade-index-sno-azure
  • ci/prow/hco-e2e-upgrade-prev-index-aws
  • ci/prow/hco-e2e-upgrade-prev-index-azure
  • ci/prow/hco-e2e-upgrade-prev-index-sno-aws
  • ci/prow/hco-e2e-upgrade-prev-index-sno-azure
  • ci/prow/okd-ci-index-hco-bundle
  • coverage/coveralls
  • dco
  • pull-hyperconverged-cluster-operator-e2e-k8s-1.24
  • pull-hyperconverged-cluster-operator-e2e-k8s-1.25
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

hco-e2e-upgrade-index-sno-aws succeeded.
/override hco-e2e-upgrade-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member

hco-e2e-upgrade-index-sno-aws succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

@kubevirt-bot
Copy link
Contributor

@tiraboschi: Overrode contexts on behalf of tiraboschi: ci/prow/hco-e2e-upgrade-index-sno-azure

In response to this:

hco-e2e-upgrade-index-sno-aws succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit 8596bc0 into kubevirt:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi tiraboschi approved these changes

@orenc1 orenc1 Awaiting requested review from orenc1

Assignees

@tiraboschi tiraboschi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jean-edouard @tiraboschi @coveralls @kubevirt-bot @hco-bot