KubeVirt: enable the seccomp feature gate and custom profile #2220

jean-edouard · 2023-01-26T18:40:44Z

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Release note:

KubeVirt is now configured to always install and use its custom seccomp policy

jean-edouard · 2023-01-26T18:40:57Z

/cc @xpivarc
/cc @acardace

hco-bot · 2023-01-26T20:04:06Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure
hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure
hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

kubevirt-bot · 2023-01-26T20:04:11Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure, ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-prev-index-azure, ci/prow/hco-e2e-upgrade-prev-index-sno-azure

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure
hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure
hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-01-26T20:21:43Z

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws
hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws

kubevirt-bot · 2023-01-26T20:21:48Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-aws, ci/prow/hco-e2e-upgrade-index-sno-aws

In response to this:

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws
hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-01-26T20:31:34Z

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws

kubevirt-bot · 2023-01-26T20:31:37Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-aws

In response to this:

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-01-26T20:41:30Z

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

kubevirt-bot · 2023-01-26T20:41:33Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2023-01-27T08:02:33Z

controllers/hyperconverged/hyperconverged_controller_test.go

+				Expect(kv.Spec.Configuration.SeccompConfiguration.VirtualMachineInstanceProfile).ToNot(BeNil())
+				Expect(kv.Spec.Configuration.SeccompConfiguration.VirtualMachineInstanceProfile.CustomProfile).ToNot(BeNil())
+				Expect(kv.Spec.Configuration.SeccompConfiguration.VirtualMachineInstanceProfile.CustomProfile.RuntimeDefaultProfile).To(BeFalse())
+				Expect(kv.Spec.Configuration.SeccompConfiguration.VirtualMachineInstanceProfile.CustomProfile.LocalhostProfile).To(Equal("kubevirt/kubevirt.json"))


This line fails in the unit test, because LocalhostProfile is a pointer, not a string.

Please fix:

Suggested change

Expect(kv.Spec.Configuration.SeccompConfiguration.VirtualMachineInstanceProfile.CustomProfile.LocalhostProfile).To(Equal("kubevirt/kubevirt.json"))

Expect(*kv.Spec.Configuration.SeccompConfiguration.VirtualMachineInstanceProfile.CustomProfile.LocalhostProfile).To(Equal("kubevirt/kubevirt.json"))

🤦 thank you! Fixed

nunnatsa

Please fix the unit test, so the sanity test will pass.

Signed-off-by: Jed Lejosne <jed@redhat.com>

sonarcloud · 2023-01-27T13:30:59Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

hco-bot · 2023-01-27T14:51:26Z

hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure
hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

kubevirt-bot · 2023-01-27T14:51:31Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-azure, ci/prow/hco-e2e-upgrade-index-azure, ci/prow/hco-e2e-upgrade-index-sno-azure, ci/prow/hco-e2e-upgrade-prev-index-sno-azure

In response to this:

hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure
hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-01-27T15:04:59Z

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

kubevirt-bot · 2023-01-27T15:05:02Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

coveralls · 2023-01-27T15:16:17Z

Pull Request Test Coverage Report for Build 4024930338

13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.02%) to 85.009%

Files with Coverage Reduction	New Missed Lines	%
controllers/operands/operandHandler.go	1	84.34%

Totals
Change from base Build 4022897182:	0.02%
Covered Lines:	4871
Relevant Lines:	5730

💛 - Coveralls

hco-bot · 2023-01-27T15:32:33Z

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure

kubevirt-bot · 2023-01-27T15:32:37Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-azure, ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-01-27T15:37:32Z

@jean-edouard: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-upgrade-index-azure	`c247f8a`	link	true	`/test hco-e2e-upgrade-index-azure`
ci/prow/hco-e2e-upgrade-prev-index-azure	`c247f8a`	link	true	`/test hco-e2e-upgrade-prev-index-azure`
ci/prow/hco-e2e-image-index-sno-azure	`c247f8a`	link	false	`/test hco-e2e-image-index-sno-azure`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hco-bot · 2023-01-27T15:51:43Z

hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure

kubevirt-bot · 2023-01-27T15:51:47Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-azure

In response to this:

hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2023-01-27T16:24:52Z

/approve

kubevirt-bot · 2023-01-27T16:25:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tiraboschi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 26, 2023

kubevirt-bot requested review from machadovilaca and sradco January 26, 2023 18:40

kubevirt-bot added the size/S label Jan 26, 2023

kubevirt-bot requested review from acardace and xpivarc January 26, 2023 18:40

acardace approved these changes Jan 27, 2023

View reviewed changes

kubevirt-bot assigned acardace Jan 27, 2023

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2023

nunnatsa reviewed Jan 27, 2023

View reviewed changes

nunnatsa requested changes Jan 27, 2023

View reviewed changes

kubevirt-bot assigned nunnatsa Jan 27, 2023

kubevirt-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels Jan 27, 2023

KubeVirt: enable the seccomp feature gate and custom profile

c247f8a

Signed-off-by: Jed Lejosne <jed@redhat.com>

jean-edouard force-pushed the seccomp branch from ebec87c to c247f8a Compare January 27, 2023 13:29

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2023

tiraboschi approved these changes Jan 27, 2023

View reviewed changes

kubevirt-bot assigned tiraboschi Jan 27, 2023

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2023

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2023

kubevirt-bot merged commit b43a081 into kubevirt:main Jan 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KubeVirt: enable the seccomp feature gate and custom profile #2220

KubeVirt: enable the seccomp feature gate and custom profile #2220

jean-edouard commented Jan 26, 2023

jean-edouard commented Jan 26, 2023

hco-bot commented Jan 26, 2023

kubevirt-bot commented Jan 26, 2023

hco-bot commented Jan 26, 2023

kubevirt-bot commented Jan 26, 2023

hco-bot commented Jan 26, 2023

kubevirt-bot commented Jan 26, 2023

hco-bot commented Jan 26, 2023

kubevirt-bot commented Jan 26, 2023

nunnatsa Jan 27, 2023 •

edited

Loading

jean-edouard Jan 27, 2023

nunnatsa left a comment

sonarcloud bot commented Jan 27, 2023

hco-bot commented Jan 27, 2023

kubevirt-bot commented Jan 27, 2023

hco-bot commented Jan 27, 2023

kubevirt-bot commented Jan 27, 2023

coveralls commented Jan 27, 2023

hco-bot commented Jan 27, 2023

kubevirt-bot commented Jan 27, 2023

openshift-ci bot commented Jan 27, 2023

hco-bot commented Jan 27, 2023

kubevirt-bot commented Jan 27, 2023

tiraboschi commented Jan 27, 2023

kubevirt-bot commented Jan 27, 2023

	Expect(kv.Spec.Configuration.SeccompConfiguration.VirtualMachineInstanceProfile.CustomProfile.LocalhostProfile).To(Equal("kubevirt/kubevirt.json"))
	Expect(*kv.Spec.Configuration.SeccompConfiguration.VirtualMachineInstanceProfile.CustomProfile.LocalhostProfile).To(Equal("kubevirt/kubevirt.json"))

KubeVirt: enable the seccomp feature gate and custom profile #2220

KubeVirt: enable the seccomp feature gate and custom profile #2220

Conversation

jean-edouard commented Jan 26, 2023

jean-edouard commented Jan 26, 2023

hco-bot commented Jan 26, 2023

kubevirt-bot commented Jan 26, 2023

hco-bot commented Jan 26, 2023

kubevirt-bot commented Jan 26, 2023

hco-bot commented Jan 26, 2023

kubevirt-bot commented Jan 26, 2023

hco-bot commented Jan 26, 2023

kubevirt-bot commented Jan 26, 2023

nunnatsa Jan 27, 2023 • edited Loading

Choose a reason for hiding this comment

jean-edouard Jan 27, 2023

Choose a reason for hiding this comment

nunnatsa left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Jan 27, 2023

hco-bot commented Jan 27, 2023

kubevirt-bot commented Jan 27, 2023

hco-bot commented Jan 27, 2023

kubevirt-bot commented Jan 27, 2023

coveralls commented Jan 27, 2023

Pull Request Test Coverage Report for Build 4024930338

💛 - Coveralls

hco-bot commented Jan 27, 2023

kubevirt-bot commented Jan 27, 2023

openshift-ci bot commented Jan 27, 2023

hco-bot commented Jan 27, 2023

kubevirt-bot commented Jan 27, 2023

tiraboschi commented Jan 27, 2023

kubevirt-bot commented Jan 27, 2023

nunnatsa Jan 27, 2023 •

edited

Loading