Fix upgrade bug related to the console plugin rename #2246
Conversation
kubevirt-bot
added
release-note
orenc1
force-pushed
the
fix_kubevirt_console_upgrade
branch
from
e9f5a01
to
d050b45
Compare
Pull Request Test Coverage Report for Build 4157200627
💛 - Coveralls |
|
hco-e2e-upgrade-index-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
okd-hco-e2e-image-index-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-image-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
in PR kubevirt#2232, the ui plugin's deployment, service and consoleplugin have been renamed from 'kubevirt-plugin' to 'kubevirt-console-plugin'. However, on upgrade, the old resources are not removed, and instead new resources with the new name are getting created, resulting in old+new plugins running simultaneously. This PR only updates the deployment and the service, and removing the old ones after upgrade, using upgradePatches.json. The ConsolePlugin CR remains kubevirt-plugin to avoid patching and deleting the console.operator.openshift.io singleton CR. Signed-off-by: Oren Cohen <ocohen@redhat.com>
orenc1
force-pushed
the
fix_kubevirt_console_upgrade
branch
from
d050b45
to
7f759df
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
hco-e2e-upgrade-index-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
okd-hco-e2e-image-index-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-image-index-gcp, ci/prow/okd-hco-e2e-upgrade-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@orenc1: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
okd-hco-e2e-image-index-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-image-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-image-index-sno-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-aws, ci/prow/hco-e2e-upgrade-prev-index-sno-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiraboschi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
in PR #2232, the ui plugin's deployment, service and consoleplugin have been renamed from
kubevirt-plugintokubevirt-console-plugin. However, on upgrade, the old resources are not removed, and instead new resources with the new name are getting created, resulting in old+new plugins running simultaneously. This PR only updates the deployment and the service, and removing the old ones after upgrade, usingupgradePatches.json. The ConsolePlugin CR name remainskubevirt-pluginto avoid patching and deleting theconsole.operator.openshift.iosingleton CR.Signed-off-by: Oren Cohen ocohen@redhat.com
Reviewer Checklist
Release note: