Workaround for nonRoot FG on Kubevirt #2273
Conversation
kubevirt-bot
added
release-note
With kubevirt/kubevirt#8563 Kubevirt introduced a new FG named `Root`, the `nonRoot` FG we are using is still there but declared as deprecated. Unfortunately due to bug on Kubevirt the now deprecated `nonRoot` FG we rely on is completely ignored so, as a workaround, we will start internally translating nonRoot -> Root on Kubevirt with negative logic. In a future PR the nonRoot FG will be properly deprecated also here and a new Root FG will be introduced with a proper conversion logic on upgrades. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2175171 JIRA-ticket: https://issues.redhat.com/browse/CNV-26406 Signed-off-by: stirabos <stirabos@redhat.com>
tiraboschi
force-pushed
the
nonroot_kvroot
branch
from
ed586b5
to
ef247d0
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Pull Request Test Coverage Report for Build 4324378564
💛 - Coveralls |
|
hco-e2e-upgrade-index-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-azure, ci/prow/hco-e2e-upgrade-index-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-prev-index-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-azure, ci/prow/hco-e2e-upgrade-prev-index-azure, ci/prow/hco-e2e-upgrade-prev-index-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@tiraboschi: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
hco-e2e-image-index-azure, hco-e2e-image-index-gcp lanes succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Up to version v0.58, Kubevirt was consuming a featuregate named nonRoot, with v0.59 it got renamed as Root with the opposite logic and so we implemented kubevirt#2273 as an internal workaround for the time being. Let's now align with Kubevirt featureGate name for the sake of consistency with a proper deprecation plan. `nonRoot` is still exposed on HCO but it's deprecated and a new `Root` FG is introduced. The mutating webhook will take care of the conversion. A Common Expression Language rule on the CRD will enforce the consistency of the two antithetic values. In the next release `nonRoot` will be removed. Adding unit and e2e tests. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2174859 Signed-off-by: stirabos <stirabos@redhat.com>
Up to version v0.58, Kubevirt was consuming a featuregate named nonRoot, with v0.59 it got renamed as Root with the opposite logic and so we implemented #2273 as an internal workaround for the time being. Let's now align with Kubevirt featureGate name for the sake of consistency with a proper deprecation plan. `nonRoot` is still exposed on HCO but it's deprecated and a new `Root` FG is introduced. The mutating webhook will take care of the conversion. A Common Expression Language rule on the CRD will enforce the consistency of the two antithetic values. In the next release `nonRoot` will be removed. Adding unit and e2e tests. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2174859 Signed-off-by: stirabos <stirabos@redhat.com>
With kubevirt/kubevirt#8563 Kubevirt introduced a new FG named
Root,the
nonRootFG we are using is still there butdeclared as deprecated.
Unfortunately due to bug on Kubevirt the now
deprecated
nonRootFG we rely on iscompletely ignored so, as a workaround, we will
start internally translating nonRoot -> Root
on Kubevirt with negative logic.
In a future PR the nonRoot FG will be properly deprecated also here and a new Root FG will
be introduced with a proper conversion logic on upgrades.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2175171
JIRA-ticket: https://issues.redhat.com/browse/CNV-26406
Reviewer Checklist
Release note: