[release-1.8]: Kubevirt: Enforce limits & requests by a configurable ratio #2280

iholder101 · 2023-03-08T10:09:52Z

Manual backport of #2206

Release note:

Kubevirt: Enforce limits & requests by a configurable ratio

iholder101 · 2023-03-08T10:10:20Z

/cc @nunnatsa @orenc1 @tiraboschi

Can you please take a look?

coveralls · 2023-03-08T10:29:00Z

Pull Request Test Coverage Report for Build 4477605810

127 of 181 (70.17%) changed or added relevant lines in 4 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.6%) to 85.071%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/webhooks/mutator/virt-launcher-mutator.go	98	152	64.47%

Files with Coverage Reduction	New Missed Lines	%
controllers/operands/operandHandler.go	1	84.34%

Totals
Change from base Build 4468582848:	-0.6%
Covered Lines:	4781
Relevant Lines:	5620

💛 - Coveralls

hco-bot · 2023-03-08T11:51:34Z

hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure
hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure

kubevirt-bot · 2023-03-08T11:51:38Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-azure, ci/prow/hco-e2e-upgrade-index-azure, ci/prow/hco-e2e-upgrade-index-sno-azure, ci/prow/hco-e2e-upgrade-prev-index-sno-azure

In response to this:

hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure
hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot · 2023-03-10T15:26:28Z

@tiraboschi: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

ci/prow/okd-hco-e2e-image-index-aws
ci/prow/okd-hco-e2e-image-index-gcp
ci/prow/okd-hco-e2e-upgrade-index-aws
ci/prow/okd-hco-e2e-upgrade-index-gcp

Only the following failed contexts/checkruns were expected:

ci/prow/ci-index
ci/prow/ci-index-hco-upgrade-bundle
ci/prow/ci-index-hco-upgrade-prev-bundle
ci/prow/hco-e2e-image-index-aws
ci/prow/hco-e2e-image-index-azure
ci/prow/hco-e2e-image-index-gcp
ci/prow/hco-e2e-image-index-sno-aws
ci/prow/hco-e2e-image-index-sno-azure
ci/prow/hco-e2e-kv-smoke-azure
ci/prow/hco-e2e-kv-smoke-gcp
ci/prow/hco-e2e-upgrade-index-aws
ci/prow/hco-e2e-upgrade-index-azure
ci/prow/hco-e2e-upgrade-index-sno-aws
ci/prow/hco-e2e-upgrade-index-sno-azure
ci/prow/hco-e2e-upgrade-prev-index-aws
ci/prow/hco-e2e-upgrade-prev-index-azure
ci/prow/hco-e2e-upgrade-prev-index-sno-aws
ci/prow/hco-e2e-upgrade-prev-index-sno-azure
ci/prow/images
coverage/coveralls
pull-hyperconverged-cluster-operator-e2e-k8s-1.23
pull-hyperconverged-cluster-operator-e2e-k8s-1.24
tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

Bumping version first to preparare bundle image for upgrade lanes.
CI will be enabled merging openshift/release#37169

/override ci/prow/hco-e2e-image-index-aws
/override ci/prow/hco-e2e-image-index-azure
/override ci/prow/hco-e2e-image-index-gcp
/override ci/prow/hco-e2e-image-index-sno-aws
/override ci/prow/hco-e2e-image-index-sno-azure
/override ci/prow/hco-e2e-kv-smoke-azure
/override ci/prow/hco-e2e-kv-smoke-gcp
/override ci/prow/hco-e2e-upgrade-index-aws
/override ci/prow/hco-e2e-upgrade-index-azure
/override ci/prow/hco-e2e-upgrade-index-sno-aws
/override ci/prow/hco-e2e-upgrade-index-sno-azure
/override ci/prow/hco-e2e-upgrade-prev-index-aws
/override ci/prow/hco-e2e-upgrade-prev-index-azure
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure
/override ci/prow/okd-hco-e2e-image-index-aws
/override ci/prow/okd-hco-e2e-image-index-gcp
/override ci/prow/okd-hco-e2e-upgrade-index-aws
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2023-03-10T15:27:28Z

sorry, wrong comment

hco-bot · 2023-03-10T17:04:00Z

hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure
hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

kubevirt-bot · 2023-03-10T17:04:07Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-azure, ci/prow/hco-e2e-upgrade-prev-index-sno-azure

In response to this:

hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure
hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-03-10T17:32:55Z

hco-e2e-upgrade-prev-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-aws

kubevirt-bot · 2023-03-10T17:32:59Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-aws

In response to this:

hco-e2e-upgrade-prev-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-03-10T17:41:35Z

hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure

kubevirt-bot · 2023-03-10T17:41:39Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-sno-azure

In response to this:

hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-03-10T18:36:37Z

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws
hco-e2e-upgrade-prev-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-aws
hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws

kubevirt-bot · 2023-03-10T18:36:45Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-aws, ci/prow/hco-e2e-upgrade-index-aws, ci/prow/hco-e2e-upgrade-prev-index-aws

In response to this:

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws
hco-e2e-upgrade-prev-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-aws
hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

iholder101 · 2023-03-14T08:03:01Z

/retest-required

kubevirt-bot · 2023-03-14T08:11:02Z

@iholder101: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-hyperconverged-cluster-operator-e2e-k8s-1.23	ca4586f2a4ae018ecbad2e6a3111c76ed3dbb85b	link	true	`/test pull-hyperconverged-cluster-operator-e2e-k8s-1.23`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

iholder101 · 2023-03-15T15:25:23Z

Blocked because of: kubevirt/kubevirt#9434.

Signed-off-by: Itamar Holder <iholder@redhat.com>

This commits takes the necessary steps in order to set up a fully functional no-op virt-launcher mutating webhook + a unit test. This will serve as the skeleton for implementation in further commits. Signed-off-by: Itamar Holder <iholder@redhat.com>

Enforce limits only if a ResourceQuota object on the Pod's namespace and the quota enforces memory / cpu limits. Signed-off-by: Itamar Holder <iholder@redhat.com>

Signed-off-by: Itamar Holder <iholder@redhat.com>

sonarcloud · 2023-03-21T09:49:41Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

hco-bot · 2023-03-21T11:16:54Z

hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure
hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

kubevirt-bot · 2023-03-21T11:17:02Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-azure, ci/prow/hco-e2e-upgrade-prev-index-sno-azure

In response to this:

hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure
hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-03-21T11:32:01Z

hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

kubevirt-bot · 2023-03-21T11:32:05Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-azure, ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-03-21T11:41:37Z

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

kubevirt-bot · 2023-03-21T11:41:40Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-03-21T12:11:01Z

hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

kubevirt-bot · 2023-03-21T12:11:05Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure

In response to this:

hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

iholder101 · 2023-03-21T12:20:27Z

Looks like CI had finally passed :)
Can you PTAL? @nunnatsa @orenc1

openshift-ci · 2023-03-21T12:48:20Z

@iholder101: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-upgrade-index-sno-azure	`e615d7d`	link	false	`/test hco-e2e-upgrade-index-sno-azure`
ci/prow/hco-e2e-upgrade-prev-index-azure	`e615d7d`	link	true	`/test hco-e2e-upgrade-prev-index-azure`
ci/prow/hco-e2e-image-index-azure	`e615d7d`	link	true	`/test hco-e2e-image-index-azure`
ci/prow/hco-e2e-image-index-aws	`e615d7d`	link	true	`/test hco-e2e-image-index-aws`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hco-bot · 2023-03-21T12:57:17Z

hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

kubevirt-bot · 2023-03-21T12:57:21Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws

In response to this:

hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

iholder101 · 2023-03-22T08:23:07Z

can you PTAL? @tiraboschi

tiraboschi · 2023-03-22T08:56:43Z

ignoring roundings on coverage
/override coverage/coveralls

kubevirt-bot · 2023-03-22T08:56:46Z

@tiraboschi: Overrode contexts on behalf of tiraboschi: coverage/coveralls

In response to this:

ignoring roundings on coverage
/override coverage/coveralls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2023-03-22T08:57:09Z

/approve

kubevirt-bot · 2023-03-22T08:57:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tiraboschi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…gurable ratio (kubevirt#2280)" This reverts commit 6b2a0e4. This reverts PR kubevirt#2280 Signed-off-by: stirabos <stirabos@redhat.com>

…gurable ratio (#2280)" (#2346) This reverts commit 6b2a0e4. This reverts PR #2280 Signed-off-by: stirabos <stirabos@redhat.com>

kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 8, 2023

kubevirt-bot requested review from orenc1 and sradco March 8, 2023 10:09

kubevirt-bot added the size/XL label Mar 8, 2023

kubevirt-bot requested review from nunnatsa and tiraboschi March 8, 2023 10:10

iholder101 force-pushed the backport_1.8/kubevirt_enforce_limits branch 2 times, most recently from af3997a to ca4586f Compare March 8, 2023 10:22

tiraboschi closed this Mar 10, 2023

tiraboschi reopened this Mar 10, 2023

iholder101 added 2 commits March 21, 2023 11:47

Refactor: rename mutator to namespace mutator

e844cbc

Signed-off-by: Itamar Holder <iholder@redhat.com>

iholder101 added 3 commits March 21, 2023 11:47

Enforce limits only if a relevant ResourceQuota exists

3a3c864

Enforce limits only if a ResourceQuota object on the Pod's namespace and the quota enforces memory / cpu limits. Signed-off-by: Itamar Holder <iholder@redhat.com>

Unit test: test virt-launcher mutator

b10f9cb

Signed-off-by: Itamar Holder <iholder@redhat.com>

Add documentation

e615d7d

Signed-off-by: Itamar Holder <iholder@redhat.com>

iholder101 force-pushed the backport_1.8/kubevirt_enforce_limits branch from ca4586f to e615d7d Compare March 21, 2023 09:47

tiraboschi approved these changes Mar 22, 2023

View reviewed changes

kubevirt-bot assigned tiraboschi Mar 22, 2023

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2023

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2023

kubevirt-bot merged commit 6b2a0e4 into kubevirt:release-1.8 Mar 22, 2023

tiraboschi mentioned this pull request May 18, 2023

Revert "[release-1.8]: Kubevirt: Enforce limits & requests by a confi… #2346

Merged

11 tasks

kubevirt-bot pushed a commit that referenced this pull request May 19, 2023

Revert "[release-1.8]: Kubevirt: Enforce limits & requests by a confi…

b5518da

…gurable ratio (#2280)" (#2346) This reverts commit 6b2a0e4. This reverts PR #2280 Signed-off-by: stirabos <stirabos@redhat.com>

[release-1.8]: Kubevirt: Enforce limits & requests by a configurable ratio #2280

[release-1.8]: Kubevirt: Enforce limits & requests by a configurable ratio #2280

Conversation

iholder101 commented Mar 8, 2023

iholder101 commented Mar 8, 2023

coveralls commented Mar 8, 2023 • edited Loading

Pull Request Test Coverage Report for Build 4477605810

💛 - Coveralls

hco-bot commented Mar 8, 2023

kubevirt-bot commented Mar 8, 2023

kubevirt-bot commented Mar 10, 2023

tiraboschi commented Mar 10, 2023

hco-bot commented Mar 10, 2023

kubevirt-bot commented Mar 10, 2023

hco-bot commented Mar 10, 2023

kubevirt-bot commented Mar 10, 2023

hco-bot commented Mar 10, 2023

kubevirt-bot commented Mar 10, 2023

hco-bot commented Mar 10, 2023

kubevirt-bot commented Mar 10, 2023

iholder101 commented Mar 14, 2023

kubevirt-bot commented Mar 14, 2023 • edited Loading

iholder101 commented Mar 15, 2023

sonarcloud bot commented Mar 21, 2023

hco-bot commented Mar 21, 2023

kubevirt-bot commented Mar 21, 2023

hco-bot commented Mar 21, 2023

kubevirt-bot commented Mar 21, 2023

hco-bot commented Mar 21, 2023

kubevirt-bot commented Mar 21, 2023

hco-bot commented Mar 21, 2023

kubevirt-bot commented Mar 21, 2023

iholder101 commented Mar 21, 2023

openshift-ci bot commented Mar 21, 2023

hco-bot commented Mar 21, 2023

kubevirt-bot commented Mar 21, 2023

iholder101 commented Mar 22, 2023

tiraboschi commented Mar 22, 2023

kubevirt-bot commented Mar 22, 2023

tiraboschi commented Mar 22, 2023

kubevirt-bot commented Mar 22, 2023

coveralls commented Mar 8, 2023 •

edited

Loading

kubevirt-bot commented Mar 14, 2023 •

edited

Loading