-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose HCO monitoring on plain k8s #2393
Conversation
/hold |
711eae1
to
545d80c
Compare
Tested with kubevirtci and kind clusters. Steps to view metrics and alerts using kubevirtci:
|
8bd43e6
to
0e7a5f8
Compare
Signed-off-by: assafad <aadmi@redhat.com>
0e7a5f8
to
5665934
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Pull Request Test Coverage Report for Build 5337253780
💛 - Coveralls |
Hi @nunnatsa, @machadovilaca, Could you please review this PR? |
/retest |
1 similar comment
/retest |
Great job! |
@assafad: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/override coverage/coveralls |
@nunnatsa: Overrode contexts on behalf of nunnatsa: coverage/coveralls In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hco-e2e-kv-smoke-gcp lane passed /override ci/prow/hco-e2e-kv-smoke-azure |
@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/unhold |
@assafad: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Right now we are creating HCO monitoring-related resources only in OpenShift clusters, and thus HCO metrics and alerts are created and exposed to Prometheus only on these clusters. On plain k8s clusters, HCO only implements metrics, but they are not exposed to Prometheus, and alerts are not created or reconciled at all.
This PR exposes metrics and alerts also on k8s clusters, by enabling the creation and reconciliation of required monitoring-related resources (e.g.
PrometheusRule
,ServiceMonitor
), as long as Prometheus is installed on the cluster.Reviewer Checklist
Jira Ticket: https://issues.redhat.com/browse/CNV-26009
Release note: