Add LiveMigrateIfPossible to cluster level EvictionStrategy #2423
Conversation
Add `LiveMigrateIfPossible` as a valid option for
cluster level EvictionStrategy.
`LiveMigrateIfPossible` will cause a VM to be live migrated,
if possible, otherwise it will be directly evicted in order to complete the node drain with no manual actions.
Since in general we privilege business continuity
of our workload over simplicity of platform upgrades,
`LiveMigrate` will continue being our default value.
This will be consistent with the default value on /spec/workloadUpdateStrategy/workloadUpdateMethods
where we currently have `{"LiveMigrate"}` as our default
and not `{"LiveMigrate", "Evict"}` exactly in order to prevent
unexpected implicit shutdown due to our upgrades.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2219785
Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
kubevirt-bot
added
release-note
Pull Request Test Coverage Report for Build 5476643937
💛 - Coveralls |
|
Kudos, SonarCloud Quality Gate passed!
|
|
hco-e2e-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-azure, ci/prow/okd-hco-e2e-operator-sdk-aws, ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
okd-hco-e2e-upgrade-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-azure, ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@tiraboschi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
What this PR does / why we need it:
Add
LiveMigrateIfPossibleas a valid option forcluster level EvictionStrategy.
LiveMigrateIfPossiblewill cause a VM to be live migrated, if possible, otherwise it will be directly evicted in order to complete the node drain with no manual actions.Since in general we privilege business continuity
of our workload over simplicity of platform upgrades,
LiveMigratewill continue being our default value. This will be consistent with the default value on /spec/workloadUpdateStrategy/workloadUpdateMethods where we currently have{"LiveMigrate"}as our default and not{"LiveMigrate", "Evict"}exactly in order to prevent unexpected implicit shutdown due to our upgrades.Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2219785
Reviewer Checklist
Jira Ticket:
Release note: