Fix node placement for kubevirt-console-plugin #2450

dharmit · 2023-07-27T12:35:35Z

What this PR does / why we need it:
This PR fixes a bug with the placement of kubevirt-console-plugin deployment.

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Jira Ticket:

https://issues.redhat.com/browse/CNV-27446

Release note:

Fix node placement for kubevirt-console-plugin

coveralls · 2023-07-27T12:40:37Z

Pull Request Test Coverage Report for Build 5691088621

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.202%

Totals
Change from base Build 5678411684:	0.0%
Covered Lines:	5023
Relevant Lines:	5827

💛 - Coveralls

hco-bot · 2023-07-27T13:53:23Z

hco-e2e-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-sno-azure
hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

kubevirt-bot · 2023-07-27T13:53:28Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

In response to this:

hco-e2e-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-sno-azure
hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-07-27T14:16:04Z

hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure
hco-e2e-operator-sdk-gcp, hco-e2e-operator-sdk-aws lanes succeeded.
/override ci/prow/hco-e2e-operator-sdk-azure
hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws
okd-hco-e2e-operator-sdk-aws lane succeeded.
/override ci/prow/okd-hco-e2e-operator-sdk-gcp

kubevirt-bot · 2023-07-27T14:16:10Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-azure, ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure, ci/prow/okd-hco-e2e-operator-sdk-gcp

In response to this:

hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure
hco-e2e-operator-sdk-gcp, hco-e2e-operator-sdk-aws lanes succeeded.
/override ci/prow/hco-e2e-operator-sdk-azure
hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws
okd-hco-e2e-operator-sdk-aws lane succeeded.
/override ci/prow/okd-hco-e2e-operator-sdk-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-07-27T14:28:33Z

hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure

kubevirt-bot · 2023-07-27T14:28:37Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure

In response to this:

hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-07-27T15:30:40Z

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

kubevirt-bot · 2023-07-27T15:30:43Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2023-07-27T16:19:22Z

/retest

hco-bot · 2023-07-27T17:48:08Z

hco-e2e-upgrade-operator-sdk-aws, hco-e2e-upgrade-operator-sdk-aws lanes succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-azure

kubevirt-bot · 2023-07-27T17:48:12Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-azure

In response to this:

hco-e2e-upgrade-operator-sdk-aws, hco-e2e-upgrade-operator-sdk-aws lanes succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-07-27T18:01:03Z

hco-e2e-upgrade-operator-sdk-aws, hco-e2e-upgrade-operator-sdk-aws lanes succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-azure

kubevirt-bot · 2023-07-27T18:01:08Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-azure

In response to this:

hco-e2e-upgrade-operator-sdk-aws, hco-e2e-upgrade-operator-sdk-aws lanes succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2023-07-28T07:08:40Z

/retest

dharmit · 2023-07-28T08:23:33Z

@tiraboschi I think something's actually wrong with the functional test I have added:

[FAILED] Timed out after 300.001s.
  The function passed to Eventually failed at /home/prow/go/src/github.com/kubevirt/hyperconverged-cluster-operator/tests/func-tests/node_placement_test.go:197 with:
  Expected
      <map[string]bool | len:7>: {
          "virt-controller": true,
          "kubevirt-console-plugin": false,    <------ I added this in the PR
          "cdi-apiserver": true,
          "cdi-controller": true,
          "cdi-uploadproxy": true,
          "manager": true,
          "virt-api": true,
      }
  not to contain element matching
      <bool>: false
  In [It] at: /home/prow/go/src/github.com/kubevirt/hyperconverged-cluster-operator/tests/func-tests/node_placement_test.go:198 @ 07/28/23 07:23:06.451

The problem is that I haven't got a chance to run the change I added because I can't get an OCP cluster working. I did below twice:

$ export KUBEVIRT_PROVIDER=external
$ make cluster-sync

Both times it failed after a LONG time! I suppose adding more unit tests will be more sensible than adding something in functional test. As for why it failed, it was something related to SSP (I'll grab the logs if it fails for me today as well).

hco-bot · 2023-07-28T08:38:32Z

okd-hco-e2e-upgrade-operator-sdk-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp

kubevirt-bot · 2023-07-28T08:38:36Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp

In response to this:

okd-hco-e2e-upgrade-operator-sdk-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-07-28T08:51:10Z

okd-hco-e2e-upgrade-operator-sdk-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp

kubevirt-bot · 2023-07-28T08:51:15Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp

In response to this:

okd-hco-e2e-upgrade-operator-sdk-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2023-07-28T09:14:36Z

@tiraboschi I think something's actually wrong with the functional test I have added:
[FAILED] Timed out after 300.001s.
  The function passed to Eventually failed at /home/prow/go/src/github.com/kubevirt/hyperconverged-cluster-operator/tests/func-tests/node_placement_test.go:197 with:
  Expected
      <map[string]bool | len:7>: {
          "virt-controller": true,
          "kubevirt-console-plugin": false,    <------ I added this in the PR
          "cdi-apiserver": true,
          "cdi-controller": true,
          "cdi-uploadproxy": true,
          "manager": true,
          "virt-api": true,
      }
  not to contain element matching
      <bool>: false
  In [It] at: /home/prow/go/src/github.com/kubevirt/hyperconverged-cluster-operator/tests/func-tests/node_placement_test.go:198 @ 07/28/23 07:23:06.451 
The problem is that I haven't got a chance to run the change I added because I can't get an OCP cluster working. I did below twice:
$ export KUBEVIRT_PROVIDER=external
$ make cluster-sync
Both times it failed after a LONG time! I suppose adding more unit tests will be more sensible than adding something in functional test. As for why it failed, it was something related to SSP (I'll grab the logs if it fails for me today as well).

Yes, I agree: unit tests are by far less expensive so yes I'd suggest to increase the number of permutations there covering more input cases.

Signed-off-by: Dharmit Shah <shahdharmit@gmail.com>

sonarcloud · 2023-07-28T10:44:51Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

hco-bot · 2023-07-28T11:58:17Z

hco-e2e-upgrade-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-azure
hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure
hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure
hco-e2e-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-sno-azure
hco-e2e-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-azure

kubevirt-bot · 2023-07-28T11:58:22Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-azure, ci/prow/hco-e2e-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-operator-sdk-azure, ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure

In response to this:

hco-e2e-upgrade-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-azure
hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure
hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure
hco-e2e-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-sno-azure
hco-e2e-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-07-28T12:38:21Z

hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure

kubevirt-bot · 2023-07-28T12:38:25Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure

In response to this:

hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-07-28T13:23:43Z

hco-e2e-upgrade-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-azure

kubevirt-bot · 2023-07-28T13:23:47Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-azure

In response to this:

hco-e2e-upgrade-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-07-28T14:07:35Z

@dharmit: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-operator-sdk-azure	`2c7f8e1`	link	true	`/test hco-e2e-operator-sdk-azure`
ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure	`2c7f8e1`	link	true	`/test hco-e2e-upgrade-prev-operator-sdk-azure`
ci/prow/hco-e2e-upgrade-operator-sdk-azure	`2c7f8e1`	link	true	`/test hco-e2e-upgrade-operator-sdk-azure`
ci/prow/hco-e2e-kv-smoke-azure	`2c7f8e1`	link	true	`/test hco-e2e-kv-smoke-azure`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hco-bot · 2023-07-28T14:14:42Z

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

kubevirt-bot · 2023-07-28T14:14:45Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dharmit · 2023-07-28T14:18:48Z

/retest

tiraboschi · 2023-07-28T14:27:20Z

/approve

kubevirt-bot · 2023-07-28T14:27:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tiraboschi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hco-bot · 2023-07-28T15:32:46Z

okd-hco-e2e-upgrade-operator-sdk-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp
okd-hco-e2e-operator-sdk-aws lane succeeded.
/override ci/prow/okd-hco-e2e-operator-sdk-gcp

kubevirt-bot · 2023-07-28T15:32:55Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-operator-sdk-gcp, ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp

In response to this:

okd-hco-e2e-upgrade-operator-sdk-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp
okd-hco-e2e-operator-sdk-aws lane succeeded.
/override ci/prow/okd-hco-e2e-operator-sdk-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

* Fix node placement for kubevirt-console-plugin Signed-off-by: Dharmit Shah <shahdharmit@gmail.com> * Add unit tests for individual NodePlacement elements Signed-off-by: Dharmit Shah <shahdharmit@gmail.com> --------- Signed-off-by: Dharmit Shah <shahdharmit@gmail.com>

* Fix node placement for kubevirt-console-plugin * Add unit tests for individual NodePlacement elements --------- Signed-off-by: Dharmit Shah <shahdharmit@gmail.com>

kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Jul 27, 2023

kubevirt-bot requested review from nunnatsa and orenc1 July 27, 2023 12:35

Fix node placement for kubevirt-console-plugin

fd01da8

Signed-off-by: Dharmit Shah <shahdharmit@gmail.com>

dharmit force-pushed the fix-cnv-27446 branch from b3dd218 to f8d8b32 Compare July 28, 2023 10:39

kubevirt-bot added size/L and removed size/S labels Jul 28, 2023

Add unit tests for individual NodePlacement elements

2c7f8e1

Signed-off-by: Dharmit Shah <shahdharmit@gmail.com>

dharmit force-pushed the fix-cnv-27446 branch from f8d8b32 to 2c7f8e1 Compare July 28, 2023 10:44

tiraboschi approved these changes Jul 28, 2023

View reviewed changes

kubevirt-bot assigned tiraboschi Jul 28, 2023

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2023

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2023

kubevirt-bot merged commit 31a6706 into kubevirt:main Jul 28, 2023
31 checks passed

dharmit deleted the fix-cnv-27446 branch July 28, 2023 15:50

dharmit mentioned this pull request Jul 31, 2023

[release-1.9] Fix node placement for kubevirt-console-plugin (#2450) #2452

Merged

11 tasks

Fix node placement for kubevirt-console-plugin #2450

Fix node placement for kubevirt-console-plugin #2450

Conversation

dharmit commented Jul 27, 2023

coveralls commented Jul 27, 2023 • edited Loading

Pull Request Test Coverage Report for Build 5691088621

💛 - Coveralls

hco-bot commented Jul 27, 2023

kubevirt-bot commented Jul 27, 2023

hco-bot commented Jul 27, 2023

kubevirt-bot commented Jul 27, 2023

hco-bot commented Jul 27, 2023

kubevirt-bot commented Jul 27, 2023

hco-bot commented Jul 27, 2023

kubevirt-bot commented Jul 27, 2023

tiraboschi commented Jul 27, 2023

hco-bot commented Jul 27, 2023

kubevirt-bot commented Jul 27, 2023

hco-bot commented Jul 27, 2023

kubevirt-bot commented Jul 27, 2023

tiraboschi commented Jul 28, 2023

dharmit commented Jul 28, 2023

hco-bot commented Jul 28, 2023

kubevirt-bot commented Jul 28, 2023

hco-bot commented Jul 28, 2023

kubevirt-bot commented Jul 28, 2023

tiraboschi commented Jul 28, 2023

sonarcloud bot commented Jul 28, 2023

hco-bot commented Jul 28, 2023

kubevirt-bot commented Jul 28, 2023

hco-bot commented Jul 28, 2023

kubevirt-bot commented Jul 28, 2023

hco-bot commented Jul 28, 2023

kubevirt-bot commented Jul 28, 2023

openshift-ci bot commented Jul 28, 2023 • edited Loading

hco-bot commented Jul 28, 2023

kubevirt-bot commented Jul 28, 2023

dharmit commented Jul 28, 2023

tiraboschi commented Jul 28, 2023

kubevirt-bot commented Jul 28, 2023

hco-bot commented Jul 28, 2023

kubevirt-bot commented Jul 28, 2023

coveralls commented Jul 27, 2023 •

edited

Loading

openshift-ci bot commented Jul 28, 2023 •

edited

Loading