Do not require nodemediatedDeviceTypes to prevent broken upgrades #2534
Conversation
With kubevirt#2402 we deprecated MediatedDevicesTypes and NodeMediatedDeviceTypes.MediatedDevicesTypes for MediatedDeviceTypes and NodeMediatedDeviceTypes.MediatedDeviceTypes. We also introduced a mutating webhook to handle the conversion. Unfortunately make the two new names mandatory is breaking the validation of the new version of the CRD on OLM upgrades since only the previous names were there with the old CRD. We already have func test covering this area, but they are fooled by the mutating webhook that instead is not involved into the CRD validation process on the OLM side. On the other side, add an additional upgrade lane just for this is probably too expensive. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2241327 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
kubevirt-bot
added
release-note
|
Kudos, SonarCloud Quality Gate passed!
|
Pull Request Test Coverage Report for Build 6382977979
💛 - Coveralls |
|
hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure, ci/prow/okd-hco-e2e-operator-sdk-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-aws, ci/prow/hco-e2e-operator-sdk-sno-azure, ci/prow/okd-hco-e2e-upgrade-operator-sdk-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-azure, ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
1 similar comment
|
/retest |
|
@tiraboschi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@tiraboschi: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
hco-e2e-upgrade-operator-sdk-azure, hco-e2e-upgrade-operator-sdk-azure lanes succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
…en upgrades (kubevirt#2534) With kubevirt#2402 we deprecated MediatedDevicesTypes and NodeMediatedDeviceTypes.MediatedDevicesTypes for MediatedDeviceTypes and NodeMediatedDeviceTypes.MediatedDeviceTypes. We also introduced a mutating webhook to handle the conversion. Unfortunately make the two new names mandatory is breaking the validation of the new version of the CRD on OLM upgrades since only the previous names were there with the old CRD. We already have func test covering this area, but they are fooled by the mutating webhook that instead is not involved into the CRD validation process on the OLM side. On the other side, add an additional upgrade lane just for this is probably too expensive. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2241327 This is a manual cherry-pick of kubevirt#2534 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
…en upgrades (#2534) (#2537) With #2402 we deprecated MediatedDevicesTypes and NodeMediatedDeviceTypes.MediatedDevicesTypes for MediatedDeviceTypes and NodeMediatedDeviceTypes.MediatedDeviceTypes. We also introduced a mutating webhook to handle the conversion. Unfortunately make the two new names mandatory is breaking the validation of the new version of the CRD on OLM upgrades since only the previous names were there with the old CRD. We already have func test covering this area, but they are fooled by the mutating webhook that instead is not involved into the CRD validation process on the OLM side. On the other side, add an additional upgrade lane just for this is probably too expensive. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2241327 This is a manual cherry-pick of #2534 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
What this PR does / why we need it:
With #2402 we deprecated MediatedDevicesTypes and
NodeMediatedDeviceTypes.MediatedDevicesTypes for
MediatedDeviceTypes and NodeMediatedDeviceTypes.MediatedDeviceTypes. We also introduced a mutating webhook to handle the conversion. Unfortunately make the two new names mandatory is breaking the validation of the new version of the CRD on OLM upgrades since only the previous names were there with the old CRD.
We already have func test covering this area,
but they are fooled by the mutating webhook that
instead is not involved into the CRD validation process on the OLM side.
On the other side, add an additional upgrade lane just for this is probably too expensive.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2241327
Reviewer Checklist
Jira Ticket:
Release note: