[CNV-35783] Align node placement between HCO CR and UI Deployments #2643
Conversation
kubevirt-bot
added
release-note
Pull Request Test Coverage Report for Build 7093591035
💛 - Coveralls |
|
okd-hco-e2e-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-operator-sdk-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
okd-hco-e2e-upgrade-operator-sdk-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-operator-sdk-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
hco-e2e-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-azure, ci/prow/hco-e2e-operator-sdk-gcp, ci/prow/hco-e2e-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-operator-sdk-aws lane succeeded. |
|
@tiraboschi: Overrode contexts on behalf of tiraboschi: ci/prow/hco-e2e-operator-sdk-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
kubevirt-bot
added
the
approved
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@tiraboschi: Overrode contexts on behalf of tiraboschi: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold |
pkg/util/own_resources.go
Outdated
| //operatorNs, err := GetOperatorNamespace(logger) | ||
| //if err != nil { | ||
| // return nil, err | ||
| //} | ||
| // operatorNs, err := GetOperatorNamespace(logger) | ||
| // if err != nil { | ||
| // return nil, err | ||
| // } |
orenc1
force-pushed
the
kv_console_proxy_nodeselector_cleanup
branch
3 times, most recently
from
54917fc
to
e80531e
Compare
|
okd-hco-e2e-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-operator-sdk-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-aws, ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-operator-sdk-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…plugin and kubevirt-apiserver-proxy Deployments Currently, a modification in HyperConverged CR's .spec.infra.nodePlacement done while hco-operator is running, is not being synced with kubevirt-console-plugin and kubevirt-apiserver-proxy Deployments. This PR fixes that issue by properly defining the Deployment Handler + adds functional tests for this use case. Signed-off-by: Oren Cohen <ocohen@redhat.com>
orenc1
force-pushed
the
kv_console_proxy_nodeselector_cleanup
branch
from
e80531e
to
b8196a9
Compare
|
hco-e2e-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-operator-sdk-azure, ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure, ci/prow/okd-hco-e2e-upgrade-operator-sdk-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@orenc1: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa, tiraboschi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.10 |
|
@nunnatsa: #2643 failed to apply on top of branch "release-1.10": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…plugin and kubevirt-apiserver-proxy Deployments (kubevirt#2643) Currently, a modification in HyperConverged CR's .spec.infra.nodePlacement done while hco-operator is running, is not being synced with kubevirt-console-plugin and kubevirt-apiserver-proxy Deployments. This PR fixes that issue by properly defining the Deployment Handler + adds functional tests for this use case. Signed-off-by: Oren Cohen <ocohen@redhat.com>
…plugin and kubevirt-apiserver-proxy Deployments (#2643) (#2659) Currently, a modification in HyperConverged CR's .spec.infra.nodePlacement done while hco-operator is running, is not being synced with kubevirt-console-plugin and kubevirt-apiserver-proxy Deployments. This PR fixes that issue by properly defining the Deployment Handler + adds functional tests for this use case. Signed-off-by: Oren Cohen <ocohen@redhat.com>
What this PR does / why we need it:
Currently, a modification in
HyperConvergedCR's.spec.infra.nodePlacementdone whilehco-operatoris running, is not being synced withkubevirt-console-pluginandkubevirt-apiserver-proxyDeployments.This PR fixes that issue by properly defining the Deployment Handler + adds functional tests for this use case.
Reviewer Checklist
Jira Ticket:
Release note: