Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update renovate.json #2652

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Update renovate.json #2652

merged 1 commit into from
Dec 3, 2023

Conversation

lmilbaum
Copy link
Contributor

@lmilbaum lmilbaum commented Dec 1, 2023

What this PR does / why we need it:

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Jira Ticket:

Release note:

Renovate Configuration - Dashboard approval is required for major docker.io/golang version bump

@lmilbaum lmilbaum self-assigned this Dec 1, 2023
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 1, 2023
@lmilbaum
Copy link
Contributor Author

lmilbaum commented Dec 1, 2023

/ok-to-test

@kubevirt-bot kubevirt-bot added size/XS ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Dec 1, 2023
@coveralls
Copy link
Collaborator

coveralls commented Dec 1, 2023 •
edited

Pull Request Test Coverage Report for Build 7067610938

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.478%
Totals Coverage Status
Change from base Build 7056299438: 0.0%
Covered Lines: 5276
Relevant Lines: 6101
💛 - Coveralls

@lmilbaum
Update renovate.json
8ec238e 
Signed-off-by: Liora Milbaum <lmilbaum@redhat.com>
@lmilbaum
Copy link
Contributor Author

lmilbaum commented Dec 2, 2023

/ok-to-test

nunnatsa
nunnatsa approved these changes Dec 3, 2023
View reviewed changes
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2023
@kubevirt-bot kubevirt-bot merged commit d8fa2a4 into main Dec 3, 2023
11 of 12 checks passed
@lmilbaum lmilbaum deleted the lmilbaum-patch-3 branch December 3, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa nunnatsa approved these changes

@orenc1 orenc1 Awaiting requested review from orenc1

@sradco sradco Awaiting requested review from sradco

Assignees

@lmilbaum lmilbaum

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lmilbaum @coveralls @kubevirt-bot @nunnatsa