Revert "Enable KubeVirt CPUManager Policy BetaOptions feature gate (#2616)" #2658
Conversation
…ubevirt#2616)" This reverts commit d423135. Signed-off-by: Ram Lavi <ralavi@redhat.com>
kubevirt-bot
added
dco-signoff: yes
kubevirt-bot
added
release-note
Pull Request Test Coverage Report for Build 7099849904
💛 - Coveralls |
| @@ -32,10 +32,6 @@ import ( | |||
| "sigs.k8s.io/controller-runtime/pkg/log/zap" | |||
| "sigs.k8s.io/controller-runtime/pkg/reconcile" | |||
|
|
|||
| kubevirtcorev1 "kubevirt.io/api/core/v1" | |||
There was a problem hiding this comment.
Please keep the kubevirt imports in a separate group than the hco imports
There was a problem hiding this comment.
As I totally agree with you, this is a semi-automated revert and I'd like it to match the commit it introduced.
Can I keep this here and move the import in a separate PR?
|
hco-e2e-operator-sdk-gcp, hco-e2e-operator-sdk-aws lanes succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/test hco-e2e-operator-sdk-sno-aws hco-e2e-operator-sdk-sno-azure hco-e2e-upgrade-operator-sdk-sno-aws hco-e2e-upgrade-operator-sdk-sno-azure hco-e2e-upgrade-prev-operator-sdk-aws hco-e2e-upgrade-prev-operator-sdk-azure |
|
@nunnatsa: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-operator-sdk-sno-aws, hco-e2e-operator-sdk-sno-aws, hco-e2e-operator-sdk-sno-aws lanes succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-operator-sdk-sno-aws, hco-e2e-operator-sdk-sno-aws, hco-e2e-operator-sdk-sno-aws, hco-e2e-operator-sdk-sno-aws, hco-e2e-operator-sdk-sno-aws lanes succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-hyperconverged-cluster-operator-e2e-k8s-1.26-centos9 |
|
@nunnatsa: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test hco-e2e-upgrade-operator-sdk-sno-azure |
|
@RamLavi: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@RamLavi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded. |
|
@tiraboschi: Overrode contexts on behalf of tiraboschi: ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR reverts commit d423135 (#2616), in light of recent discussions made regarding how FeatureGates should be propagated by HCO.
Reviewer Checklist
Jira Ticket:
Release note: