Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor recording-rules and alerts code #2706

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Refactor recording-rules and alerts code #2706

merged 1 commit into from
Feb 5, 2024

Conversation

avlitman
Copy link
Collaborator

@avlitman avlitman commented Dec 31, 2023 •
edited
Loading

What this PR does / why we need it:
Following the work started in kubevirt/kubevirt#10044 , and according to the kubevirt/community#219 proposal, this PR refactors monitoring recording rules and alerts
Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly
Jira-Ticket: https://issues.redhat.com/browse/CNV-36617

Release note:

Refactor recording-rules and alerts code.

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 31, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 31, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Dec 31, 2023
@kubevirt-bot kubevirt-bot added size/L release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 31, 2023
@avlitman avlitman force-pushed the refactor-recording-rules-code branch from b4679d0 to 1fd5929 Compare December 31, 2023 20:26
@kubevirt-bot kubevirt-bot added size/XL needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/L labels Dec 31, 2023
@avlitman avlitman force-pushed the refactor-recording-rules-code branch from 1fd5929 to 71fb359 Compare January 3, 2024 11:58
@kubevirt-bot kubevirt-bot added size/L and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL labels Jan 3, 2024
@avlitman avlitman force-pushed the refactor-recording-rules-code branch 2 times, most recently from 5a058f3 to 8490c28 Compare January 3, 2024 12:43
@avlitman avlitman force-pushed the refactor-recording-rules-code branch 3 times, most recently from d7c8032 to 82b01e0 Compare January 3, 2024 13:20
@avlitman avlitman force-pushed the refactor-recording-rules-code branch from 82b01e0 to c3d8106 Compare January 3, 2024 13:53
@avlitman avlitman changed the title [wip] Refactor recording-rules code Refactor recording-rules code Jan 3, 2024
@avlitman avlitman marked this pull request as ready for review January 3, 2024 13:57
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 3, 2024
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2024
@avlitman
Copy link
Collaborator Author

/retest

2 similar comments
@avlitman
Copy link
Collaborator Author

avlitman commented Feb 1, 2024

/retest

@avlitman
Copy link
Collaborator Author

avlitman commented Feb 1, 2024

/retest

@machadovilaca
Copy link
Member

/approve

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2024
@nunnatsa
Copy link
Collaborator

nunnatsa commented Feb 1, 2024

tiny coverage depredation
/override coverage/coveralls

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: coverage/coveralls

In response to this:

tiny coverage depredation
/override coverage/coveralls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@avlitman
Refactor recording-rules and alerts code
266eeee 
Signed-off-by: avlitman <alitman@redhat.com>

Bump github.com/machadovilaca/operator-observability

Signed-off-by: João Vilaça <jvilaca@redhat.com>

Update prometheus rules controller

Signed-off-by: João Vilaça <jvilaca@redhat.com>

Update metrics docs

Signed-off-by: João Vilaça <jvilaca@redhat.com>

Update hack/prom-rule-ci/rule-spec-dumper

Signed-off-by: João Vilaça <jvilaca@redhat.com>

delete cluster_operator.go and fix tools location

Signed-off-by: avlitman <alitman@redhat.com>
@avlitman avlitman force-pushed the refactor-recording-rules-code branch from 425e27f to 266eeee Compare February 4, 2024 10:20
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
1.4% Duplication on New Code

See analysis details on SonarCloud

@avlitman
Copy link
Collaborator Author

avlitman commented Feb 4, 2024

/retest

1 similar comment
@avlitman
Copy link
Collaborator Author

avlitman commented Feb 4, 2024

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 4, 2024 •
edited
Loading

@avlitman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure 266eeee link false /test hco-e2e-upgrade-prev-operator-sdk-sno-azure
ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure 266eeee link false /test hco-e2e-upgrade-operator-sdk-sno-azure
ci/prow/hco-e2e-kv-smoke-azure 266eeee link true /test hco-e2e-kv-smoke-azure
ci/prow/hco-e2e-upgrade-operator-sdk-azure 266eeee link true /test hco-e2e-upgrade-operator-sdk-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nunnatsa
Copy link
Collaborator

nunnatsa commented Feb 5, 2024

/unhold
/override coverage/coveralls

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2024
@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: coverage/coveralls

In response to this:

/unhold
/override coverage/coveralls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator

nunnatsa commented Feb 5, 2024

/override-bot

@hco-bot
Copy link
Collaborator

hco-bot commented Feb 5, 2024

hco-e2e-upgrade-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-azure
hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure, ci/prow/hco-e2e-upgrade-operator-sdk-azure

In response to this:

hco-e2e-upgrade-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-azure
hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator

nunnatsa commented Feb 5, 2024

hco-e2e-upgrade-operator-sdk-sno-aws lane passed
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

hco-e2e-upgrade-prev-operator-sdk-sno-aws lane passed
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

/approve

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

In response to this:

hco-e2e-upgrade-operator-sdk-sno-aws lane passed
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

hco-e2e-upgrade-prev-operator-sdk-sno-aws lane passed
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machadovilaca, nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [machadovilaca,nunnatsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nunnatsa
Copy link
Collaborator

nunnatsa commented Feb 5, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024
@kubevirt-bot kubevirt-bot merged commit 29b47d4 into kubevirt:main Feb 5, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machadovilaca machadovilaca machadovilaca approved these changes

@tiraboschi tiraboschi Awaiting requested review from tiraboschi

@orenc1 orenc1 Awaiting requested review from orenc1

@sradco sradco Awaiting requested review from sradco

Assignees

@sradco sradco

@machadovilaca machadovilaca

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@avlitman @kubevirt-bot @coveralls @hco-bot @sradco @machadovilaca @nunnatsa