Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create images.tmp.env #2708

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Create images.tmp.env #2708

merged 1 commit into from
Jan 2, 2024

Conversation

lmilbaum
Copy link
Contributor

@lmilbaum lmilbaum commented Jan 1, 2024

What this PR does / why we need it:

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Jira Ticket:

Release note:

Temp images.env file to be used by renovate

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 1, 2024
@lmilbaum
Copy link
Contributor Author

lmilbaum commented Jan 1, 2024

No idea why sanity checks are failing

nunnatsa
nunnatsa reviewed Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we have a comment with the version for each line?

@coveralls
Copy link
Collaborator

coveralls commented Jan 2, 2024 •
edited

Pull Request Test Coverage Report for Build 7388530423

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.45%
Totals Coverage Status
Change from base Build 7385754623: 0.0%
Covered Lines: 5302
Relevant Lines: 6133
💛 - Coveralls

@lmilbaum
Copy link
Contributor Author

lmilbaum commented Jan 2, 2024

Shouldn't we have a comment with the version for each line?

We should. TBH, it is going to be a bit of challenge for me to identify the right version per line. It doesn't look that straight forward.

@lmilbaum lmilbaum force-pushed the lmilbaum-patch-1 branch 2 times, most recently from 38bf5ab to f1dbabd Compare January 2, 2024 12:39
@nunnatsa
Copy link
Collaborator

nunnatsa commented Jan 2, 2024

It doesn't look that straight forward.

OK - I'll add relevant inline comments

nunnatsa
nunnatsa reviewed Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added inline comments with repo addresses and versions

deploy/images.tmp.env Outdated Show resolved Hide resolved
deploy/images.tmp.env Outdated Show resolved Hide resolved
deploy/images.tmp.env Outdated Show resolved Hide resolved
deploy/images.tmp.env Outdated Show resolved Hide resolved
deploy/images.tmp.env Outdated Show resolved Hide resolved
deploy/images.tmp.env Outdated Show resolved Hide resolved
deploy/images.tmp.env Outdated Show resolved Hide resolved
deploy/images.tmp.env Outdated Show resolved Hide resolved
deploy/images.tmp.env Outdated Show resolved Hide resolved
deploy/images.tmp.env Show resolved Hide resolved
@lmilbaum
Create images.tmp.env
2a3233f 
Signed-off-by: Liora Milbaum <lmilbaum@redhat.com>
@lmilbaum lmilbaum requested a review from nunnatsa January 2, 2024 17:12
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@nunnatsa
Copy link
Collaborator

nunnatsa commented Jan 2, 2024

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2024
@kubevirt-bot kubevirt-bot merged commit 037c532 into main Jan 2, 2024
15 checks passed
@nunnatsa nunnatsa deleted the lmilbaum-patch-1 branch January 2, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sradco sradco Awaiting requested review from sradco

@tiraboschi tiraboschi Awaiting requested review from tiraboschi

@orenc1 orenc1 Awaiting requested review from orenc1

@nunnatsa nunnatsa Awaiting requested review from nunnatsa

Assignees

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lmilbaum @coveralls @nunnatsa @kubevirt-bot