[release 1.11] Bump AAQ to v1.1.4, and rename the component name #2790
Conversation
kubevirt-bot
added
release-note
AAQ now called "application-aware-quota". One of the configuration field name also renamed. This PR changes the import path of AAQ to the new path, bumps it to v1.1.4, and rename the component and the `enableClusterAppsResourceQuota` field to `allowApplicationAwareClusterResourceQuota`, to match the rename in AAQ. Also, added a new feature gate, "enableApplicationAwareQuota", to enable/disable AAQ. Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
Pull Request Test Coverage Report for Build 7766994894
💛 - Coveralls |
|
|
hco-e2e-operator-sdk-gcp, hco-e2e-operator-sdk-aws lanes succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-azure, ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-azure, ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
hco-e2e-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@nunnatsa: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -461,6 +462,12 @@ type HyperConvergedFeatureGates struct { | |||
| // +kubebuilder:default=false | |||
| // +default=false | |||
| AlignCPUs *bool `json:"alignCPUs,omitempty"` | |||
|
|
|||
| // EnableApplicationAwareQuota if true, enable the Application Aware Quota feature | |||
There was a problem hiding this comment.
| // EnableApplicationAwareQuota if true, enable the Application Aware Quota feature | |
| // EnableApplicationAwareQuota if true, enables the Application Aware Quota feature |
There was a problem hiding this comment.
Will fixed in future PR
| @@ -204,7 +204,7 @@ var _ = Describe("AAQ tests", func() { | |||
| }) | |||
|
|
|||
| It("should create AAQ if the applicationAwareConfig field exists", func() { | |||
| hco.Spec.ApplicationAwareConfig = &v1beta1.ApplicationAwareConfigurations{} | |||
| hco.Spec.FeatureGates.EnableApplicationAwareQuota = ptr.To(true) | |||
There was a problem hiding this comment.
the test case description doesn't match what we actually checking (applicationAwareConfig vs. the FG)
There was a problem hiding this comment.
Will fixed in future PR
| applicationAwareConfig: {} | ||
| ``` | ||
| ## Configure Application Aware Quota (AAQ) | ||
| To enable the AAQ feature, add the `spec.featureGates.enableApplicationAwareQuota` field to `true`. See [featureGates](#enableapplicationawarequota-feature-gate) above. |
There was a problem hiding this comment.
| To enable the AAQ feature, add the `spec.featureGates.enableApplicationAwareQuota` field to `true`. See [featureGates](#enableapplicationawarequota-feature-gate) above. | |
| To enable the AAQ feature, set the `spec.featureGates.enableApplicationAwareQuota` field to `true`. See [featureGates](#enableapplicationawarequota-feature-gate) above. |
|
|
||
| To configure AAQ, set the fields of the `applicationAwareConfig` object in the HyperConverged resource's spec. The | ||
| `applicationAwareConfig` object contains several fields: | ||
| * `vmiCalcConfigName` - determine how resource allocation will be done with ApplicationsResourceQuota. | ||
| * `vmiCalcConfigName` - determine how resource allocation will be done with ApplicationResourceQuota. |
There was a problem hiding this comment.
| * `vmiCalcConfigName` - determine how resource allocation will be done with ApplicationResourceQuota. | |
| * `vmiCalcConfigName` - determines how resource allocation will be done with ApplicationResourceQuota. |
| @@ -1141,7 +1142,7 @@ To configure AAQ, set the fields of the `applicationAwareConfig` object in the H | |||
| resource allocation. | |||
| * `namespaceSelector` - determines in which namespaces scheduling gate will be added to pods. This field is a standard | |||
| kubernetes selector. | |||
| * `enableClusterAppsResourceQuota` (default = false) - set to true, to allows creation and management of ClusterAppsResourceQuota | |||
| * `allowApplicationAwareClusterResourceQuota` (default = false) - set to true, to allows creation and management of ClusterAppsResourceQuota | |||
There was a problem hiding this comment.
the old name is still there
| * `allowApplicationAwareClusterResourceQuota` (default = false) - set to true, to allows creation and management of ClusterAppsResourceQuota | |
| * `allowApplicationAwareClusterResourceQuota` (default = false) - set to true, to allow creation and management of ApplicationAwareClusterResourceQuota. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: orenc1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Done in #2792 |
What this PR does / why we need it
AAQ now called "application-aware-quota". One of the configuration field name also renamed.
This PR changes the import path of AAQ to the new path, bumps it to v1.1.4, and rename the component and the
enableClusterAppsResourceQuotafield toallowApplicationAwareClusterResourceQuota, to match the rename in AAQ.Also, added a new feature gate, "enableApplicationAwareQuota", to enable/disable AAQ.
Reviewer Checklist
Jira Ticket
Release note: