Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssp: Remove tekton from SSP object and documentation #2881

Merged
merged 1 commit into from
Apr 15, 2024
Merged

ssp: Remove tekton from SSP object and documentation #2881

merged 1 commit into from
Apr 15, 2024

Conversation

akrejcir
Copy link
Contributor

What this PR does / why we need it:
SSP operator does not deploy tekton tasks and pipelines anymore. This change removes code that sets the feature gate.

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Jira Ticket:

https://issues.redhat.com/browse/CNV-29461

Release note:

Feature gate "deployTektonTaskResources" is deprecated and ignored.

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Apr 12, 2024
@akrejcir
ssp: Remove tekton from SSP object and documentation
42562e2 
SSP operator does not deploy tekton anymore.
This change removes code that sets the feature gate.

Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Apr 12, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

@akrejcir
Copy link
Contributor Author

/cc @0xFelix @ksimon1

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8663016846

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 86.126%
Totals Coverage Status
Change from base Build 8633275791: 0.02%
Covered Lines: 5463
Relevant Lines: 6343
💛 - Coveralls

0xFelix
0xFelix reviewed Apr 12, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add a short explanation why the field is ignored? SSP does no longer deploy Tekton resources. This field is ignored.?

@hco-bot
Copy link
Collaborator

hco-bot commented Apr 12, 2024

hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

In response to this:

hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Apr 12, 2024

hco-e2e-upgrade-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-aws
hco-e2e-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-gcp
hco-e2e-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-aws
hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-aws, ci/prow/hco-e2e-operator-sdk-gcp, ci/prow/hco-e2e-upgrade-operator-sdk-aws, ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws

In response to this:

hco-e2e-upgrade-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-aws
hco-e2e-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-gcp
hco-e2e-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-aws
hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Apr 12, 2024

hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws
hco-e2e-operator-sdk-sno-azure lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-sno-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-aws, ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws

In response to this:

hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws
hco-e2e-operator-sdk-sno-azure lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Apr 12, 2024

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@0xFelix
Copy link
Member

0xFelix commented Apr 15, 2024

/retest-required

@nunnatsa
Copy link
Collaborator

/lgtm
/retest

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2024
@nunnatsa
Copy link
Collaborator

/retest

@nunnatsa
Copy link
Collaborator

/test okd-hco-e2e-operator-sdk-aws

@kubevirt-bot
Copy link
Contributor

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build-hco-test-utils-image
  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.28
  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.29

Use /test all to run the following jobs that were automatically triggered:

  • pull-hyperconverged-cluster-operator-e2e-k8s-1.28
  • pull-hyperconverged-cluster-operator-e2e-k8s-1.29

In response to this:

/test okd-hco-e2e-operator-sdk-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator

/test okd-hco-e2e-upgrade-operator-sdk-aws
/test okd-hco-e2e-operator-sdk-aws

@kubevirt-bot
Copy link
Contributor

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build-hco-test-utils-image
  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.28
  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.29

Use /test all to run the following jobs that were automatically triggered:

  • pull-hyperconverged-cluster-operator-e2e-k8s-1.28
  • pull-hyperconverged-cluster-operator-e2e-k8s-1.29

In response to this:

/test okd-hco-e2e-upgrade-operator-sdk-aws
/test okd-hco-e2e-operator-sdk-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 15, 2024 •
edited
Loading

@akrejcir: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-operator-sdk-aws 42562e2 link true /test hco-e2e-operator-sdk-aws
ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws 42562e2 link false /test hco-e2e-upgrade-operator-sdk-sno-aws
ci/prow/hco-e2e-upgrade-operator-sdk-aws 42562e2 link true /test hco-e2e-upgrade-operator-sdk-aws
ci/prow/hco-e2e-operator-sdk-sno-aws 42562e2 link false /test hco-e2e-operator-sdk-sno-aws
ci/prow/hco-e2e-operator-sdk-gcp 42562e2 link true /test hco-e2e-operator-sdk-gcp
ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws 42562e2 link true /test hco-e2e-upgrade-prev-operator-sdk-aws
ci/prow/hco-e2e-kv-smoke-azure 42562e2 link true /test hco-e2e-kv-smoke-azure
ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp 42562e2 link true /test okd-hco-e2e-upgrade-operator-sdk-gcp
ci/prow/okd-hco-e2e-operator-sdk-gcp 42562e2 link true /test okd-hco-e2e-operator-sdk-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hco-bot
Copy link
Collaborator

hco-bot commented Apr 15, 2024

okd-hco-e2e-upgrade-operator-sdk-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp
okd-hco-e2e-operator-sdk-aws lane succeeded.
/override ci/prow/okd-hco-e2e-operator-sdk-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-operator-sdk-gcp, ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp

In response to this:

okd-hco-e2e-upgrade-operator-sdk-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp
okd-hco-e2e-operator-sdk-aws lane succeeded.
/override ci/prow/okd-hco-e2e-operator-sdk-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2024
@kubevirt-bot kubevirt-bot merged commit 35f75dc into kubevirt:main Apr 15, 2024
36 checks passed
akrejcir added a commit to akrejcir/hyperconverged-cluster-operator that referenced this pull request Apr 26, 2024
@akrejcir
Revert "ssp: Remove tekton from SSP object and documentation (kubevir…
8b74594 
…t#2881)"

This reverts commit 35f75dc.

Most of the change should not be in the current version.
The tekton feature gate should still be propagated to SSP.

Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
akrejcir added a commit to akrejcir/hyperconverged-cluster-operator that referenced this pull request Apr 29, 2024
@akrejcir
Revert "ssp: Remove tekton from SSP object and documentation (kubevir…
221c8e5 
…t#2881)"

This reverts commit 35f75dc.

Most of the change should not be in the current version.
The tekton feature gate should still be propagated to SSP.

Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
akrejcir added a commit to akrejcir/hyperconverged-cluster-operator that referenced this pull request May 9, 2024
@akrejcir
Revert "ssp: Remove tekton from SSP object and documentation (kubevir…
8c22b38 
…t#2881)"

This reverts commit 35f75dc.

Most of the change should not be in the current version.
The tekton feature gate should still be propagated to SSP.

Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
akrejcir added a commit to akrejcir/hyperconverged-cluster-operator that referenced this pull request May 10, 2024
@akrejcir
Revert "ssp: Remove tekton from SSP object and documentation (kubevir…
090c777 
…t#2881)"

This reverts commit 35f75dc.

Most of the change should not be in the current version.
The tekton feature gate should still be propagated to SSP.

Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix left review comments

@orenc1 orenc1 Awaiting requested review from orenc1

@sradco sradco Awaiting requested review from sradco

@ksimon1 ksimon1 Awaiting requested review from ksimon1

Assignees

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@akrejcir @coveralls @hco-bot @kubevirt-bot @0xFelix @nunnatsa