Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: AAQ default namespace selector #2931

Merged
merged 1 commit into from
May 2, 2024
Merged

docs: AAQ default namespace selector #2931

merged 1 commit into from
May 2, 2024

Conversation

iholder101
Copy link
Contributor

What this PR does / why we need it:
Add AAQ docs regarding its default namespace selector.
This is reflecting the changes done in kubevirt/application-aware-quota#59.

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Jira Ticket:

https://issues.redhat.com/browse/CNV-39880

Release note:

docs: AAQ default namespace selector

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 2, 2024
@kubevirt-bot kubevirt-bot requested review from orenc1 and sradco May 2, 2024 13:50
@iholder101
Copy link
Contributor Author

FYI @Barakmor1 @kbidarkar @acardace

@coveralls
Copy link
Collaborator

coveralls commented May 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8925879763

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.837%
Totals Coverage Status
Change from base Build 8924842871: 0.0%
Covered Lines: 5200
Relevant Lines: 6058
💛 - Coveralls

@nunnatsa
Copy link
Collaborator

nunnatsa commented May 2, 2024

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2024
@Barakmor1
Copy link
Member

/hold
Maybe lets mentioned the spec.nodeName limitation

Please feel free to unhlod.

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2024
@kubevirt-bot kubevirt-bot added size/S and removed lgtm Indicates that a PR is ready to be merged. size/XS labels May 2, 2024
@iholder101
Copy link
Contributor Author

/hold Maybe lets mentioned the spec.nodeName limitation

Please feel free to unhlod.

Done!
/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2024
@Barakmor1
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2024
@iholder101
docs: AAQ default namespace selector
7d26491 
Signed-off-by: Itamar Holder <iholder@redhat.com>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label May 2, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Barakmor1
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2024
@kubevirt-bot kubevirt-bot merged commit a98cb26 into kubevirt:main May 2, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orenc1 orenc1 Awaiting requested review from orenc1

@sradco sradco Awaiting requested review from sradco

Assignees

@nunnatsa nunnatsa

@Barakmor1 Barakmor1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iholder101 @coveralls @nunnatsa @kubevirt-bot @Barakmor1