Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Aviv and Assaf as approvers of HCO #2956

Merged
merged 1 commit into from
May 8, 2024
Merged

Adding Aviv and Assaf as approvers of HCO #2956

merged 1 commit into from
May 8, 2024

Conversation

orenc1
Copy link
Collaborator

@orenc1 orenc1 commented May 8, 2024

What this PR does / why we need it:

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Jira Ticket:

NONE

Release note:

NONE

@orenc1
Adding Aviv and Assaf as approvers of HCO
a8a98cf 
Signed-off-by: Oren Cohen <ocohen@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 8, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9001735120

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 85.837%
Files with Coverage Reduction New Missed Lines %
controllers/operands/operandHandler.go 1 86.18%
Totals Coverage Status
Change from base Build 9000371846: -0.02%
Covered Lines: 5200
Relevant Lines: 6058
💛 - Coveralls

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2024
@tiraboschi
Copy link
Member

/lgtm

@orenc1
Copy link
Collaborator Author

orenc1 commented May 8, 2024

/retest

@sradco
Copy link
Collaborator

sradco commented May 8, 2024

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sradco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024
@orenc1
Copy link
Collaborator Author

orenc1 commented May 8, 2024

/test okd-images

@kubevirt-bot
Copy link
Contributor

@orenc1: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build-hco-test-utils-image
  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.29
  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.30

Use /test all to run the following jobs that were automatically triggered:

  • pull-hyperconverged-cluster-operator-e2e-k8s-1.29
  • pull-hyperconverged-cluster-operator-e2e-k8s-1.30

In response to this:

/test okd-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit be160c9 into kubevirt:main May 8, 2024
15 checks passed
@orenc1 orenc1 deleted the aviv_assaf_hco_approvers branch May 8, 2024 21:14
@orenc1
Copy link
Collaborator Author

orenc1 commented May 9, 2024

/cherry-pick release-1.12
/cherry-pick release-1.11

@kubevirt-bot
Copy link
Contributor

@orenc1: new pull request created: #2960

In response to this:

/cherry-pick release-1.12
/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot mentioned this pull request May 9, 2024
Merged
@orenc1
Copy link
Collaborator Author

orenc1 commented May 9, 2024

/cherry-pick release-1.11

@kubevirt-bot
Copy link
Contributor

@orenc1: new pull request created: #2961

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot mentioned this pull request May 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi tiraboschi approved these changes

@machadovilaca machadovilaca Awaiting requested review from machadovilaca

@sradco sradco Awaiting requested review from sradco

Assignees

@tiraboschi tiraboschi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@orenc1 @coveralls @tiraboschi @sradco @kubevirt-bot