[release-2.3] Set default value (BlockUninstallIfWorkloadsExist) for UninstallStrategy on Kubevirt #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egy on Kubevirt github.com/kubevirt/kubevirt/pull/2976 introduced uninstall strategies for the virt-operator. This PR will: - set BlockUninstallIfWorkloadsExist as the UninstallStrategy creating Kubevirt CR - set UninstallStrategy=BlockUninstallIfWorkloadsExist if unset on an existing Kubevirt CR - test it Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
kubevirt-bot
added
release-note
nunnatsa
approved these changes
Feb 18, 2020
orenc1
approved these changes
Feb 18, 2020
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: orenc1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
test failed due to not being able to pull the |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #451
/assign tiraboschi