Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump KUBEVIRT to v0.30.0-rc.1 #608

Closed
wants to merge 2 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

Bump KUBEVIRT to v0.30.0-rc.1
Executed by HCO Release-Bumper Bot.

Bump KUBEVIRT to v0.30.0-rc.1

@kubevirt-bot kubevirt-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 31, 2020
@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow Manage kubevirt CR from sdk generated code #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label May 31, 2020
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 31, 2020
@openshift-ci-robot
Copy link
Collaborator

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@kubevirt-bot
Copy link
Contributor

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign orenc1
You can assign the PR to them by writing /assign @orenc1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@orenc1
Copy link
Collaborator

orenc1 commented May 31, 2020

/ok-to-test

@kubevirt-bot kubevirt-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 31, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 31, 2020
@orenc1
Copy link
Collaborator

orenc1 commented May 31, 2020

@danielBelenky @tiraboschi kubevirt is degraded because of:

 Available	False	KubeVirt is not available: An error occurred during deployment: unable to create config map &ConfigMap{ObjectMeta:{kubevirt-cpu-plugin-configmap  kubevirt-hyperconverged    0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[app.kubernetes.io/managed-by:kubevirt-operator] map[kubevirt.io/install-strategy-identifier:020973b690602ac48140963e236ea950769a19f6 kubevirt.io/install-strategy-registry:docker.io/kubevirt kubevirt.io/install-strategy-version:v0.30.0-rc.1] [] []  []},Data:map[string]string{cpu-plugin-configmap.yaml: obsoleteCPUs:
- "486"
- "pentium"
- "pentium2"
- "pentium3"
- "pentiumpro"
- "coreduo"
- "n270"
- "core2duo"
- "Conroe"
- "athlon"
- "phenom"
minCPU: "Penryn",},BinaryData:map[string][]byte{},}: configmaps "kubevirt-cpu-plugin-configmap" already exists 

@orenc1
Copy link
Collaborator

orenc1 commented May 31, 2020

/retest

@danielBelenky
Copy link
Contributor

@danielBelenky @tiraboschi kubevirt is degraded because of:

 Available	False	KubeVirt is not available: An error occurred during deployment: unable to create config map &ConfigMap{ObjectMeta:{kubevirt-cpu-plugin-configmap  kubevirt-hyperconverged    0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[app.kubernetes.io/managed-by:kubevirt-operator] map[kubevirt.io/install-strategy-identifier:020973b690602ac48140963e236ea950769a19f6 kubevirt.io/install-strategy-registry:docker.io/kubevirt kubevirt.io/install-strategy-version:v0.30.0-rc.1] [] []  []},Data:map[string]string{cpu-plugin-configmap.yaml: obsoleteCPUs:
- "486"
- "pentium"
- "pentium2"
- "pentium3"
- "pentiumpro"
- "coreduo"
- "n270"
- "core2duo"
- "Conroe"
- "athlon"
- "phenom"
minCPU: "Penryn",},BinaryData:map[string][]byte{},}: configmaps "kubevirt-cpu-plugin-configmap" already exists 

This error is because we have node lablerrer code in virt-handler and in the standalone code... I thought that it was reverted already... @omeryahud

@orenc1
Copy link
Collaborator

orenc1 commented May 31, 2020

This error is because we have node lablerrer code in virt-handler and in the standalone code... I thought that it was reverted already... @omeryahud

NodeLabeller is still part of virt-handler in tag v0.30.0-rc.1
https://github.com/kubevirt/kubevirt/tree/v0.30.0-rc.1/pkg/virt-handler/node-labeller

@omeryahud
Copy link
Contributor

node-labeller was reverted from kubevirt in the release-0.29 branch
kubevirt/kubevirt#3462

@orenc1
Copy link
Collaborator

orenc1 commented May 31, 2020

node-labeller was reverted from kubevirt in the release-0.29 branch
kubevirt/kubevirt#3462

Then how did it popped out in v0.30.0-rc.1 again?
https://github.com/kubevirt/kubevirt/blob/v0.30.0-rc.1/cmd/virt-launcher/BUILD.bazel#L64

@orenc1
Copy link
Collaborator

orenc1 commented Jun 1, 2020

/rebase

1 similar comment
@orenc1
Copy link
Collaborator

orenc1 commented Jun 2, 2020

/rebase

web-flow and others added 2 commits June 2, 2020 07:26
Signed-off-by: hco_bump_bot <hco_bump_bot@redhat.com>
Signed-off-by: orenc1 (Rebase PR Action) <orenc1@users.noreply.github.com>
@github-actions github-actions bot force-pushed the bump_KUBEVIRT_v0.30.0-rc.1 branch from 6c23e87 to 15af91d Compare June 2, 2020 07:26
@kubevirt-bot
Copy link
Contributor

@github-actions[bot]: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-hyperconverged-cluster-operator-e2e-ocp-4.3 15af91d link /test pull-hyperconverged-cluster-operator-e2e-ocp-4.3
pull-hyperconverged-cluster-operator-e2e-k8s-1.15.1 15af91d link /test pull-hyperconverged-cluster-operator-e2e-k8s-1.15.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Collaborator

@github-actions[bot]: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/hco-e2e-aws 15af91d link /test hco-e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tiraboschi
Copy link
Member

waiting for #615

@tiraboschi tiraboschi closed this Jun 3, 2020
@tiraboschi tiraboschi deleted the bump_KUBEVIRT_v0.30.0-rc.1 branch June 3, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants