Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump KUBEVIRT_VMWARE v2.0.0-5 #678

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Bump KUBEVIRT_VMWARE v2.0.0-5 #678

merged 1 commit into from
Jul 2, 2020

Conversation

pkliczewski
Copy link
Contributor

@pkliczewski pkliczewski commented Jul 2, 2020 •
edited
Loading

Bump KUBEVIRT_VMWARE to v2.0.0-5

Release note:

Bump KUBEVIRT_VMWARE to v2.0.0-5

Signed-off-by: Piotr Kliczewski piotr.kliczewski@gmail.com

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 2, 2020
@kubevirt-bot kubevirt-bot requested review from djzager and rwsu July 2, 2020 08:06
@kubevirt-bot kubevirt-bot added size/XS release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 2, 2020
@pkliczewski
Copy link
Contributor Author

Please backport it to v2.4 branch. This version contains a fix for a blocker bug

@ovirt-infra
Copy link

All tests passed

@tiraboschi
Copy link
Member

Please backport it to v2.4 branch. This version contains a fix for a blocker bug

After this change you have to explicitly run hack/build-manifests.sh to regenerate all the manifest files.

tiraboschi
tiraboschi requested changes Jul 2, 2020
View reviewed changes
Copy link
Member

@tiraboschi tiraboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this change you have to explicitly run hack/build-manifests.sh to regenerate all the manifest files.

@pkliczewski
Bump KUBEVIRT_VMWARE v2.0.0-5
6268a26 
Bump KUBEVIRT_VMWARE to v2.0.0-5

**Release note**:
```release-note
Bump KUBEVIRT_VMWARE to v2.0.0-5
```

Signed-off-by: Piotr Kliczewski <piotr.kliczewski@gmail.com>
@pkliczewski pkliczewski force-pushed the bump_KUBEVIRT_VMWARE_v2.0.0-5 branch from efa6bbc to 6268a26 Compare July 2, 2020 08:30
@pkliczewski
Copy link
Contributor Author

pkliczewski commented Jul 2, 2020 •
edited
Loading

After this change you have to explicitly run hack/build-manifests.sh to regenerate all the manifest files.

@tiraboschi PR updated.

@ovirt-infra
Copy link

All tests passed

@pkliczewski
Copy link
Contributor Author

/test hco-e2e-upgrade-aws

@kubevirt-bot
Copy link
Contributor

@pkliczewski: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-upgrade-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2020
@tiraboschi
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2020
@kubevirt-bot kubevirt-bot merged commit a96e371 into kubevirt:master Jul 2, 2020
nunnatsa pushed a commit to nunnatsa/hyperconverged-cluster-operator that referenced this pull request Jul 2, 2020
@pkliczewski @nunnatsa
[Release 2.4] Bump KUBEVIRT_VMWARE v2.0.0-5 (kubevirt#678)
4eecf99 
Bump KUBEVIRT_VMWARE to v2.0.0-5

**Release note**:
```release-note
Bump KUBEVIRT_VMWARE to v2.0.0-5
```

Signed-off-by: Piotr Kliczewski <piotr.kliczewski@gmail.com>

(cherry picked from commit a96e371)
kubevirt-bot pushed a commit that referenced this pull request Jul 2, 2020
@nunnatsa @pkliczewski
[Release 2.4] Bump KUBEVIRT_VMWARE v2.0.0-5 (#678) (#680)
f1f02d2 
Bump KUBEVIRT_VMWARE to v2.0.0-5

**Release note**:
```release-note
Bump KUBEVIRT_VMWARE to v2.0.0-5
```

Signed-off-by: Piotr Kliczewski <piotr.kliczewski@gmail.com>

(cherry picked from commit a96e371)

Co-authored-by: Piotr Kliczewski <piotr.kliczewski@gmail.com>
@pkliczewski
Copy link
Contributor Author

Please backport it to v2.4 branch. This version contains a fix for a blocker bug

@orenc1 @nunnatsa was this backported?

@nunnatsa
Copy link
Collaborator

nunnatsa commented Jul 7, 2020

Please backport it to v2.4 branch. This version contains a fix for a blocker bug

@orenc1 @nunnatsa was this backported?

#689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi tiraboschi approved these changes

@djzager djzager Awaiting requested review from djzager

@rwsu rwsu Awaiting requested review from rwsu

Assignees

@tiraboschi tiraboschi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pkliczewski @ovirt-infra @tiraboschi @kubevirt-bot @nunnatsa