Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate Upgrade of the HCO CR's Workloads #825

Merged
merged 5 commits into from
Sep 23, 2020
Merged

Validate Upgrade of the HCO CR's Workloads #825

merged 5 commits into from
Sep 23, 2020

Conversation

nunnatsa
Copy link
Collaborator

Add a check to the webhook, to make sure that the workloads change is acceptable by KubeVirt and CDI operators, by running dry run update of of their CRs.

Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com

Release note:

Validate Upgrade of the HCO CR's Workloads

@kubevirt-bot kubevirt-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 22, 2020
@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow Manage kubevirt CR from sdk generated code #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Sep 22, 2020
@nunnatsa nunnatsa requested review from tiraboschi and removed request for sradco September 22, 2020 15:25
@hco-bot
Copy link
Collaborator

hco-bot commented Sep 22, 2020

hco-e2e-upgrade-prev-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-azure
hco-e2e-image-index-gcp, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-azure
hco-e2e-upgrade-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure, ci/prow/hco-e2e-upgrade-azure, ci/prow/hco-e2e-upgrade-prev-azure

In response to this:

hco-e2e-upgrade-prev-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-azure
hco-e2e-image-index-gcp, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-azure
hco-e2e-upgrade-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member

Please add admissionregistrationv1.Update on https://github.com/kubevirt/hyperconverged-cluster-operator/blob/master/pkg/components/components.go#L773 , to really start using it

@nunnatsa
Validate Upgrade of the HCO CR
5737415 
Add a check to the webhook, to make sure that the workloads change is acceptable by KubeVirt and CDI operators, by running dry run update of of their CRs.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa
fix unit test; add happy case
01867a8 
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa
gofmt
f6962d5 
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa
Register "update" to the admission webhook
e638fb5 
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2020
@tiraboschi
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2020
@nunnatsa
prevent conflict
6d0fe56 
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2020
@nunnatsa
Copy link
Collaborator Author

/test ci-index

@kubevirt-bot
Copy link
Contributor

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test ci-index

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2020
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 23, 2020 •
edited
Loading

@nunnatsa: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/hco-e2e-upgrade-aws 6d0fe56 link /test hco-e2e-upgrade-aws
ci/prow/hco-e2e-image-index-azure 6d0fe56 link /test hco-e2e-image-index-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nunnatsa
Copy link
Collaborator Author

/test hco-e2e-upgrade-aws

@kubevirt-bot
Copy link
Contributor

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-upgrade-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot
Copy link
Contributor

@nunnatsa: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • hco-e2e-image-index-azure

Only the following contexts were expected:

  • ci/prow/ci-index
  • ci/prow/hco-e2e-aws
  • ci/prow/hco-e2e-azure
  • ci/prow/hco-e2e-image-index-aws
  • ci/prow/hco-e2e-image-index-azure
  • ci/prow/hco-e2e-image-index-gcp
  • ci/prow/hco-e2e-upgrade-aws
  • ci/prow/hco-e2e-upgrade-azure
  • ci/prow/hco-e2e-upgrade-prev-aws
  • ci/prow/hco-e2e-upgrade-prev-azure
  • ci/prow/images
  • continuous-integration/travis-ci/pr
  • pull-hyperconverged-cluster-operator-e2e-k8s-1.17
  • tide

In response to this:

/override hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator Author

/override ci/prow/hco-e2e-image-index-azure

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-image-index-azure

In response to this:

/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member

hco-e2e-upgrade-azure passed
/override ci/prow/hco-e2e-upgrade-aws

@kubevirt-bot
Copy link
Contributor

@tiraboschi: Overrode contexts on behalf of tiraboschi: ci/prow/hco-e2e-upgrade-aws

In response to this:

hco-e2e-upgrade-azure passed
/override ci/prow/hco-e2e-upgrade-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit 52db560 into kubevirt:master Sep 23, 2020
@nunnatsa nunnatsa deleted the validate-node-placement branch September 23, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi tiraboschi approved these changes

@yuvalturg yuvalturg Awaiting requested review from yuvalturg

Assignees

@tiraboschi tiraboschi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nunnatsa @ovirt-infra @hco-bot @kubevirt-bot @tiraboschi @openshift-ci-robot