-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a watch predicate to filter on generation or annotation change #926
Conversation
…on change Signed-off-by: Zvi Cahana <zvic@il.ibm.com>
Hello contributor, thanks for submitting a PR for this project! I am the bot who triggers "standard-CI" builds for this project. In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:
|
Hi @zcahana. Thanks for your PR. I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @zcahana. Thanks for your PR. I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hcoutil "github.com/kubevirt/hyperconverged-cluster-operator/pkg/util" | ||
"github.com/kubevirt/hyperconverged-cluster-operator/pkg/util/predicate" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the only actual change to the imports is the addition of github.com/kubevirt/hyperconverged-cluster-operator/pkg/util/predicate
(and removal of sigs.k8s.io/controller-runtime/pkg/predicate
).
The rest is just a re-sort of the packages so that they're grouped by source.
/ok-to-test |
/retest |
@zcahana isn't the vanilla ResourceVersionChangedPredicate enough for this? |
@tiraboschi |
OK, understood. |
If you are going there, we can maybe have one that only filter annotation, and then use the |
/override coverage/coveralls |
@nunnatsa: Overrode contexts on behalf of nunnatsa: coverage/coveralls In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Submitted a similar PR to |
This PR changes the watch events Predicate used the HyperConvereged controller to one that admits updates to the object annotations, even when the object's spec (==> generation) hasn't changed.
Signed-off-by: Zvi Cahana zvic@il.ibm.com
Release note: