-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DownwardMetrics MemoryAllocatedToVirtualServers and add missing ResourceProcessorLimit metrics #9808
Conversation
vhostmd expects[0] the metric showing the physical memory used by the virtual machines (_not_ physical memory usable by the virtual machines), to be called MemoryAllocatedToVirtualServers. [0] https://sourcegraph.com/src.fedoraproject.org/rpms/vhostmd/-/blob/vhostmd.conf Signed-off-by: Javier Cano Cano <jcanocan@redhat.com> Signed-off-by: German Maglione <gmaglione@redhat.com>
/cc @germag |
@jcanocan: GitHub didn't allow me to request PR reviews from the following users: germag. Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-kubevirt-unit-test |
/retest-required |
Removed commit hack: Add the KubeVirt directory as a safe git directory because it was just a temporary hackaround to prevent CI failures. Please refer to #9806 for further details. |
/retest-required |
vhostmd expects[0] to find the `ResourceProcessorLimit` metric, that is the amount of CPU cores defined for the VM. It's the same information that can be obtained using: ``` virsh -r dominfo my-domain-name | grep ^CPU ``` [0] https://sourcegraph.com/src.fedoraproject.org/rpms/vhostmd/-/blob/vhostmd.conf Signed-off-by: Javier Cano Cano <jcanocan@redhat.com> Signed-off-by: German Maglione <gmaglione@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@0xFelix Thanks for your reviews :) |
@jcanocan: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required |
/cc @rmohr could you please take a look? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rmohr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rmohr Many thanks for your time! 😊 |
/retest-required |
1 similar comment
/retest-required |
What this PR does / why we need it:
As part of the SAP certification effort, the DownwardMetrics should be aligned with https://sourcegraph.com/src.fedoraproject.org/rpms/vhostmd/-/blob/vhostmd.conf.
It changes the current state of the DownwardMetrics from:
to:
Please note, this change request has been raised by SAP in: #9673 (comment)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: