-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable DataVolume GC by default in cluster-deploy #9921
Disable DataVolume GC by default in cluster-deploy #9921
Conversation
Prevent DV-related CI failures in the next kubevirt-bot kubevirtci bump PR (with bump-cdi), due to: kubevirt/containerized-data-importer#2754 Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
@@ -21,7 +21,8 @@ set -ex pipefail | |||
|
|||
DOCKER_TAG=${DOCKER_TAG:-devel} | |||
KUBEVIRT_DEPLOY_CDI=${KUBEVIRT_DEPLOY_CDI:-true} | |||
CDI_DV_GC=${CDI_DV_GC:-0} | |||
CDI_DV_GC_DEFAULT=0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will get changed after kubevirt/containerized-data-importer#2754 merges?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, CDI_DV_GC_DEFAULT
will change to -1, so we won’t patch CDIConfig here unless explicitly asked by CDI_DV_GC
. However, unfortunately some KubeVirt func tests currently need to know what the GC default is (whether CDIConfig.Spec.DataVolumeTTLSeconds
== nil means GC enabled/disabled), and once CDI new default is consumed by KubeVirt this line also needs to be fixed. We once considered adding CDIConfig.Status.DataVolumeTTLSeconds
reflecting the state also when it's default (-1/0) so KubeVirt won't need to have the knowledge, however we decided that it just complicates things.
/retest-required |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubevirt-e2e-kind-1.27-vgpu |
/retest-required |
What this PR does / why we need it:
Prevent DV-related CI failures in the next kubevirt-bot kubevirtci bump PR (with bump-cdi), due to:
kubevirt/containerized-data-importer#2754
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: