Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update whereabouts image tag to match the manifest version #838

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Update whereabouts image tag to match the manifest version #838

merged 1 commit into from
Jul 18, 2022

Conversation

brianmcarey
Copy link
Member

@brianmcarey brianmcarey commented Jul 18, 2022 •
edited
Loading

An issue has occurred when using the latest whereabouts image as the
ip-reconciler has been moved[1]. Updating the image tag to match the
manifest version v0.5

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirtci/835/check-provision-k8s-1.23/1548876282610061312

/cc @oshoval @enp0s3

[1] k8snetworkplumbingwg/whereabouts@545f055

Signed-off-by: Brian Carey bcarey@redhat.com

@brianmcarey
Update whereabouts image tag to match the manifest version
ccda26e 
An issue has occurred when using the latest whereabouts image as the
ip-reconciler has been moved. Updating the image tag to match the
manifest version v0.5

Signed-off-by: Brian Carey <bcarey@redhat.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Jul 18, 2022
oshoval
oshoval approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@oshoval oshoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks
Can you please open an issue that we need to take care about it when bumping ?
(there are some kustomization scripts that need to be changed and such as well)

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2022
@brianmcarey
Copy link
Member Author

/cc @maiqueb

@maiqueb maiqueb mentioned this pull request Jul 18, 2022
Closed
enp0s3
enp0s3 approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@enp0s3 enp0s3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enp0s3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2022
@oshoval
Copy link
Contributor

oshoval commented Jul 18, 2022 •
edited
Loading

Note that we usually keep the original manifest untouched and then sed / kustomize / apply diff file on it etc
But since it seems it will be fixed in whereabouts itself, it is fine for now

@oshoval
Copy link
Contributor

oshoval commented Jul 18, 2022

It seems that the errors here is when it fails to deploy the CNI, that happens here and there on CI / locally

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirtci/838/check-provision-k8s-1.24/1548984582387273728
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirtci/838/check-provision-k8s-1.24-ipv6/1548984582571823104

@kubevirt-bot kubevirt-bot merged commit c5e8e26 into kubevirt:main Jul 18, 2022
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Jul 20, 2022
@kubevirt-bot
Bump kubevirtci
1b93bb5 
[203b112 single stack: Remove k8s-1.22-ipv6](kubevirt/kubevirtci#832)
[fe50adf k8s providers: Delete k8s-1.21](kubevirt/kubevirtci#831)
[19ba37d cluster-up, kind: add kind-1.23](kubevirt/kubevirtci#784)
[17bbea6 Update the qemu sound devices to use the -device flag](kubevirt/kubevirtci#828)
[c5e8e26 Update whereabouts image tag to match the manifest version](kubevirt/kubevirtci#838)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
@kubevirt-bot kubevirt-bot mentioned this pull request Jul 20, 2022
Closed
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Jul 21, 2022
@kubevirt-bot
Bump kubevirtci
37f0d95 
[ba7681a vm based providers: Pin NetworkManager version](kubevirt/kubevirtci#841)
[203b112 single stack: Remove k8s-1.22-ipv6](kubevirt/kubevirtci#832)
[fe50adf k8s providers: Delete k8s-1.21](kubevirt/kubevirtci#831)
[19ba37d cluster-up, kind: add kind-1.23](kubevirt/kubevirtci#784)
[17bbea6 Update the qemu sound devices to use the -device flag](kubevirt/kubevirtci#828)
[c5e8e26 Update whereabouts image tag to match the manifest version](kubevirt/kubevirtci#838)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
@kubevirt-bot kubevirt-bot mentioned this pull request Jul 21, 2022
Closed
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Jul 21, 2022
@kubevirt-bot
Bump kubevirtci
3558913 
[ba7681a vm based providers: Pin NetworkManager version](kubevirt/kubevirtci#841)
[203b112 single stack: Remove k8s-1.22-ipv6](kubevirt/kubevirtci#832)
[fe50adf k8s providers: Delete k8s-1.21](kubevirt/kubevirtci#831)
[19ba37d cluster-up, kind: add kind-1.23](kubevirt/kubevirtci#784)
[17bbea6 Update the qemu sound devices to use the -device flag](kubevirt/kubevirtci#828)
[c5e8e26 Update whereabouts image tag to match the manifest version](kubevirt/kubevirtci#838)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
@kubevirt-bot kubevirt-bot mentioned this pull request Jul 21, 2022
Merged
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Jul 24, 2022
@kubevirt-bot
Bump kubevirtci
679fe08 
[cf26ea6 podman: Present socket env var](kubevirt/kubevirtci#833)
[3fa3125 add sg3 util](kubevirt/kubevirtci#842)
[ba7681a vm based providers: Pin NetworkManager version](kubevirt/kubevirtci#841)
[203b112 single stack: Remove k8s-1.22-ipv6](kubevirt/kubevirtci#832)
[fe50adf k8s providers: Delete k8s-1.21](kubevirt/kubevirtci#831)
[19ba37d cluster-up, kind: add kind-1.23](kubevirt/kubevirtci#784)
[17bbea6 Update the qemu sound devices to use the -device flag](kubevirt/kubevirtci#828)
[c5e8e26 Update whereabouts image tag to match the manifest version](kubevirt/kubevirtci#838)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Jul 24, 2022
@kubevirt-bot
Bump kubevirtci
5504d2e 
[cf26ea6 podman: Present socket env var](kubevirt/kubevirtci#833)
[3fa3125 add sg3 util](kubevirt/kubevirtci#842)
[ba7681a vm based providers: Pin NetworkManager version](kubevirt/kubevirtci#841)
[203b112 single stack: Remove k8s-1.22-ipv6](kubevirt/kubevirtci#832)
[fe50adf k8s providers: Delete k8s-1.21](kubevirt/kubevirtci#831)
[19ba37d cluster-up, kind: add kind-1.23](kubevirt/kubevirtci#784)
[17bbea6 Update the qemu sound devices to use the -device flag](kubevirt/kubevirtci#828)
[c5e8e26 Update whereabouts image tag to match the manifest version](kubevirt/kubevirtci#838)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Jul 25, 2022
@kubevirt-bot
Bump kubevirtci
dd69c1c 
[3a5c590 vm based: Update readme about using console](kubevirt/kubevirtci#844)
[cf26ea6 podman: Present socket env var](kubevirt/kubevirtci#833)
[3fa3125 add sg3 util](kubevirt/kubevirtci#842)
[ba7681a vm based providers: Pin NetworkManager version](kubevirt/kubevirtci#841)
[203b112 single stack: Remove k8s-1.22-ipv6](kubevirt/kubevirtci#832)
[fe50adf k8s providers: Delete k8s-1.21](kubevirt/kubevirtci#831)
[19ba37d cluster-up, kind: add kind-1.23](kubevirt/kubevirtci#784)
[17bbea6 Update the qemu sound devices to use the -device flag](kubevirt/kubevirtci#828)
[c5e8e26 Update whereabouts image tag to match the manifest version](kubevirt/kubevirtci#838)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
@jean-edouard
Copy link
Contributor

@brianmcarey v0.5 appears to be buggy, I'll upgrade us to the latest release, v.0.5.4.
You mentioned a concern about the ip-reconciler being moved, could you please tell us more so I can address it as part of my PR?
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maiqueb maiqueb maiqueb approved these changes

@oshoval oshoval oshoval approved these changes

@enp0s3 enp0s3 enp0s3 approved these changes

Assignees

@maiqueb maiqueb

@oshoval oshoval

@enp0s3 enp0s3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@brianmcarey @kubevirt-bot @oshoval @jean-edouard @maiqueb @enp0s3