-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cni: add promiscous mode knob #98
Conversation
@fizzers123 would you be willing to give this PR a test drive and see if it fixes your reported issue ? (#97) |
fdea0bf
to
88a664e
Compare
I got it running, unfortunately, the interface option "PROMISC" doesn't seem to be set. ---
kind: ConfigMap
apiVersion: v1
metadata:
name: macvtap-deviceplugin-config
data:
DP_MACVTAP_CONF: |
[
{
"name" : "ens18",
"lowerDevice" : "ens18",
"mode" : "bridge",
"capacity" : 50,
"promiscMode": true
}
]
Here is the container I build to deploy it: https://hub.docker.com/r/fizzers123/macvtap-cni/tags |
Ah you are configuring the device plugin. You should configure the CNI configuration instead, i.e. the net-attach-def, as per the docs. I'd say it would be something like: apiVersion: k8s.cni.cncf.io/v1
metadata:
name: dataplane
annotations:
k8s.v1.cni.cncf.io/resourceName: macvtap.network.kubevirt.io/dataplane
spec:
config: '{
"cniVersion": "0.3.1",
"name": "dataplane",
"type": "macvtap",
"mtu": 1500,
"promiscMode": true # <==== this one!!!
}' |
Whoops, my bad. It works now as expected. LLDP works as well :)
Thanks a lot for your dedication! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
88a664e
to
f1a6be8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maiqueb, phoracek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds a know allowing users to configure the pod side of the veth as promiscous, which would allow the attached VM to be discovered via LLDP.
Special notes for your reviewer:
Fixes: #97
Release note: