-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alert CDIMultipleDefaultVirtStorageClasses #201
Conversation
/cc @sradco |
8c0a4f9
to
00719f1
Compare
|
||
## Meaning | ||
|
||
The default virtualization storage class takes precedence over k8s default storage class for VM disk image creation purposes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
k8s > Kubernetes
Suggestion:
This alert fires when more than one default virtualization storage class exists.
A default virtualization storage class has precedence over a default Kubernetes storage class for creating a VirtualMachine disk image.
|
||
The default virtualization storage class takes precedence over k8s default storage class for VM disk image creation purposes. | ||
|
||
This alert fires when there are multiple default virtualization storage classes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would move this sentence to the beginning of the section for consistency with other runbooks.
|
||
## Impact | ||
|
||
With multiple default storage classes present, any DataVolume requesting the default storage class (not explicitly specifying a storage class name) gets the most recently created default storage class, regardless of the default status of that storage class, and the administrator receives an alert. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
If more than one default [do we need to mention "virtualization"?] storage class exists, a data volume that requests a default storage class, without specifying a storage class name, receives the most recently created default storage class.
|
||
## Diagnosis | ||
|
||
Observe multiple storage classes are marked as default for virtualization purposes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
Obtain a list of default virtualization storage classes by running the following command:
|
||
## Mitigation | ||
|
||
Ensure the default virtualization storage class annotation is only present on a single storage class of your choice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
Ensure that only one storage class has the default virtualization storage class annotation.
@akalenyu Is this alert for 4.14? |
4.15 |
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
00719f1
to
53cae1e
Compare
/lgtm @apinnick Can I merge ? |
/lgtm |
D/S runbook task for 4.15 - CNV-35292 |
Related to kubevirt/containerized-data-importer#2913 efforts