Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alert CDIMultipleDefaultVirtStorageClasses #201

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

akalenyu
Copy link
Contributor

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Oct 10, 2023
@akalenyu
Copy link
Contributor Author

/cc @sradco


## Meaning

The default virtualization storage class takes precedence over k8s default storage class for VM disk image creation purposes.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k8s > Kubernetes

Suggestion:

This alert fires when more than one default virtualization storage class exists.

A default virtualization storage class has precedence over a default Kubernetes storage class for creating a VirtualMachine disk image.


The default virtualization storage class takes precedence over k8s default storage class for VM disk image creation purposes.

This alert fires when there are multiple default virtualization storage classes.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move this sentence to the beginning of the section for consistency with other runbooks.


## Impact

With multiple default storage classes present, any DataVolume requesting the default storage class (not explicitly specifying a storage class name) gets the most recently created default storage class, regardless of the default status of that storage class, and the administrator receives an alert.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:
If more than one default [do we need to mention "virtualization"?] storage class exists, a data volume that requests a default storage class, without specifying a storage class name, receives the most recently created default storage class.


## Diagnosis

Observe multiple storage classes are marked as default for virtualization purposes:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

Obtain a list of default virtualization storage classes by running the following command:


## Mitigation

Ensure the default virtualization storage class annotation is only present on a single storage class of your choice.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

Ensure that only one storage class has the default virtualization storage class annotation.

@apinnick
Copy link
Collaborator

@akalenyu Is this alert for 4.14?

@akalenyu
Copy link
Contributor Author

@akalenyu Is this alert for 4.14?

4.15

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
@akalenyu
Copy link
Contributor Author

@sradco @apinnick addressed comments

@sradco
Copy link
Collaborator

sradco commented Oct 30, 2023

/lgtm

@apinnick Can I merge ?

@apinnick
Copy link
Collaborator

/lgtm

@sradco sradco merged commit 1e0049f into kubevirt:main Nov 16, 2023
1 check passed
@apinnick
Copy link
Collaborator

D/S runbook task for 4.15 - CNV-35292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants